summaryrefslogtreecommitdiff
path: root/meta/recipes-extended/zip/zip-3.0/fix-security-format.patch
blob: 19d8548273e85b1d0b4e4cc81da8e61e0f5a8b02 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
zip: Fixing security formatting issues

Fix security formatting issues related to printing without NULL argument

zip.c: In function 'help_extended':
zip.c:1031:5: error: format not a string literal and no format arguments [-Werror=format-security]
     printf(text[i]);
     ^
zip.c: In function 'version_info':
zip.c:1228:5: error: format not a string literal and no format arguments [-Werror=format-security]
     printf(cryptnote[i]);
     ^

[YOCTO #9552]
[https://bugzilla.yoctoproject.org/show_bug.cgi?id=9552]

Upstream-Status: Pending

Signed-off-by: Edwin Plauchu <edwin.plauchu.camacho@intel.com>

diff --git a/zip.c b/zip.c
index 439821f..d7da768 100644
--- a/zip.c
+++ b/zip.c
@@ -1028,7 +1028,7 @@ local void help_extended()
 
   for (i = 0; i < sizeof(text)/sizeof(char *); i++)
   {
-    printf(text[i]);
+    fputs(text[i],stdout);
     putchar('\n');
   }
 #ifdef DOS
@@ -1225,7 +1225,7 @@ local void version_info()
             CR_MAJORVER, CR_MINORVER, CR_BETA_VER, CR_VERSION_DATE);
   for (i = 0; i < sizeof(cryptnote)/sizeof(char *); i++)
   {
-    printf(cryptnote[i]);
+    fputs(cryptnote[i],stdout);
     putchar('\n');
   }
   ++i;  /* crypt support means there IS at least one compilation option */