summaryrefslogtreecommitdiff
path: root/meta
diff options
context:
space:
mode:
authorPhil Blundell <philb@gnu.org>2012-10-15 11:28:00 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2012-10-18 12:03:30 +0100
commit91769af1c1175ac9bb43d16d05fb1c8736dd9287 (patch)
tree81963c0b9e7ab88050ff0c6a8754466eed212c9d /meta
parentbf19eeb9f65e91bf2b5d89e7c0b099c55d7c15ff (diff)
downloadopenembedded-core-91769af1c1175ac9bb43d16d05fb1c8736dd9287.tar.gz
openembedded-core-91769af1c1175ac9bb43d16d05fb1c8736dd9287.tar.bz2
openembedded-core-91769af1c1175ac9bb43d16d05fb1c8736dd9287.zip
insane: Don't try to run objdump on symlinks
If the link is absolute then we might end up reading from a host binary or a nonexistent path, neither of which will produce useful results and may result in objdump failure and python backtrace spew. If the link does point to a binary within the installation root then we will scan the pointed-to file at some point anyway so there is no need to do it again. Signed-off-by: Phil Blundell <pb@pbcl.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
-rw-r--r--meta/classes/insane.bbclass6
1 files changed, 6 insertions, 0 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 2b4841933c..71a9a588c3 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -157,6 +157,9 @@ def package_qa_check_rpath(file,name, d, elf, messages):
if not elf:
return
+ if os.path.islink(file):
+ return
+
bad_dirs = [d.getVar('TMPDIR', True) + "/work", d.getVar('STAGING_DIR_TARGET', True)]
bad_dir_test = d.getVar('TMPDIR', True)
@@ -186,6 +189,9 @@ def package_qa_check_useless_rpaths(file, name, d, elf, messages):
if not elf:
return
+ if os.path.islink(file):
+ return
+
libdir = d.getVar("libdir", True)
base_libdir = d.getVar("base_libdir", True)