diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-09-06 14:14:34 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-09-06 23:01:51 +0100 |
| commit | c0551436974d179df23418567f18a082830380f6 (patch) | |
| tree | 9c5fd0fb62eb17f9a19ff8cd27ffb357d10dd92d | |
| parent | 753be24f0bd63520b6840d1a68500f5bb38f086d (diff) | |
| download | openembedded-core-c0551436974d179df23418567f18a082830380f6.tar.gz openembedded-core-c0551436974d179df23418567f18a082830380f6.tar.bz2 openembedded-core-c0551436974d179df23418567f18a082830380f6.zip | |
lib/oeqa/qemurunner: Use a timeout in select() call
A 0 value to select.select() immediately returns with no timeout. This was
pegging the cpu at 100% for the python process which was bad and may be
contributing to some of the timeout problems.
Profile from -P of a core-image-minimal before:
97526792 function calls (97525652 primitive calls) in 45.189 seconds
and after:
50204 function calls (49064 primitive calls) in 17.318 seconds
Saving 97.5 million function calls has to be good :)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/lib/oeqa/utils/qemurunner.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/lib/oeqa/utils/qemurunner.py b/meta/lib/oeqa/utils/qemurunner.py index e7bd8b147b..b5c757a927 100644 --- a/meta/lib/oeqa/utils/qemurunner.py +++ b/meta/lib/oeqa/utils/qemurunner.py @@ -101,7 +101,7 @@ class QemuRunner: reachedlogin = False stopread = False while time.time() < endtime and not stopread: - sread, swrite, serror = select.select(socklist, [], [], 0) + sread, swrite, serror = select.select(socklist, [], [], 5) for sock in sread: if sock is self.server_socket: self.qemusock, addr = self.server_socket.accept() |