diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-01-29 13:39:08 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-01-30 14:08:08 +0000 |
| commit | a8ba821d0002e4395fc5c80649fe14f93a7971fe (patch) | |
| tree | c542d492d8b5eae7844b6e3b06572b83feec0bf7 | |
| parent | 3917409004a830e7ad0646f05ad7421385cbd1de (diff) | |
| download | openembedded-core-a8ba821d0002e4395fc5c80649fe14f93a7971fe.tar.gz openembedded-core-a8ba821d0002e4395fc5c80649fe14f93a7971fe.tar.bz2 openembedded-core-a8ba821d0002e4395fc5c80649fe14f93a7971fe.zip | |
insane.bbclass: Fix incorrect getVar call
On a trace I was a bit puzzled why getVar was making 180 calls to len(d).
This is an expensive operation that should be very rarely called and
certainly not by getVar. In perl's do_package it was resulting in
~1.5 million function calls from those 180 cases.
Ultimately this typo was why. Lets fix it and save the CPU cyles.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/classes/insane.bbclass | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index c5c84b80c7..015abd54ca 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -404,7 +404,7 @@ def package_qa_check_arch(path,name,d, elf, messages): target_os = d.getVar('TARGET_OS', True) target_arch = d.getVar('TARGET_ARCH', True) - provides = d.getVar('PROVIDES', d, True) + provides = d.getVar('PROVIDES', True) bpn = d.getVar('BPN', True) # FIXME: Cross package confuse this check, so just skip them |