diff options
| author | Paul Eggleton <paul.eggleton@linux.intel.com> | 2017-10-27 10:12:47 +1300 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-11-10 14:44:31 +0000 |
| commit | 7e84a777aa924a237b4e604120ebf8a4b3ba53b2 (patch) | |
| tree | 47ef9a607740b1b8c36edf93b9b9778288bc5f03 | |
| parent | 284426dbad91a3c52eaf7da5c58fe8a2c2dfb826 (diff) | |
| download | openembedded-core-7e84a777aa924a237b4e604120ebf8a4b3ba53b2.tar.gz openembedded-core-7e84a777aa924a237b4e604120ebf8a4b3ba53b2.tar.bz2 openembedded-core-7e84a777aa924a237b4e604120ebf8a4b3ba53b2.zip | |
recipetool: create: show a warning for github archive URLs
github archive URLs are not guaranteed to be stable [1] and thus we
should show a warning if a user specifies one to recipetool create (or
devtool add).
[1] http://lists.openembedded.org/pipermail/openembedded-core/2017-September/142519.html
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
| -rw-r--r-- | scripts/lib/recipetool/create.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py index 055bdef436..54e7e85396 100644 --- a/scripts/lib/recipetool/create.py +++ b/scripts/lib/recipetool/create.py @@ -433,6 +433,9 @@ def create_recipe(args): source = 'file://%s' % os.path.abspath(source) if scriptutils.is_src_url(source): + # Warn about github archive URLs + if re.match('https?://github.com/[^/]+/[^/]+/archive/.+(\.tar\..*|\.zip)$', source): + logger.warn('github archive files are not guaranteed to be stable and may be re-generated over time. If the latter occurs, the checksums will likely change and the recipe will fail at do_fetch. It is recommended that you point to an actual commit or tag in the repository instead (using the repository URL in conjunction with the -S/--srcrev option).') # Fetch a URL fetchuri = reformat_git_uri(urldefrag(source)[0]) if args.binary: |