summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephano Cetola <stephano.cetola@linux.intel.com>2017-03-27 10:01:36 -0700
committerRichard Purdie <richard.purdie@linuxfoundation.org>2017-03-28 08:41:08 +0100
commit72bec63ab0e78753fb6ed1794d11beef9485c014 (patch)
treee9edfaf6e06ffdd505f98edfc41b09f400dd2c77
parentd6b139ef1b52ee4842f8706c1b8b950cc50a3d54 (diff)
downloadopenembedded-core-72bec63ab0e78753fb6ed1794d11beef9485c014.tar.gz
openembedded-core-72bec63ab0e78753fb6ed1794d11beef9485c014.tar.bz2
openembedded-core-72bec63ab0e78753fb6ed1794d11beef9485c014.zip
devtool: open kconfig fragment in binary mode
When devtool writes to the kconfig fragment, it writes the output of the diff command returned from pipe.communicate(). This function returns binary objects. We should open the kconfig fragment file in binary mode if we expect to write binary objects to it. [YOCTO #11171] Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--scripts/lib/devtool/standard.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index 07c1400388..ffca2c9ec4 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -1223,7 +1223,7 @@ def _create_kconfig_diff(srctree, rd, outfile):
stdout, stderr = pipe.communicate()
if pipe.returncode == 1:
logger.info("Updating config fragment %s" % outfile)
- with open(outfile, 'w') as fobj:
+ with open(outfile, 'wb') as fobj:
fobj.write(stdout)
elif pipe.returncode == 0:
logger.info("Would remove config fragment %s" % outfile)