diff options
| author | Paul Eggleton <paul.eggleton@linux.intel.com> | 2016-01-23 01:00:01 +1300 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-01-22 23:42:57 +0000 |
| commit | 578d3873a6415c9203c185c21cff472f7d2dab02 (patch) | |
| tree | 75c2ad9dc3c6c0327b61662f78accc304cf64f59 | |
| parent | 308189beda8a31541481d09e3d5e86187e843d8d (diff) | |
| download | openembedded-core-578d3873a6415c9203c185c21cff472f7d2dab02.tar.gz openembedded-core-578d3873a6415c9203c185c21cff472f7d2dab02.tar.bz2 openembedded-core-578d3873a6415c9203c185c21cff472f7d2dab02.zip | |
recipetool: create: better fix for fetch error handling
I was a little bit hasty in OE-Core revision
c2cc5abe34169eae92067d97ce1e747e7c1413f5 - it turns out BitBake's
fetcher code is not consistent in whether it logs something useful or
not; when fetching from an http URL it does but with a git repository
it doesn't. In advance of any major reworking of fetch error handling in
BitBake, let's just print the text of the exception and then we know we
have shown something to the user.
Additionally, we were only catching FetchException here but there are
several other classes of exception that the fetcher can raise (e.g.
MalformedUrl); catch the parent BBFetchException class instead so we
avoid tracebacks for those other classes as well.
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | scripts/lib/recipetool/create.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py index f0bb58e4bd..5f90b10353 100644 --- a/scripts/lib/recipetool/create.py +++ b/scripts/lib/recipetool/create.py @@ -299,8 +299,8 @@ def create_recipe(args): logger.info('Fetching %s...' % srcuri) try: checksums = scriptutils.fetch_uri(tinfoil.config_data, fetchuri, srctree, srcrev) - except bb.fetch2.FetchError: - # Error already printed + except bb.fetch2.BBFetchException as e: + logger.error(str(e).rstrip()) sys.exit(1) dirlist = os.listdir(srctree) if 'git.indirectionsymlink' in dirlist: |