summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2017-01-21 13:55:36 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2017-01-22 09:05:04 +0000
commit18160442869f56ee71538bc2dc60d7cb6c08c8a2 (patch)
tree19305552893502474f775f2f0dc3a9f7d6e706fb
parentb631fe91b3939b7981dbf62cb2fb70f7baebe403 (diff)
downloadopenembedded-core-18160442869f56ee71538bc2dc60d7cb6c08c8a2.tar.gz
openembedded-core-18160442869f56ee71538bc2dc60d7cb6c08c8a2.tar.bz2
openembedded-core-18160442869f56ee71538bc2dc60d7cb6c08c8a2.zip
package_deb: Improve failure debug output
Currently if the dpkg-deb command fails you see an error message like this: ERROR: nss-3.27.1-r0 do_package_write_deb: dpkg-deb execution failed ERROR: nss-3.27.1-r0 do_package_write_deb: Function failed: do_package_deb which is pretty much useless. If we use subprocess.check_output, we see a traceback and then: Exception: subprocess.CalledProcessError: Command '<cmd>' returned non-zero exit status 1 Subprocess output: <output> which is much easier to debug from. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/package_deb.bbclass5
1 files changed, 1 insertions, 4 deletions
diff --git a/meta/classes/package_deb.bbclass b/meta/classes/package_deb.bbclass
index 6ce008f1ac..2a70b50c9f 100644
--- a/meta/classes/package_deb.bbclass
+++ b/meta/classes/package_deb.bbclass
@@ -308,10 +308,7 @@ python do_package_deb () {
conffiles.close()
os.chdir(basedir)
- ret = subprocess.call("PATH=\"%s\" dpkg-deb -b %s %s" % (localdata.getVar("PATH"), root, pkgoutdir), shell=True)
- if ret != 0:
- bb.utils.unlockfile(lf)
- bb.fatal("dpkg-deb execution failed")
+ subprocess.check_output("PATH=\"%s\" dpkg-deb -b %s %s" % (localdata.getVar("PATH"), root, pkgoutdir), shell=True)
cleanupcontrol(root)
bb.utils.unlockfile(lf)