diff options
| author | Olof Johansson <olof.johansson@axis.com> | 2013-07-22 11:35:47 +0200 |
|---|---|---|
| committer | Saul Wold <sgw@linux.intel.com> | 2013-07-25 23:44:27 -0700 |
| commit | 0a2dffefc6fbca37ce9604117cebc2f7d4abc1c6 (patch) | |
| tree | 09f5dd1214c499e80d6a782810cce6df18dc5055 | |
| parent | 03e745f18f9da22cfba53bb0057bdb0af4a49fca (diff) | |
| download | openembedded-core-0a2dffefc6fbca37ce9604117cebc2f7d4abc1c6.tar.gz openembedded-core-0a2dffefc6fbca37ce9604117cebc2f7d4abc1c6.tar.bz2 openembedded-core-0a2dffefc6fbca37ce9604117cebc2f7d4abc1c6.zip | |
cpan.bbclass: Fail unless Makefile.PL generates Makefile
Makefile.PLs can exit with success without generating a Makefile,
e.g. in cases of missing configure time dependencies. This is
considered a best practice by cpantesters.org. See:
* http://wiki.cpantesters.org/wiki/CPANAuthorNotes
* http://www.nntp.perl.org/group/perl.qa/2008/08/msg11236.html
Signed-off-by: Olof Johansson <olof.johansson@axis.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
| -rw-r--r-- | meta/classes/cpan.bbclass | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass index bef9e82685..7088039fa0 100644 --- a/meta/classes/cpan.bbclass +++ b/meta/classes/cpan.bbclass @@ -18,6 +18,15 @@ export PERLHOSTLIB = "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_vers cpan_do_configure () { export PERL5LIB="${PERL_ARCHLIB}" yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL ${EXTRA_CPANFLAGS} + + # Makefile.PLs can exit with success without generating a + # Makefile, e.g. in cases of missing configure time + # dependencies. This is considered a best practice by + # cpantesters.org. See: + # * http://wiki.cpantesters.org/wiki/CPANAuthorNotes + # * http://www.nntp.perl.org/group/perl.qa/2008/08/msg11236.html + [ -e Makefile ] || bbfatal "No Makefile was generated by Makefile.PL" + if [ "${BUILD_SYS}" != "${HOST_SYS}" ]; then . ${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/config.sh # Use find since there can be a Makefile generated for each Makefile.PL |