summaryrefslogtreecommitdiff
path: root/packages/gdb
AgeCommit message (Collapse)AuthorFiles
2005-06-30import clean BK tree at cset 1.3670Koen Kooi13
2005-06-15Merge bk://oe-devel.bkbits.net/openembeddedJohn Bowler1
into marsco.kalmiopsis:/home/nslu2/openembedded 2005/06/15 12:55:22+02:00 utwente.nl!koen sapwood_1.20-1.bb: extra install_append, courtesy Florian Boor osso-gnome-vfs2_2.8.4.4-1.bb: adjust depends, courtesy Florian Boor Many files: added, courtesy Florian Boor hildon-libs_0.9.6-2.bb: adjust staging, courtesy Florian Boor 2005/06/15 12:18:24+02:00 uni-frankfurt.de!mickeyl add mathomatic, a small, portable, general purpose CAS. Patch courtesy Simon Pickering 2005/06/15 11:58:18+02:00 utwente.nl!koen Many meamo files: source -> ., courtesy Florian Boor Add gconf-osso, part of the maemo.org suite, courtesy Florian Boor 2005/06/15 11:45:40+02:00 utwente.nl!koen base-files_3.0.14.bb: support nokia770, courtesy Florian Boor 2005/06/15 11:05:24+02:00 handhelds.org!CoreDump Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into handhelds.org:/home/mhentges/OpenEmbedded/bitbake/openembedded 2005/06/15 11:05:02+02:00 handhelds.org!CoreDump altboot: Add a timeout on boot and only show the menu when requested 2005/06/15 10:29:53+02:00 mn-solutions.de!schurig assorted MNCI / RT3000 changes 2005/06/15 10:27:59+02:00 mn-solutions.de!schurig classes/rootfs_ipk.bbclass: allows to keep the Packages file (my own python script to create Packages is way faster :-) 2005/06/14 22:59:08+01:00 reciva.com!pb use mkdir -p, not install -d 2005/06/14 22:02:28+02:00 utwente.nl!koen Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into bitbake.utwente.nl:/home/koen/OE/openembedded 2005/06/14 22:02:15+02:00 utwente.nl!koen xmame_0.95.bb: remove UNNECESSARY and BOGUS qpe crap. Can we please stop committing such nonsonse? virtual/libsdl exists for a reason 2005/06/14 21:01:19+01:00 reciva.com!pb apply PARALLEL_INSTALL_MODULES patch from Erik Hovland 2005/06/14 20:55:08+01:00 reciva.com!pb update xmame to 0.95, courtesy Erik Hovland 2005/06/14 20:52:19+01:00 reciva.com!pb update handhelds-pxa kernel to hh40, courtesy Erik Hovland 2005/06/14 19:10:13+02:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into r2d2.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/06/14 19:00:35+02:00 uni-frankfurt.de!mickeyl Add tslib config files for omap5912osk. Patch courtesy philip@balister.org 2005/06/14 18:59:02+02:00 uni-frankfurt.de!mickeyl Fix Typo in xerces-c. Patch courtesy philip@balister.org 2005/06/14 13:45:03+02:00 local!hrw Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into marcinj.local:/home/hrw/zaurus/oe/openembedded 2005/06/14 13:44:34+02:00 local!hrw updated kdepimpi to 2.1.5 2005/06/14 13:16:38+02:00 handhelds.org!CoreDump Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into handhelds.org:/home/mhentges/OpenEmbedded/bitbake/openembedded 2005/06/14 13:16:14+02:00 handhelds.org!CoreDump altboot: Update to latest version 2005/06/14 13:13:37+02:00 utwente.nl!koen Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into bitbake.utwente.nl:/home/koen/OE/openembedded 2005/06/14 13:13:23+02:00 utwente.nl!koen Add tune-supersparc.conf for people who have v8 cpu's and want hardware integer multiply and divide. Makes ssh login approx. 30 times faster 2005/06/14 11:55:00+01:00 reciva.com!pb Merge bk://oe-devel@openembedded-devel.bkbits.net/openembedded into mill.internal.reciva.com:/nexus/home/pb/oe/oe 2005/06/14 11:52:01+01:00 reciva.com!pb eliminate spare copy of sun4cdm kernel preference 2005/06/14 12:43:33+02:00 mn-solutions.de!schurig Merge bk://oe-devel@oe-devel.bkbits.net/openembedded/ into mnz66.mn-solutions.de:/usr/src/mnci54/oe 2005/06/14 12:43:12+02:00 mn-solutions.de!schurig renamed MACHINE 'ramses' to 'mnci' added new MACHINE 'rt3000' renamed DISTRO 'openmnci' to 'openmn', which now is for both MNCI and RT3000 2005/06/14 09:52:19+02:00 mn-solutions.de!schurig Merge bk://oe-devel@oe-devel.bkbits.net/openembedded/ into mnz66.mn-solutions.de:/usr/src/mnci54/oe 2005/06/10 09:37:26+02:00 mn-solutions.de!schurig Merge bk://oe-devel@oe-devel.bkbits.net/openembedded/ into mnz66.mn-solutions.de:/usr/src/mnci54/oe 2005/06/08 10:05:02+02:00 mn-solutions.de!schurig Merge bk://oe-devel@oe-devel.bkbits.net/openembedded/ into mnz66.mn-solutions.de:/usr/src/mnci54/oe 2005/06/08 09:16:06+02:00 mn-solutions.de!schurig icewm: use sourceforge mirror BKrev: 42b037e5CrddHepCs3gW5YAsfOQ7ng
2005-03-23Merge nslu2-linux@nslu2-linux.bkbits.net:openembeddedg2@giantshoulder.com1
into giantshoulder.com:/home/tom/dev/openslug/openembedded 2005/03/23 08:41:50-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/23 16:34:02+00:00 rpsys.net!RP Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into tim.rpsys.net:/usr/oe/openembedded 2005/03/23 16:32:05+00:00 rpsys.net!RP openzaurus-2.6: fix typo 2005/03/23 17:31:58+01:00 local!hrw Merge bk://oe-devel@oe-devel.bkbits.net/openembedded/ into marcinj.local:/home/hrw/zaurus/bb/openembedded 2005/03/23 17:31:35+01:00 local!hrw updated kdepimpi to 2.0.20 2005/03/23 07:41:31-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/23 16:38:17+01:00 zeckescompany.nl!alwin changed package-dep for meta-opie 2005/03/24 00:32:02+10:30 (none)!rwhitby Merge bk://nslu2-linux@nslu2-linux.bkbits.net/openembedded into home.(none):/home/bitbake/openembedded 2005/03/24 00:31:35+10:30 (none)!rwhitby Made Unslung *not* create ramdisk for /var and /dev when you've unslung to an external disk 2005/03/23 05:41:22-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/24 00:15:58+10:30 (none)!rwhitby Fixed the unslung patch for rc.1 2005/03/24 00:06:41+10:30 (none)!rwhitby Merge bk://nslu2-linux@nslu2-linux.bkbits.net/openembedded into home.(none):/home/bitbake/openembedded 2005/03/24 00:06:21+10:30 (none)!rwhitby Unslung 4.7-alpha, with support for external disks on sda1, sda2, sdb1, sdb2. 2005/03/23 14:26:04+01:00 uni-frankfurt.de!mickeyl rename wlan-ng-modules package per upstream changes 2005/03/23 14:23:31+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into r2d2.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/03/23 14:23:20+01:00 uni-frankfurt.de!mickeyl add remind, a console PIM application. in nonworking, because it needs a gcc3.x patch 2005/03/23 04:41:30-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/23 13:34:56+01:00 mn-solutions.de!schurig Various twiddles for MNCI "Ramses": qmake-native: remove my weird attempt to get things right, it was very wrong :-) gdb: add REPENDS on libthread-db1 to allow debugging of threaded Qt/E 3.x apps kernel: add bluez-modules sysvinit: make startup even faster by removing access to /proc/progress 2005/03/23 03:41:24-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/23 22:12:18+10:30 (none)!rwhitby Merge bk://nslu2-linux@nslu2-linux.bkbits.net/openembedded into home.(none):/home/bitbake/openembedded 2005/03/23 22:11:52+10:30 (none)!rwhitby Added lots of modules for traffic shaping and other various things to OpenSlug kernel 2005/03/23 12:14:09+01:00 (none)!br1 Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into null.(none):/data/mtx/closed/build/unstable/openembedded 2005/03/23 12:13:44+01:00 (none)!br1 fixed hostapd 0.3.7 and added wpa_supplicant 0.3.8 2005/03/23 11:41:30+01:00 uni-frankfurt.de!mickeyl remove hostap-daemon from nonworking. hey folks, please look if not already there is a nonworking version before you add a new one 2005/03/23 02:41:23-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/23 11:38:09+01:00 uni-frankfurt.de!mickeyl opie-collections: add datebook plugins to standard opie image 2005/03/23 11:35:44+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into r2d2.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/03/23 11:33:22+01:00 uni-frankfurt.de!mickeyl add newer gpsd versions and a fixed start/stop script 2005/03/23 11:31:34+01:00 uni-frankfurt.de!mickeyl opie packaging changes in meta-opie and opie-login 2005/03/23 11:06:47+01:00 (none)!br1 added packages "ser" and "mystun" contributed by Sven-Ola Tuecke 2005/03/23 11:02:05+01:00 (none)!br1 Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into null.(none):/data/mtx/closed/build/unstable/openembedded 2005/03/22 17:41:23-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/23 01:26:50+00:00 (none)!cwiiis Merge bk://oe-devel@oe-devel.bkbits.net/openembedded/ into cwiiisdesktop.(none):/home/cwiiis/Dev/oe/openembedded 2005/03/23 01:26:05+00:00 (none)!cwiiis Use the sourceforge source for freetype, as it seems to be the primary download location now. 2005/03/23 01:24:53+00:00 (none)!cwiiis Small gpe-related updates to openzaurus-3.5.3.conf. 2005/03/23 01:23:49+00:00 (none)!cwiiis Correct XLIBS_MIRROR 2005/03/22 07:41:25-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/22 16:31:48+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into r2d2.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/03/22 16:31:38+01:00 uni-frankfurt.de!mickeyl libqte2: set package arch to machine arch since we supply machine specific patches and flags 2005/03/22 15:11:11+00:00 (none)!cwiiis Use ?= instead of = in conf/distro/preferred-gpe-versions.inc, so as not to override user-specified settings 2005/03/22 22:57:38+10:30 (none)!rwhitby Bumped the Openslug kernel PR 2005/03/22 22:53:49+10:30 (none)!rwhitby Merge bk://nslu2-linux@nslu2-linux.bkbits.net/openembedded into home.(none):/home/bitbake/openembedded 2005/03/22 22:53:07+10:30 (none)!rwhitby Changed CONFIG_ATALK from =y to =m in Unslung kernel 2005/03/22 03:41:21-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/22 12:30:28+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into gandalf.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/03/22 12:30:12+01:00 uni-frankfurt.de!mickeyl include tune-xscale in the pxa machines. root file systems can be built with all optimizations since they are machine specific anyway. the unified feed though needs to be built using a tune-strongarm based machine configuration 2005/03/22 12:28:44+01:00 local!hrw added qpf-gentium font to meta-opie 2005/03/22 12:27:20+01:00 local!hrw updated qpf-dejavufonts to 1.8 added all rotations 2005/03/22 12:26:15+01:00 local!hrw added all rotations to qpf-hunkyfonts 2005/03/22 12:09:08+01:00 uni-frankfurt.de!mickeyl add qpf-gentium, a free font with lots of characters. thanks hrw for converting. 2005/03/22 10:39:58+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into r2d2.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/03/22 00:41:26-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/22 07:43:44+00:00 reciva.com!pb change "h2200_linear" to "linear_h2200". Reported by Matt Reimer. 2005/03/21 17:41:26-08:00 bkbits.net!nslu2-linux.adm Merge bk://oe-devel.bkbits.net/openembedded into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/03/22 01:56:50+01:00 dyndns.org!reenoo libglade: update to 2.4.2 which fixes improper use of the toolbar API. make no-xml2.patch apply against 2.4.2. 2005/03/22 00:59:21+01:00 uni-frankfurt.de!mickeyl split tosa machine configuration into generic, 2.4, 2.6 parts 2005/03/22 00:54:55+01:00 uni-frankfurt.de!mickeyl add a version of orinoco-0.13e that compiles against kernel 2.6 and choose that version for the clamshells and the poodle 2005/03/18 16:13:17+01:00 (none)!br1 added madwifi BSD branch build 2005/03/18 16:12:01+01:00 (none)!br1 added hostap-daemon 0.3.7 BKrev: 4241c03fA7V8WMbGM7hnEqx17eXRkw
2005-03-01Merge bk://oe-devel.bkbits.net/openembeddednslu2-linux.adm@bkbits.net1
into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/02/28 19:16:14-06:00 ti.com!kergoth Merge oe-devel@oe-devel.bkbits.net:openembedded into odin.sc.ti.com:/home/kergoth/code/projects/oe/openembedded 2005/03/01 01:15:28+01:00 dyndns.org!reenoo Merge oe-devel@oe-devel.bkbits.net:openembedded into sugarcube.dyndns.org:/home2/oe/bakery/openembedded 2005/02/28 19:15:51-06:00 ti.com!kergoth Another zlib visibility fix. It's fixed now. Really, it is! 2005/03/01 01:15:11+01:00 dyndns.org!reenoo package_ipk.bbclass: strip whitespace in Source: 2005/02/28 18:53:23-06:00 ti.com!kergoth Merge oe-devel@oe-devel.bkbits.net:openembedded into odin.sc.ti.com:/home/kergoth/code/projects/oe/openembedded 2005/02/28 18:53:11-06:00 ti.com!kergoth Fix up the zlib visibility bits, and apply that patch again. BKrev: 4224babdbJA27U4xliOayBB7Yypnaw
2005-02-23Merge bk://oe-devel.bkbits.net/openembeddednslu2-linux.adm@bkbits.net1
into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/02/23 15:31:35-06:00 ti.com!kergoth Apply fix to lame from Michael Kropfberg that ensures that the library packages get emitted. 2005/02/23 14:04:22-06:00 ti.com!kergoth Use the recent glibc snaps by default for the sh3 and sh4 target architectures. 2005/02/23 13:49:33-06:00 ti.com!kergoth Fix the unpleasant target path mangling in do_install in the uclibc builds to happen only when necessary (thereby unborking the uclibc build with default paths). 2005/02/23 13:30:16-06:00 ti.com!kergoth modutils: apply patch from Hermann Lacheiner to fix another missing /. 2005/02/23 12:36:57-06:00 ti.com!kergoth Add sh3 uclibc defconfigs for all the uclibc versions. 2005/02/23 12:27:56-06:00 ti.com!kergoth Merge oe-devel@oe-devel.bkbits.net:openembedded into odin.sc.ti.com:/home/kergoth/code/projects/oe/openembedded 2005/02/23 12:27:44-06:00 ti.com!kergoth module-init-tools: fix another bug caused by that rampant sed'ing. 2005/02/23 18:57:22+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into r2d2.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/02/23 18:57:02+01:00 uni-frankfurt.de!mickeyl introduce IPKGBUILDCMD to enable overwriting the ipkg-build command line arguments. tweak sharprom-compatible.conf to override IPKGBUILDCMD. thanksfully, ipkg-build still supports the outdated format 2005/02/23 10:32:16-06:00 ti.com!kergoth Merge oe-devel@oe-devel.bkbits.net:openembedded into odin.sc.ti.com:/home/kergoth/code/projects/oe/openembedded 2005/02/23 10:31:54-06:00 ti.com!kergoth Bump PR in the packages that were broken by the hokey sed from yesterday. 2005/02/23 17:14:56+01:00 uni-frankfurt.de!mickeyl misc opie files: use palmtopdir variable instead of hardcoding /opt/QtPalmtop/ 2005/02/23 17:05:25+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into gandalf.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/02/23 09:56:05-06:00 ti.com!kergoth Fixes per the overenthusiastic sed / removal I did yesterday. Thanks to Hermann Lacheiner and Holger Schurig for spotting a couple of them, this should fix the others. 2005/02/23 16:48:08+01:00 uni-frankfurt.de!mickeyl make the prism3-support package work BKrev: 421cfb9f-K6bfhnkhAVPJV_fqpHn7Q
2005-02-23Merge bk://oe-devel.bkbits.net/openembeddednslu2-linux.adm@bkbits.net2
into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/02/23 12:40:33+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into gandalf.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/02/23 12:36:37+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into gandalf.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/02/23 11:34:13+01:00 mn-solutions.de!schurig Merge http://oe-devel@openembedded.bkbits.net/openembedded into mnz66.mn-solutions.de:/usr/src/oe/p 2005/02/23 11:33:31+01:00 mn-solutions.de!schurig fix installation stage 2005/02/23 09:27:44+00:00 (none)!xora New upstream version of kismet, fixes for compilation problems, and change of maintainer with Brunos permission 2005/02/23 01:11:25+01:00 uni-frankfurt.de!mickeyl add a sharprom-compatible distro configuration. relies on an external 2.95.3 toolchain (for now... until someone adds it to OE) and needs further work. It's a start for someone interested though. 2005/02/23 01:09:23+01:00 uni-frankfurt.de!mickeyl bump cvsdate on oz-3.5.3 2005/02/22 17:37:44-06:00 ti.com!kergoth Fix the quilt PATCHCMD to stop rampantly chmod'ing, which made the CVS directories not executable, thereby screwing up the ability to rm -rf tmp. Thanks to holger freyther for pointing it out. BKrev: 421c7b62hBWfitoVhb3IO3ZT5nS71A
2005-02-22Merge bk://oe-devel.bkbits.net/openembeddednslu2-linux.adm@bkbits.net2
into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/02/21 17:35:27-06:00 ti.com!kergoth Kill the ipkg paths patch, since its busted. 2005/02/21 17:33:13-06:00 ti.com!kergoth Fix sbindir in native.bbclass and cross.bbclass. Thanks to Jordan Crouse for reporting. 2005/02/21 17:13:19-06:00 ti.com!kergoth Add the paths patch to ipkg which fixes it to no longer hardcode the '/usr/lib/ipkg' path, which I forgot to check in from the previous commit. 2005/02/21 17:09:46-06:00 ti.com!kergoth Merge oe-devel@oe-devel.bkbits.net:openembedded into odin.sc.ti.com:/home/kergoth/code/user/oe/openembedded 2005/02/21 17:09:03-06:00 ti.com!kergoth Run a sed script against our packages to fix some hardcoded target path references. As always when I do things like this, if packages you maintain were touched by this, please do a sanity check to ensure the sed script didn't run wild. 2005/02/21 15:49:47-06:00 ti.com!kergoth Use a HOTPLUG variable to manage which hotplug you prefer, to ensure that hotplug is still included in task-bootstrap even if you dont set DISTRO. BKrev: 421b2b63X5eoMcSrC7pVcptXK-iFKg
2005-01-05Merge bk://oe-devel.bkbits.net/openembeddednslu2-linux.adm@bkbits.net2
into bkbits.net:/repos/n/nslu2-linux/openembedded 2005/01/05 19:36:45+00:00 nexus.co.uk!pb Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into stealth.nexus.co.uk:/home/pb/oe/oe 2005/01/05 19:36:34+00:00 nexus.co.uk!pb update gdb to 6.3 2005/01/05 20:09:24+01:00 uni-frankfurt.de!mickeyl Merge bk://oe-devel@oe-devel.bkbits.net/openembedded into r2d2.tm.informatik.uni-frankfurt.de:/local/pkg/oe/packages 2005/01/05 20:08:55+01:00 uni-frankfurt.de!mickeyl switch dropbear 0.44 back to using /dev/urandom. It's less secure, but faster 2005/01/05 10:54:32-08:00 (none)!ggilbert netbase_4.19.bb: netbase: Bump pr for interfaces file change interfaces: netbase: Addess essid=any to interfaces file. Wireless Access points should now auto associate when using hostap BKrev: 41dc4298tJ4DowLLlgompjeJuNGu0Q
2004-12-09Merge oe-devel@oe-devel.bkbits.net:openembeddedChris Larson10
into hyperion.kergoth.com:/home/kergoth/code/openembedded 2004/12/09 03:39:39-06:00 kergoth.com!kergoth Break people's builds again.. this time moving the packages into a packages/ subdir to clean things up a bit. BKrev: 41b81f3dvlp3rU7_8MUXLcI8LDdDoA