diff options
author | Khem Raj <raj.khem@gmail.com> | 2010-05-30 00:10:47 -0700 |
---|---|---|
committer | Khem Raj <raj.khem@gmail.com> | 2010-05-30 00:12:40 -0700 |
commit | ed878a05bcbc9d1695e70123f79eb21f6610d565 (patch) | |
tree | 302a4af2babbc49f30c60c7908a5bfcd0f74fcec | |
parent | b2992054c508e4cb7d01b93810308fa797f4ef20 (diff) |
linux_2.6.34.bb: Fix the boot issue due to naked functions when compiled with gcc 4.5
Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r-- | recipes/linux/linux-2.6.34/use-noclone-attribute-for-naked.patch | 139 | ||||
-rw-r--r-- | recipes/linux/linux_2.6.34.bb | 3 |
2 files changed, 142 insertions, 0 deletions
diff --git a/recipes/linux/linux-2.6.34/use-noclone-attribute-for-naked.patch b/recipes/linux/linux-2.6.34/use-noclone-attribute-for-naked.patch new file mode 100644 index 0000000000..cf09e244b4 --- /dev/null +++ b/recipes/linux/linux-2.6.34/use-noclone-attribute-for-naked.patch @@ -0,0 +1,139 @@ +This patch add noinline and noclone attributes to naked functions. +GCC 4.5 has new optimization -fipa-ira which is enabled at -Os and -O2 +this option will clone the functions and that can change the standard +calling convention but the naked functions expect that and use +arguments as in standard calling convention. Therefore the naked +functions should not be marked non inline and noclone. + +Signed-off-by: Khem Raj <raj.khem@gmail.com> + +Index: linux-2.6.34/include/linux/compiler-gcc4.h +=================================================================== +--- linux-2.6.34.orig/include/linux/compiler-gcc4.h 2010-05-29 17:18:55.338127623 -0700 ++++ linux-2.6.34/include/linux/compiler-gcc4.h 2010-05-29 17:32:33.910657021 -0700 +@@ -48,6 +48,10 @@ + * unreleased. Really, we need to have autoconf for the kernel. + */ + #define unreachable() __builtin_unreachable() ++ ++/* Mark a function definition as prohibited from being cloned. */ ++#define __noclone __attribute__((__noclone__)) ++ + #endif + + #endif +Index: linux-2.6.34/include/linux/compiler-gcc.h +=================================================================== +--- linux-2.6.34.orig/include/linux/compiler-gcc.h 2010-05-29 17:28:28.238113095 -0700 ++++ linux-2.6.34/include/linux/compiler-gcc.h 2010-05-29 17:31:58.938153321 -0700 +@@ -58,8 +58,12 @@ + * naked functions because then mcount is called without stack and frame pointer + * being set up and there is no chance to restore the lr register to the value + * before mcount was called. ++ * ++ * The asm() bodies of naked functions often depend on standard calling conventions, ++ * therefore they must be noinline and noclone. GCC 4.[56] currently fail to enforce ++ * this, so we must do so ourselves. See GCC PR44290. + */ +-#define __naked __attribute__((naked)) notrace ++#define __naked __attribute__((naked)) noinline __noclone notrace + + #define __noreturn __attribute__((noreturn)) + +@@ -85,3 +89,8 @@ + #define _gcc_header(x) __gcc_header(linux/compiler-gcc##x.h) + #define gcc_header(x) _gcc_header(x) + #include gcc_header(__GNUC__) ++ ++#if !defined(__noclone) ++#define __noclone /* not needed */ ++#endif ++ +Index: linux-2.6.34/arch/arm/mm/copypage-v4wb.c +=================================================================== +--- linux-2.6.34.orig/arch/arm/mm/copypage-v4wb.c 2010-05-29 23:01:46.580600195 -0700 ++++ linux-2.6.34/arch/arm/mm/copypage-v4wb.c 2010-05-29 23:46:10.610629920 -0700 +@@ -27,7 +27,7 @@ v4wb_copy_user_page(void *kto, const voi + { + asm("\ + stmfd sp!, {r4, lr} @ 2\n\ +- mov r2, %0 @ 1\n\ ++ mov r2, %2 @ 1\n\ + ldmia r1!, {r3, r4, ip, lr} @ 4\n\ + 1: mcr p15, 0, r0, c7, c6, 1 @ 1 invalidate D line\n\ + stmia r0!, {r3, r4, ip, lr} @ 4\n\ +@@ -44,7 +44,7 @@ v4wb_copy_user_page(void *kto, const voi + mcr p15, 0, r1, c7, c10, 4 @ 1 drain WB\n\ + ldmfd sp!, {r4, pc} @ 3" + : +- : "I" (PAGE_SIZE / 64)); ++ : "r" (kto), "r" (kfrom), "I" (PAGE_SIZE / 64)); + } + + void v4wb_copy_user_highpage(struct page *to, struct page *from, +Index: linux-2.6.34/arch/arm/mm/copypage-v4wt.c +=================================================================== +--- linux-2.6.34.orig/arch/arm/mm/copypage-v4wt.c 2010-05-29 23:48:51.908131421 -0700 ++++ linux-2.6.34/arch/arm/mm/copypage-v4wt.c 2010-05-29 23:53:15.410657789 -0700 +@@ -25,7 +25,7 @@ v4wt_copy_user_page(void *kto, const voi + { + asm("\ + stmfd sp!, {r4, lr} @ 2\n\ +- mov r2, %0 @ 1\n\ ++ mov r2, %2 @ 1\n\ + ldmia r1!, {r3, r4, ip, lr} @ 4\n\ + 1: stmia r0!, {r3, r4, ip, lr} @ 4\n\ + ldmia r1!, {r3, r4, ip, lr} @ 4+1\n\ +@@ -40,7 +40,7 @@ v4wt_copy_user_page(void *kto, const voi + mcr p15, 0, r2, c7, c7, 0 @ flush ID cache\n\ + ldmfd sp!, {r4, pc} @ 3" + : +- : "I" (PAGE_SIZE / 64)); ++ : "r" (kto), "r" (kfrom), "I" (PAGE_SIZE / 64)); + } + + void v4wt_copy_user_highpage(struct page *to, struct page *from, +Index: linux-2.6.34/arch/arm/mm/copypage-feroceon.c +=================================================================== +--- linux-2.6.34.orig/arch/arm/mm/copypage-feroceon.c 2010-05-29 23:50:26.518121374 -0700 ++++ linux-2.6.34/arch/arm/mm/copypage-feroceon.c 2010-05-29 23:50:53.238196555 -0700 +@@ -18,7 +18,7 @@ feroceon_copy_user_page(void *kto, const + { + asm("\ + stmfd sp!, {r4-r9, lr} \n\ +- mov ip, %0 \n\ ++ mov ip, %2 \n\ + 1: mov lr, r1 \n\ + ldmia r1!, {r2 - r9} \n\ + pld [lr, #32] \n\ +@@ -64,7 +64,7 @@ feroceon_copy_user_page(void *kto, const + mcr p15, 0, ip, c7, c10, 4 @ drain WB\n\ + ldmfd sp!, {r4-r9, pc}" + : +- : "I" (PAGE_SIZE)); ++ : "r" (kto), "r" (kfrom), "I" (PAGE_SIZE)); + } + + void feroceon_copy_user_highpage(struct page *to, struct page *from, +Index: linux-2.6.34/arch/arm/mm/copypage-xsc3.c +=================================================================== +--- linux-2.6.34.orig/arch/arm/mm/copypage-xsc3.c 2010-05-29 23:52:00.010626567 -0700 ++++ linux-2.6.34/arch/arm/mm/copypage-xsc3.c 2010-05-29 23:52:30.048147465 -0700 +@@ -34,7 +34,7 @@ xsc3_mc_copy_user_page(void *kto, const + { + asm("\ + stmfd sp!, {r4, r5, lr} \n\ +- mov lr, %0 \n\ ++ mov lr, %2 \n\ + \n\ + pld [r1, #0] \n\ + pld [r1, #32] \n\ +@@ -67,7 +67,7 @@ xsc3_mc_copy_user_page(void *kto, const + \n\ + ldmfd sp!, {r4, r5, pc}" + : +- : "I" (PAGE_SIZE / 64 - 1)); ++ : "r" (kto), "r" (kfrom), "I" (PAGE_SIZE / 64 - 1)); + } + + void xsc3_mc_copy_user_highpage(struct page *to, struct page *from, diff --git a/recipes/linux/linux_2.6.34.bb b/recipes/linux/linux_2.6.34.bb index 9dd7b35d42..de76b4fbb1 100644 --- a/recipes/linux/linux_2.6.34.bb +++ b/recipes/linux/linux_2.6.34.bb @@ -1,5 +1,7 @@ require linux.inc +PR = "r1" + # Mark archs/machines that this kernel supports DEFAULT_PREFERENCE = "-1" DEFAULT_PREFERENCE_qemuarm = "1" @@ -10,6 +12,7 @@ DEFAULT_PREFERENCE_qemux86 = "1" SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/${P}.tar.bz2;name=kernel \ file://ARM-Add-support-for-LZMA-compressed-kernel-images.patch;status=pending \ + file://patches/use-noclone-attribute-for-naked.patch;status=pending \ file://defconfig" SRC_URI[kernel.md5sum] = "10eebcb0178fb4540e2165bfd7efc7ad" |