summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHolger Freyther <zecke@selfish.org>2007-02-20 13:29:04 +0000
committerHolger Freyther <zecke@selfish.org>2007-02-20 13:29:04 +0000
commit8c749cd33e85444dadb6e595f477ac384c340b60 (patch)
tree7f0d494064d668ee67c1a564d754d74718a5c81b
parent7fe797b41116ef91d5ec66ba90bb5e4ca1874ac9 (diff)
classes/insane.bbclass: No use to make it bb.fatal if we return False...
The idea of insane.bbclass is to report all issues found at once. This is why the checks return True if no error was found and False if at least one was found. At the end of all check runs we will see if at least one check failed and call bb.fatal
-rw-r--r--classes/insane.bbclass14
1 files changed, 7 insertions, 7 deletions
diff --git a/classes/insane.bbclass b/classes/insane.bbclass
index 6e8c90a706..4ea0cd60f4 100644
--- a/classes/insane.bbclass
+++ b/classes/insane.bbclass
@@ -257,14 +257,14 @@ def package_qa_check_arch(path,name,d):
sane = True
if not machine == elf.machine():
- bb.fatal("Architecture did not match (%d to %d) on %s" %(machine, elf.machine(), package_qa_clean_path(path,d)))
- sane = package_qa_make_fatal_error( 4, name, path, d )
- elif not osabi == elf.osAbi():
- bb.error("OSABI did not match (%d to %d) on %s" % (osabi, elf.osAbi(), package_qa_clean_path(path,d)))
- sane = package_qa_make_fatal_error( 4, name, path, d )
- elif not abiversion == elf.abiVersion():
- bb.error("ABI version did not match (%d to %d) on %s" % (abiversion, elf.abiVersion(), package_qa_clean_path(path,d)))
+ bb.error("Architecture did not match (%d to %d) on %s" %(machine, elf.machine(), package_qa_clean_path(path,d)))
sane = package_qa_make_fatal_error( 4, name, path, d )
+# elif not osabi == elf.osAbi():
+# bb.error("OSABI did not match (%d to %d) on %s" % (osabi, elf.osAbi(), package_qa_clean_path(path,d)))
+# sane = package_qa_make_fatal_error( 4, name, path, d )
+# elif not abiversion == elf.abiVersion():
+# bb.error("ABI version did not match (%d to %d) on %s" % (abiversion, elf.abiVersion(), package_qa_clean_path(path,d)))
+# sane = package_qa_make_fatal_error( 4, name, path, d )
elif not littleendian == elf.isLittleEndian():
bb.error("Endiannes did not match (%d to %d) on %s" % (littleendian, elf.isLittleEndian(), package_qa_clean_path(path,d)))
sane = package_qa_make_fatal_error( 4, name, path, d )