From 1b8e4abd2d9c0901d38d89d0f944fe1ffd019379 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Fri, 13 Sep 2013 13:35:31 +0100 Subject: bitbake.conf/package: Collapse PKGDATA_DIR into a single machine specific directory Currently we have a hierarchy of pkgdata directories and the code has to put together a search path and look through each in turn until it finds the data it needs. This has lead to a number of hardcoded paths and file globing which is unpredictable and undesirable. Worse, certain tricks that should be easy like a GL specific package architecture become problematic with the curretn search paths. With the modern sstate code, we can do better and construct a single pkgdata directory for each machine in just the same way as we do for the sysroot. This is already tried and well tested. With such a single directory, all the code that iterated through multiple pkgdata directories and simply be removed and give a significant simplification of the code. Even existing build directories adapt to the change well since the package contents doesn't change, just the location they're installed to and the stamp for them. The only complication is the we need a different shlibs directory for each multilib. These are only used by package.bbclass and the simple fix is to add MLPREFIX to the shlib directory name. This means the multilib packages will repackage and the sstate checksum will change but an existing build directory will adapt to the changes safely. It is close to release however I believe the benefits this patch give us are worth consideration for inclusion and give us more options for dealing with problems like the GL one. It also sets the ground work well for shlibs improvements in 1.6. Signed-off-by: Richard Purdie --- scripts/oe-pkgdata-util | 36 ++++++++++-------------------------- 1 file changed, 10 insertions(+), 26 deletions(-) (limited to 'scripts/oe-pkgdata-util') diff --git a/scripts/oe-pkgdata-util b/scripts/oe-pkgdata-util index c63f87d7e6..dcdfe25dfd 100755 --- a/scripts/oe-pkgdata-util +++ b/scripts/oe-pkgdata-util @@ -41,17 +41,13 @@ def usage(): def glob(args): - if len(args) < 4: + if len(args) < 3: usage() sys.exit(1) pkgdata_dir = args[0] - target_suffix = args[1] - pkglist_file = args[2] - globs = args[3].split() - - if target_suffix.startswith("-"): - target_suffix = target_suffix[1:] + pkglist_file = args[1] + globs = args[2].split() skipregex = re.compile("-locale-|^locale-base-|-dev$|-doc$|-dbg$|-staticdev$|^kernel-module-") @@ -63,7 +59,6 @@ def glob(args): continue pkg = fields[0] arch = fields[1] - multimach_target_sys = "%s-%s" % (arch, target_suffix) # Skip packages for which there is no point applying globs if skipregex.search(pkg): @@ -86,9 +81,9 @@ def glob(args): # Define some functions def revpkgdata(pkgn): - return os.path.join(pkgdata_dir, multimach_target_sys, "runtime-reverse", pkgn) + return os.path.join(pkgdata_dir, "runtime-reverse", pkgn) def fwdpkgdata(pkgn): - return os.path.join(pkgdata_dir, multimach_target_sys, "runtime", pkgn) + return os.path.join(pkgdata_dir, "runtime", pkgn) def readpn(pkgdata_file): pn = "" with open(pkgdata_file, 'r') as f: @@ -156,17 +151,13 @@ def glob(args): print("\n".join(mappedpkgs)) def read_value(args): - if len(args) < 4: + if len(args) < 3: usage() sys.exit(1) pkgdata_dir = args[0] - target_suffix = args[1] - var = args[2] - packages = args[3].split() - - if target_suffix.startswith("-"): - target_suffix = target_suffix[1:] + var = args[1] + packages = args[2].split() def readvar(pkgdata_file, var): val = "" @@ -177,23 +168,16 @@ def read_value(args): return val if debug: - print "read-value('%s', '%s', '%s' '%s'" % (pkgdata_dir, target_suffix, var, packages) + print "read-value('%s', '%s' '%s'" % (pkgdata_dir, var, packages) for package in packages: pkg_split = package.split('_') pkg_name = pkg_split[0] pkg_arch = '_'.join(pkg_split[1:]) if debug: print "package: name: '%s', arch: '%s'" % (pkg_name, pkg_arch) - multimach_target_sys = "%s-%s" % (pkg_arch, target_suffix) - revlink = os.path.join(pkgdata_dir, multimach_target_sys, "runtime-reverse", pkg_name) + revlink = os.path.join(pkgdata_dir, "runtime-reverse", pkg_name) if debug: print(revlink) - if not os.path.exists(revlink): - # [YOCTO #4227] try to drop -gnueabi from TARGET_OS - multimach_target_sys = '-'.join(multimach_target_sys.split('-')[:-1]) - revlink = os.path.join(pkgdata_dir, multimach_target_sys, "runtime-reverse", pkg_name) - if debug: - print(revlink) if os.path.exists(revlink): mappedpkg = os.path.basename(os.readlink(revlink)) qvar = var -- cgit v1.2.3