From d5a1999a7dc216b8182440cf9e8489ec79a6606e Mon Sep 17 00:00:00 2001 From: Chong Lu Date: Fri, 1 Aug 2014 17:03:38 +0800 Subject: oelint.bbclass: Check for ${PN} or ${P} usage Check for ${PN} or ${P} usage in SRC_URI or S. We should use ${BPN} or ${BP} instead to avoid breaking multilib. [YOCTO #5427] Signed-off-by: Chong Lu Signed-off-by: Saul Wold Signed-off-by: Richard Purdie --- meta/classes/oelint.bbclass | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'meta') diff --git a/meta/classes/oelint.bbclass b/meta/classes/oelint.bbclass index 07a7ed9d7c..d00f468d9a 100644 --- a/meta/classes/oelint.bbclass +++ b/meta/classes/oelint.bbclass @@ -64,4 +64,22 @@ python do_lint() { bb.warn("%s: %s doesn't have Signed-off-by" % (pkgname, item)) if findKey(path, "Upstream-Status"): bb.warn("%s: %s doesn't have Upstream-Status" % (pkgname, item)) + + + ############################## + # Check for ${PN} or ${P} usage in SRC_URI or S + # Should use ${BPN} or ${BP} instead to avoid breaking multilib + # + for s in srcuri: + if not s.startswith("file://"): + if not s.find("{PN}") == -1: + bb.warn("%s: should use BPN instead of PN in SRC_URI" % pkgname) + if not s.find("{P}") == -1: + bb.warn("%s: should use BP instead of P in SRC_URI" % pkgname) + + srcpath = d.getVar("S") + if not srcpath.find("{PN}") == -1: + bb.warn("%s: should use BPN instead of PN in S" % pkgname) + if not srcpath.find("{P}") == -1: + bb.warn("%s: should use BP instead of P in S" % pkgname) } -- cgit v1.2.3