From a2b6be10daca733ba4e557bd2d831c60589e9ffd Mon Sep 17 00:00:00 2001 From: Chong Lu Date: Fri, 1 Aug 2014 17:03:37 +0800 Subject: oelint.bbclass: add patch checking Check that all patches have Signed-off-by and Upstream-Status. [YOCTO #5427] Signed-off-by: Chong Lu Signed-off-by: Saul Wold Signed-off-by: Richard Purdie --- meta/classes/oelint.bbclass | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/meta/classes/oelint.bbclass b/meta/classes/oelint.bbclass index d14e3783f3..07a7ed9d7c 100644 --- a/meta/classes/oelint.bbclass +++ b/meta/classes/oelint.bbclass @@ -29,4 +29,39 @@ python do_lint() { bb.warn("%s: SECTION is not set" % pkgname) elif not section.islower(): bb.warn("%s: SECTION should only use lower case" % pkgname) + + + ############################## + # Check that all patches have Signed-off-by and Upstream-Status + # + srcuri = d.getVar("SRC_URI").split() + fpaths = (d.getVar('FILESPATH', True) or '').split(':') + + def findPatch(patchname): + for dir in fpaths: + patchpath = dir + patchname + if os.path.exists(patchpath): + return patchpath + + def findKey(path, key): + ret = True + f = file('%s' % path, mode = 'r') + line = f.readline() + while line: + if line.find(key) != -1: + ret = False + line = f.readline() + f.close() + return ret + + length = len("file://") + for item in srcuri: + if item.startswith("file://"): + item = item[length:] + if item.endswith(".patch") or item.endswith(".diff"): + path = findPatch(item) + if findKey(path, "Signed-off-by"): + bb.warn("%s: %s doesn't have Signed-off-by" % (pkgname, item)) + if findKey(path, "Upstream-Status"): + bb.warn("%s: %s doesn't have Upstream-Status" % (pkgname, item)) } -- cgit v1.2.3