summaryrefslogtreecommitdiff
path: root/meta/recipes-devtools
AgeCommit message (Collapse)AuthorFiles
2017-03-01generate-manifest-2.7.py: add logic to generate native manifestMing Liu2
python-native supposes to RPROVIDE all native packages as added in generate-manifest-2.7.py, but it does not so far, this leads a problem that sometimes bitbake cant find a runtime provider for a python-*-native when a new runtime dependency on it being required, this usualy happens after a new native python-* recipe is created or the old native python-* recipes are upgraded. To give a example, the following commit is trying to address such a issue: commit 4583cd1bb15306e8f0ab7bcd80732e6f35aa4533: [ python-native: Make python-native also RPROVIDE python-unittest-native ] To avoid manually extending RPROVIDE every time when a new runtime dependency is introduced, an argument '-n/--native' is added to the manifest generator, allowing it create a native python manifest, with a RPROVIDE line only, the RPROVIDE should contain all the sub-packages. The generated python-native-2.7-manifest.inc is also added which is included by python-native recipe. Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01perl-native: Remove usage of -fstack-protector=strongAníbal Limón2
Some distributions (like opensuse421) supported by the project comes with older gcc releases, -fstack-protector=strong is supported by GCC>=4.9. This causes a build failure when install perl-native from a sstate that comes from a machine supporting -fstack-protector=strong [1]. So disable usage of this flag in perl-native builds, this patch could be removed when all supported distros comes with GCC>=4.9. [YOCTO #10338] [1] http://errors.yoctoproject.org/Errors/Details/109589/ Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01python3-pip: RDEPEND on python3-html.Ismo Puustinen1
Without this pip3 fails with "ImportError: No module named 'html'" Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01btrfs-tools: update to 4.9.1Alexander Kanavin1
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01kconfig-frontends: fetch source from gitAlexander Kanavin1
This is where development happens; tarballs are no longer produced. Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01ruby: fix upstream version checkAlexander Kanavin1
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01python-pexpect: BBCLASSEXTEND to nativeMing Liu1
Some developers might need it. Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01python-ptyprocess: BBCLASSEXTEND to nativeMing Liu1
Some developers might need it. Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01rpm: support customizing gpg command lineMarkus Lehtonen2
Add a new %_gpg_sign_cmd_extra_args macro that allows customizing the gpg options used when signing rpm packages. This is needed to be able to sign packages with gpg 2.1 which requires "--pinentry-mode loopback" to allow non-interactive signing. [YOCTO #11054] Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01qemu: fix build with glibc-2.25Martin Jansa2
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01e2fsprogs: Fix build with glibc-2.25Martin Jansa2
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01syslinux: fix build with glibc-2.25Martin Jansa2
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01file: 5.29 -> 5.30Robert Yang1
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01guile: 2.0.13 -> 2.0.14Robert Yang1
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01strace: 4.15 -> 4.16Robert Yang4
* The license cheksum is changed becuase a new line is added: Copyright (C) 2001-2017 The strace developers. * Remove use-asm-sgidefs.h.patch, it doesn't check sgidefs.h any more, it was use for building on mips, I checked it built well. * Update Makefile-ptest.patch and disable-git-version-gen.patch. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01dpkg: Upgrade to 1.18.10Aníbal Limón4
Add a patch to don't use --clamp-time when call tar because isn't supported in tar hosts versions. See 0007-dpkg-deb-build.c-Remove-usage-of-clamp-mtime-in-tar.patch patch for details. Rebased patch: - 0003-Our-pre-postinsts-expect-D-to-be-set-when-running-in.patch Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Edwin Plauchu <edwin.plauchu.camacho@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01perl: Upgrade to 5.24.1Aníbal Limón7
Upgrade config.sh to match new version. Removed CVE patches already in upstream: - perl-fix-CVE-2016-1238.patch - perl-fix-CVE-2016-6185.patch Update customized.dat patch to match new hashes. Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01Revert "flex: upgrade to 2.6.2"Trevor Woerner5
This reverts commit 3632abd01abb8dfff230e18f828af705da488f97. Multiple people have expressed issues with flex-2.6.2; personally I had problems compiling libsepol from meta-selinux (for libselinux). I tried upgrading to flex-2.6.3, but that caused binutils-cross_2.27 to fail. The simplest for now is to downgrade to flex-2.6.0. Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01python: Upgrade both python and python-native to 2.7.13Alejandro Hernandez7
Rebased: - python-native/multilib.patch - python/multilib.patch - python/01-use-proper-tools-for-cross-build.patch Upstream: - CVE-2016-1000110 Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-03-01recipes: Make use of the new bb.utils.filter() functionPeter Kjellerstedt9
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23qemu: support virtual TPMPatrick Ohly5
This enables the use of swtpm (from meta-security) as a virtual TPM in qemu. These patches extend the existing support in qemu for TPM passthrough so that a swtpm daemon can be accessed via CUSE (character device in user space). To use this: - add the meta-security layer including the swtpm enhancements for qemu - bitbake swtpm-native - create a TPM instance and initialize it with: $ mkdir -p my-machine/myvtpm0 $ tmp-glibc/sysroots/x86_64-linux/usr/bin/swtpm_setup_oe.sh --tpm-state my-machine/myvtpm0 --createek Starting vTPM manufacturing as root:root @ Fri 20 Jan 2017 08:56:18 AM CET TPM is listening on TCP port 52167. Successfully created EK. Successfully authored TPM state. Ending vTPM manufacturing @ Fri 20 Jan 2017 08:56:19 AM CET - run swtpm *before each runqemu invocation* (it shuts down after use) and do it as root (required to set up the /dev/vtpm0 CUSE device): $ sudo sh -c 'PATH=`pwd`/tmp-glibc/sysroots/x86_64-linux/usr/bin/:`pwd`/tmp-glibc/sysroots/x86_64-linux/usr/sbin/:$PATH; export TPM_PATH=`pwd`/my-machine/myvtpm0; swtpm_cuse -n vtpm0' && sudo chmod a+rw /dev/vtpm0 - run qemu: $ runqemu 'qemuparams=-tpmdev cuse-tpm,id=tpm0,path=/dev/vtpm0 -device tpm-tis,tpmdev=tpm0' ... The guest kernel has to have TPM support enabled, which can be done with: KERNEL_FEATURES_append = " features/tpm/tpm.scc" Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
2017-02-23ccache: Switch to downloading xz tarballMike Crowe2
ccache tarballs have been available in tar.xz format since at least v3.1.1. The v3.3.4 tarball is about 30% smaller so we might as well switch to it. Signed-off-by: Mike Crowe <mac@mcrowe.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-23ccache: Upgrade to v3.3.4Mike Crowe2
Only the copyright year has been updated in LICENSE.txt. The license text itself has not changed. This version fixes a bug with dependency output that could cause problems when compiling kernels for different MACHINEs using a shared ccache. See https://github.com/ccache/ccache/issues/158 Signed-off-by: Mike Crowe <mac@mcrowe.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-23unifdef: add UPSTREAM_CHECK_REGEX to filter out development snapshotsRoss Burton1
Upstream is releasing development snapshots of the form unifdef-2.11.23.1cca442.tar.gz so filter out versions which end is something that looks like a git SHA. Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-23btrfs-tools: only target requires udevRobert Yang1
The native doesn't have to depend on udev, fixed: $ bitbake btrfs-tools-native ERROR: Nothing PROVIDES 'udev-native' (but virtual:native:btrfs-tools_4.8.5.bb DEPENDS on or otherwise requires it). Close matches: [snip] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-23btrfs-tools: don't run autogen.shRoss Burton1
Instead of running autogen.sh (which runs autoconf et al) before running autoreconf (which runs autoreconf et al...) just do the one task that we need from autogen.sh: copying install-sh from automake's libdir. Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-23qemu-native: Point python to python2 on build hostKhem Raj1
On buildhosts where default python has switched to using python3 qemu-native fails configure like this | ERROR: Cannot use 'python', Python 2.6 or later is required. | Note that Python 3 or later is not yet supported. | Use --python=/path/to/python to specify a supported Python. | we still expect build host to have python2 pre-installed and is always available. (From OE-Core rev: 2cac9544752775262fa87517ed49fcac2fb3a574) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23swig: upgrade to 3.0.12Edwin Plauchu1
Minimal update for swig (From OE-Core rev: 17955d9b8f1368b875615d24ae0d4c2aa099afd9) Signed-off-by: Edwin Plauchu <edwin.plauchu.camacho@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23gcc: Fix CVE-2016-6131 in libibertyYuanjie Huang4
[NVD] -- https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2016-6131 The demangler in GNU Libiberty allows remote attackers to cause a denial of service (infinite loop, stack overflow, and crash) via a cycle in the references of remembered mangled types. [BZ #71696] -- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71696 2016-08-04 Marcel Böhme <boehme.marcel@gmail.com> PR c++/71696 * cplus-dem.c: Prevent infinite recursion when there is a cycle in the referencing of remembered mangled types. (work_stuff): New stack to keep track of the remembered mangled types that are currently being processed. (push_processed_type): New method to push currently processed remembered type onto the stack. (pop_processed_type): New method to pop currently processed remembered type from the stack. (work_stuff_copy_to_from): Copy values of new variables. (delete_non_B_K_work_stuff): Free stack memory. (demangle_args): Push/Pop currently processed remembered type. (do_type): Do not demangle a cyclic reference and push/pop referenced remembered type. cherry-picked from commit of git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@239143 138bc75d-0d04-0410-961f-82ee72b054a4 (From OE-Core rev: 3c288b181a4cfecc80b48994f4dd2df285e4d1d0) Signed-off-by: Yuanjie Huang <yuanjie.huang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23tcl: fix sed in do_install()Robert Yang1
The command: sed -i "s+${WORKDIR}+${STAGING_INCDIR}+g" tclConfig.sh was used for replacing "${WORKDIR}", but it also replaced "-L${WORKDIR}", but binconfig.bbclass would replace "-L${WORKDIR}", too, which caused incorrect result, use "'${WORKDIR}" to fix the problem. (From OE-Core rev: 2edfcbf0291c0d39be4a37348696329eba8a41f8) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23tcl: extend to nativesdkRobert Yang1
Fixed: $ bitbake nativesdk-expect ERROR: Nothing PROVIDES 'nativesdk-tcl' (but virtual:nativesdk:expect_5.45.bb DEPENDS on or otherwise requires it). Close matches: [snip] (From OE-Core rev: 5c950c509edcc50d39a1f426579b354d97178ff2) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23python-native: PROVIDES python-io-nativeRobert Yang1
python-six-native depends on it. (From OE-Core rev: 475585ed84bf8dac339f97f811582bf782972930) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23docbook-xml: correct typo "do_configre"Robert P. J. Day1
(From OE-Core rev: 56cdb1358f4560fce4d8fcd04d754051a4ac6250) Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23cmake: Update to 3.7.2.Philip Balister3
Tested by building gnuradio stack. (From OE-Core rev: d3e5a6d38870ecede87812cb81c0b5630bd3b3ff) Signed-off-by: Philip Balister <philip@balister.org> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23gcc-6: Add fix for missing no-PIE flagsStephen Arnold2
Fixes build on hardened PAX host with gcc-5 (linker error on relocs). Completes no-PIE config by adding to ALL_* flags variables. Borrowed from Gentoo gcc patches, tested on 2 hardened amd64 hosts. Upstream-Status: Inappropriate [configuration] Commited by: Gentoo Toolchain Project <toolchain@gentoo.org> (From OE-Core rev: c178791cd78d5a9ebc4d7b7790e647a9bafe9cf2) Signed-off-by: Stephen Arnold <stephen.arnold42@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23gdb: Upgrade to 7.12.1Khem Raj5
Drop already applied patches (From OE-Core rev: 233641857bdc4071e5cb9a25206def880eb2754d) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23depmodwrapper-cross/qemuwrapper-cross: Drop unneeded binutils dependencyRichard Purdie1
By default these pull in binutils-cross since they're a cross tool and pull in any native tool requirements. In reality they don't need such tools at build time or runtime since they're scripts. Therefore clear the dependency and save on some processing time. (From OE-Core rev: 63796765122e2eee2b78930797d571acb5c244d1) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-23gcc-cross: Avoid races with gcc_stash_builddirRichard Purdie1
Its sad we need to do this but do_install and do_populate_sysroot appear to change the files in ${B} and this breaks if something works in parallel like gcc_stash_builddir. We've seen a few too many race errors on the autobuilder which appear to be from this so make things run in sequence deterministically for now. An example failure was this from do_populate_sysroot whilst stash_builddir was running in parallel: ERROR: gcc-cross-initial-arm-6.3.0-r0 do_populate_sysroot: split_and_strip_files: 'file /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm-lsb/build/build/tmp/work/x86_64-linux/ gcc-cross-initial-arm/6.3.0-r0/sysroot-destdir/home/pokybuild/yocto-autobuilder/yocto-worker/ nightly-arm-lsb/build/build/tmp/work/x86_64-linux/gcc-cross-initial-arm/6.3.0-r0/recipe-sysroot-native/ usr/bin/arm-poky-linux-gnueabi.gcc-cross-initial-arm/arm-poky-linux-gnueabi-gcov' failed Exception: subprocess.CalledProcessError: Command '('patchelf-uninative', '--set-interpreter', '/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm-lsb/build/build/tmp/sysroots-uninative/ x86_64-linux/lib/ld-linux-x86-64.so.2', '/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm-lsb/ build/build/tmp/work/x86_64-linux/gcc-cross-initial-arm/6.3.0-r0/sstate-build-populate_sysroot/ recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi.gcc-cross-initial-arm/arm-poky-linux-gnueabi-gcov')' returned non-zero exit status 1 Subprocess output: missing section headers (From OE-Core rev: 75b76eb08c7e344142f0326605aeb6b24e61e38e) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-15m4: 1.4.17 -> 1.4.18Robert Yang4
Rebased remove-gets.patch. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-15mklibs-native: 0.1.41 -> 0.1.43Robert Yang1
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-15strace: fix gawk's pathRobert Yang2
Fixed: strace-4.15: /usr/lib/strace/ptest/tests/caps-abbrev.awk contained in package strace-ptest requires /bin/gawk, but no providers found in RDEPENDS_strace-ptest? [file-rdeps] The path should be /usr/bin/gawk as other scripts use in this package. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-15strace: 4.14 -> 4.15Robert Yang1
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-15git: 2.11.0 -> 2.11.1Robert Yang2
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-15e2fsprogs: 1.43.3 -> 1.43.4Robert Yang2
* Rebased Revert-mke2fs-enable-the-metadata_csum-and-64bit-fea.patch. * The mkfs.ext4dev is gone. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-15elfutils: update homepage and upstream souceHongxu Jia1
In git://sourceware.org/git/elfutils.git: ---------------- commit 1700fd25e6caf26663af2bd994d1d99fab9df59f Author: Mark Wielaard <mark@klomp.org> Date: Sat Dec 24 22:31:41 2016 +0100 http://elfutils.org/ is now hosted at http://sourceware.org/elfutils/ fedorahosted used to be our home, but we are now hosted at sourceware. Change the elfutils project home to http://elfutils.org/ Point hosted services (email, release, git, bug tracker and web pages) to https://sourceware.org/elfutils/ Move design notes from README to NOTES. Add URLs for home, releases, bugs, git and mailinglist to README. Make the --version output of all tools the same by using a common print_version function and update the publicly shown copyright holder to the elfutils developers. Signed-off-by: Mark Wielaard <mark@klomp.org> ------------------ Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
2017-02-15elfutils: 0.166 -> 0.168Hongxu Jia23
- Backport patches from debian to 0.168 and add US tags. - Rebase 0001-build-Provide-alternatives-for-glibc-assumptions-hel.patch to support libc musl Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
2017-02-15pax-utils: 1.1.6 -> 1.2.2Hongxu Jia1
Export GNULIB_OVERRIDES_WINT_T to fix compile failure --------- 1099 make[4]: *** [printf-args.o] Error 1 1100 make[4]: *** Waiting for unfinished jobs.... 1101 In file included from ../../../pax-utils-1.2.2/autotools/gnulib/printf-args.h:41:0, 1102 from ../../../pax-utils-1.2.2/autotools/gnulib/printf-parse.h:29, 1103 from ../../../pax-utils-1.2.2/autotools/gnulib/printf-parse.c:36: 1104 ./wchar.h:476:6: error: #if with no expression 1105 # if 1106 ^ 1107 make[4]: *** [printf-parse.o] Error 1 --------- Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
2017-02-15python: Don't use getentropy on LinuxAndreas Oberritter2
Backport a patch from 2.7 branch to fix a regression with glibc 2.24 causing "OSError: [Errno 38] Function not implemented" when calling urandom() with older kernels. Signed-off-by: Andreas Oberritter <obi@opendreambox.org> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-15pseudo: update to 1.8.2Joshua Lock9
Update to the newly minted 1.8.2, dropping several patches we'd backported since the last release. Signed-off-by: Joshua Lock <joshua.g.lock@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-02-15smartpm: if RPM transaction fails with an empty list of problems in attempt ↵Herve Jourdain1
mode, ignore it! Since commit be0cabf816a84c59e0e951b92a570121ed843822 on 2016/05/17, smartpm will retry the transaction if ts.run() returns with an empty list of problems, and we're in attempt mode. But then, since all the packages are already installed, the transaction will fail with "package already installed" error. In attempt mode, it's fine to not retry nor generate an error when the transaction fails for no reason linked to files/packages conflicts, so this patch fixes this behaviour. Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr> Signed-off-by: Ross Burton <ross.burton@intel.com>