summaryrefslogtreecommitdiff
path: root/meta/recipes-devtools
AgeCommit message (Collapse)AuthorFiles
2016-02-05e2fsprogs: Ensure we use the right mke2fs.conf when restoring from sstateRichard Purdie1
If we don't do this, we can use an mke2fs.conf from a different path which may contain incompatible flags and lead to obtuse build failures such as: Invalid filesystem option set: has_journal,extent,huge_file,flex_bg,metadata_csum,64bit,dir_nlink,extra_isize To fix this, wrap the mke2fs binary and its hardlinks and point at the correct configuration file. In particular this fixes conflicts between master and jethro builds affecting the main autobuilder. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-04syslinux: remove LDFLAGS manipulationRoss Burton1
syslinux appears to be using gcc to link instead of LD directly now, so we can remove the manipulation of LDFLAGS. Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-04python-distutils: add missing dependency on python-emailDominique Hunziker2
Signed-off-by: Dominique Hunziker <dominique.hunziker@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-02-04i2c-tools: point SRC_URI at Yocto source mirrorsRoss Burton1
The ln-sensors.org web site has been down for some time, so point the SRC_URI at the Yocto Project source mirror. Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-02-04python-pycurl: remove unnecessary exportsRoss Burton1
These variables are exported through distutils.bbclass, so there's no need to do it again. Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-04busybox/gtk/perl/base-passwd: Ensure data is correctly expandedRichard Purdie1
Where variables are used in python, we need to ensure they are expanded. This happens to work at the moment but likely will not happen in future and isn't good code practise. Its mostly an issue around key values, since bitbake has already performed key expansion when these functions are executed. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-02python3: set INSANE_SKIP as libpython3.so is a trampoline libraryRoss Burton1
Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-02-02gcc-configure-common.inc: drop --enable-target-optspace from configureAndre McCurdy2
Configuring gcc with --enable-target-optspace (which causes gcc to append "-g -Os" to the default CFLAGS_FOR_TARGET and so force libgcc etc target libraries to always be optimised for size) dates back to the very first commit in oe-core git in 2005 (for gcc 3.4.3). Configuring gcc with --enable-target-optspace is not done widely elsewhere (it's not used for Ubuntu or Fedora host gcc, the Linaro binary toolchain or in Buildroot since early 2015). Sometime around gcc 4.5.x it caused problems for powerpc and so was disabled for that architecture: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43810 This patch removes --enable-target-optspace completely (ie powerpc is no longer a special case) and allows optimisation of libgcc etc to be controlled directly by the flags present in TARGET_CFLAGS. Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-02machine/include: drop tune-cortexm*.inc and tune-cortexr4.incAndre McCurdy1
The Cortex M1, M3 and R4 CPU tuning files are poorly tested (if at all). They have no obvious users either inside or outside oe-core. Until OE officially gains support for CPUs without an MMU, these tuning files are probably better maintained outside of oe-core (e.g. in a separate meta-nommu layer). Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-02libtool-cross: Unset pre|post dep objectsKhem Raj1
predep_objects and postdep_objects are specifying the duplicate objects which are better computed by gcc/g++ driver, since we want to generate PIE, PIC and non-PIC combinations, let gcc decide on this, since it knows best about linker options to use in each of these situations. When we defer the linker options to driver, we also need to remove -nostdlib from linker commandline options. Remove duplicate directory creation for ${D}${bindir_crossscripts}/ This fixes a frequent problem we see during -fpie links e.g. | /home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/sysroots/qemux86-64/usr/include/c++/5.3.0/iostream:74: undefined reference to `__dso_handle' | /home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/sysroots/x86_64-linux/usr/libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/5.3.0/ld: .libs/cxx_channel.o: relocation R_X86_64_PC32 against undefined hidden symbol `__dso_handle' can not be used when making a shared object | /home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/sysroots/x86_64-linux/usr/libexec/x86_64-oe-linux/gcc/x86_64-oe-linux/5.3.0/ld: final link failed: Bad value After this change libtool gets changed as below old_archive_from_expsyms_cmds="" # Commands used to build a shared archive. -archive_cmds="\$CC \$pic_flag -shared -nostdlib \$predep_objects \$libobjs \$deplibs \$postdep_objects \$compiler_flags \$wl-soname \$wl\$soname -o \$lib" -archive_expsym_cmds="\$CC \$pic_flag -shared -nostdlib \$predep_objects \$libobjs \$deplibs \$postdep_objects \$compiler_flags \$wl-soname \$wl\$soname \$wl-retain-symbols-file \$wl\$export_symbols -o \$lib" +archive_cmds="\$CC \$pic_flag -shared \$predep_objects \$libobjs \$deplibs \$postdep_objects \$compiler_flags \$wl-soname \$wl\$soname -o \$lib" +archive_expsym_cmds="\$CC \$pic_flag -shared \$predep_objects \$libobjs \$deplibs \$postdep_objects \$compiler_flags \$wl-soname \$wl\$soname \$wl-retain-symbols-file \$wl\$export_symbols -o \$lib" # Commands used to build a loadable module if different from building # a shared archive. @@ -11908,8 +11908,8 @@ # Dependencies to place before and after the objects being linked to # create a shared library. -predep_objects="/home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/sysroots/qemux86-64/usr/lib/../lib/Scrt1.o /home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/sysroots/qemux86-64/usr/lib/../lib/crti.o /home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/sysroots/qemux86-64/usr/lib/../lib/x86_64-oe-linux/5.3.0/crtbeginS.o" -postdep_objects="/home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/sysroots/qemux86-64/usr/lib/../lib/x86_64-oe-linux/5.3.0/crtendS.o /home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/sysroots/qemux86-64/usr/lib/../lib/crtn.o" +predep_objects="" +postdep_objects="" predeps="" postdeps="-lstdc++ -lm -lgcc_s -lgcc -lc -lgcc_s -lgcc" Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-02-02docbook-xsl-stylesheets: create a link for easy referKai Kang1
Create a link to stylesheets directory for docbook-xsl-stylesheets to make it easy to refer. Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-31binutils: Use target provided zlibRichard Purdie1
When using -fpie (security related cflags), qemux6-64 builds would fail due to linker symbol errors. This was due to the internal zlib that binutils was using. Add the switch to tell it to use the target system zlib which is already in DEPENDS. That zlib is already compiled with the correct flags. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-31binutils: Upgrade to 2.26Khem Raj23
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-30gcc, qemuppc: Explicitly disable forcing SPE flagsKhem Raj1
G4 does not have SPE, so we make that explicit in the tune files and since we emulate G4 when building Qemu, we ensure it for qemuppc as well. GCC config for powerpc-linux is made to include SPE by default which is equivalent if the tripet was powerpc-linux*spe, this forces gcc to configure assembler to enable -mspe by default, when we do that then the kernel fails to compile with binutils 2.26, since newer assembler is smart to detect the tlbia instructions are not compatible with SPE and hence the kernel build breaks rightly. We configure the kernel for G4 as well where it enables tlbia instrucitons rightly so because it thinks its being configured for power4. So we keep the options but do not force -mspe down to assembler as default. Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-30mkelfimage: fix target cflags leaks to hostHongxu Jia1
The patch fix-makefile-to-find-libz.patch fixed native compile failure; for target compile, it incorrectly leaks CFLAGS to HOST_CFLAGS. [YOCTO #3547] Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-29gdb-common.inc: add PACKAGECONFIG for readlineRobert Yang1
When compile with readline 5.2: completer.o: In function `gdb_display_match_list': completer.c:(.text+0x1c13): undefined reference to `_rl_completion_prefix_display_length' completer.c:(.text+0x1ce8): undefined reference to `rl_sort_completion_matches' collect2: ld returned 1 exit status The --without-system-readline will make it work. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-29gcc-cross.inc: drop pruning of PATCH_GET from the testgcc scriptAndre McCurdy1
PATCH_GET is no longer exported by bitbake.conf, so no longer needs to be pruned from the gcc-cross do_compile() environment. Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-29git: use bash-completion.bbclassGeorge McCollister1
Use bash-completion.bbclass to package bash completions. Signed-off-by: George McCollister <george.mccollister@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-29gcc: fix hidden weak symbols by removing buggy gcc patchMathieu Desnoyers2
We are noticing the presence of the following patch in various openembedded gcc versions: 0024-PR-target-32219.patch However, contrarily to its "Backport" status, that patch is not upstream in gcc, and it breaks handling of start/stop automatic weak hidden symbols we use in lttng-ust. We are only experiencing problems on the various openembedded compilers, but on no other distro (with same compiler versions), which led us to suspect a buggy distro-specific gcc patch. We've been testing with openembedded gcc-4.9.2-r0. Rebuilding the gcc compiler with this patch removed fixes the lttng-ust issue. Link: http://lists.openembedded.org/pipermail/openembedded-core/2016-January/116306.html Link: http://lists.lttng.org/pipermail/lttng-dev/2014-May/023112.html Link: https://gcc.gnu.org/ml/gcc-help/2014-05/msg00042.html Link: http://cgit.openembedded.org/openembedded-core/commit/?id=3cb2b003db7371b3a47d02c08352a262e1e419b4 Link: https://sourceware.org/bugzilla/show_bug.cgi?id=15435 Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-29dpkg: fix CVE-2015-0860Catalin Enache2
Backported and cherry picked upstream commit: https://anonscm.debian.org/cgit/dpkg/dpkg.git/commit/?h=wheezy&id=f1aac7d933819569bf6f347c3c0d5a64a90bbce0 Signed-off-by: Catalin Enache <catalin.enache@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-29elfutils: Fix build with uclibc/muslKhem Raj7
Remove mempcpy patch its already in uclibc now refresh libargp patch to match latest elfutils Add ALLOW_EMPTY for musl core-image-cmdline-full asks for elfutils package to be added to package it has all eu-* tools but we dont build them on musl. nevertheless lets satisfy the dependency so image can build for musl Build libdw,libasm,libebl along with libelf enhance the musl portability patch to compile every other library except the eu-* tools Fix build on aarch64/musl issues Header inclusion ends up with duplicate definitions of iovec struct since uclibc defines the same in usersapce, we have been depending upong including the kernel header on aarch64, using sys/uio.h is the right approach Fix x86 build warning seen on musl Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-26cmake: update to 3.4.2Alexander Kanavin3
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-26vala: update to 0.30.0Alexander Kanavin2
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-26btrfs-tools: Disable backtrace on muslKhem Raj1
musl does not support backtrace APIs Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-26gdb: Fix build failures on muslKhem Raj2
mode_t is needed by gdbserver headers so include sys/types.h to get them Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-26mtools: keep v3.9.9 recipe in sync with the v4.0.18 versionAndre McCurdy1
Changes are mostly cosmetic, but also include one important fix to support builds using musl libc. http://git.openembedded.org/openembedded-core/commit/?id=9f5eb272784d3be17e7fe8e7cab511bd4086ba1e Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-26meta: fix capitalisation in Upstream-StatusRoss Burton1
Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-26e2fsprogs: disable blkidRoss Burton1
Both e2fsprogs and util-linux can build blkid, but we want to always use util-linux's for consistency. (blkid was enabled again in a1f235) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-25gcc-cross-canadian: Add missing DEPENDS on virtual/${HOST_PREFIX}gcc-crosssdkRichard Purdie1
The cross-canadian compiler needs the nativesdk compiler to build but for some reason this was missing. Add the missing dependency. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-25Revert "xz: Allow to work with ASSUME_PROVIDED xz-native"Richard Purdie1
This reverts commit 5c69c561a76cb10d7896ae0a0399190f11b2e0ca. The change was incomplete, not handling cases such as the fetcher using xz, or linux-yocto, dpkg or apt or the lzma image type. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-24python3-pip: Upgrade to 8.0.0Alejandro Hernandez1
LIC_FILES_CHKSUM changed, but LICESE still applies, dates changed Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-24orc: update HOMEPAGEAndre McCurdy1
The old entropywave.com URL no longer responds. Also remove unnecessary 'name=orc' from SRC_URI. Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-23xz: Allow to work with ASSUME_PROVIDED xz-nativeRichard Purdie1
At some point we may want to add xz-native to ASSUME_PROVIDED. This allows that to work whilst still allowing access to liblzma for those things which need it (e.g. pixz). Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-22syslinux: Set LD to avoid using build host ldKhem Raj1
base ld is used during link phase and since its x86 so it works mostly, however it can cause problems depending upon build host. During cross build we should use cross linker Fixes errors e.g. ld -shared -m elf_i386 --hash-style=gnu -T /home/ubuntu/work/oe/openembedded-core/build/tmp-glibc/work/i586-oe-linux/syslinux/6.03-r0/syslinux-6.03/com32/lib/i386/elf.ld -soname libcom32.c32 -o libcom32.elf zlib/adler32.o zlib/compress. o zlib/crc32.o zlib/uncompr.o zlib/deflate.o zlib/trees.o zlib/zutil.o zlib/inflate.o zlib/infback.o zlib/inftrees.o zlib/inffast.o sys/zfile.o sys/zfopen.o libpng/png.o libpng/pngset.o libpng/pngget.o libpng/pngrutil.o libpng/pngtrans.o libpng/pngwutil.o libpng/pngread.o libpng/pngrio.o libpng/pngwio.o libpng/pngwrite.o libpng/pngrtran.o libpng/pngwtran.o libpng/pngmem.o libpng/pngerror.o libpng/pngpread.o jpeg/tinyjpeg.o jpeg/jidctflt.o jpeg/decode1.o jpeg/decode3.o jpe g/rgb24.o jpeg/bgr24.o jpeg/yuv420p.o jpeg/grey.o jpeg/rgba32.o jpeg/bgra32.o pci/cfgtype.o pci/scan.o pci/bios.o pci/readb.o pci/readw.o pci/readl.o pci/writeb.o pci/writew.o pci/writel.o sys/vesacon_write.o sys/vesaserial_write.o sys/ve sa/initvesa.o sys/vesa/drawtxt.o sys/vesa/background.o sys/vesa/alphatbl.o sys/vesa/screencpy.o sys/vesa/fmtpixel.o sys/vesa/i915resolution.o syslinux/reboot.o syslinux/keyboard.o syslinux/version.o syslinux/pxe_get_cached.o syslinux/pxe_get_nic.o syslinux/pxe_dns.o syslinux/video/fontquery.o syslinux/video/reportmode.o syslinux/addlist.o syslinux/freelist.o syslinux/memmap.o syslinux/movebits.o syslinux/shuffle.o syslinux/shuffle_pm.o syslinux/shuffle_rm.o syslinux/bios$oot.o syslinux/zonelist.o syslinux/dump_mmap.o syslinux/dump_movelist.o syslinux/run_default.o syslinux/run_command.o syslinux/cleanup.o syslinux/localboot.o syslinux/runimage.o syslinux/loadfile.o syslinux/floadfile.o syslinux/zloadfile$o syslinux/load_linux.o syslinux/initramfs.o syslinux/initramfs_file.o syslinux/initramfs_loadfile.o syslinux/initramfs_archive.o sys/libansi.o sys/gpxe.o atexit.o onexit.o abort.o | ld: zlib/deflate.o: unrecognized relocation (0x2b) in section `.text' | ld: final link failed: Bad value | make[4]: *** [libcom32.elf] Error 1 Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22binutils: Fix gold linking errors due to unresolved R_ARM_MOVW_ABS_NCKhem Raj2
This issue has been seen in multiple times e.g. http://patchwork.openembedded.org/patch/103083/ https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg72513.html Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22unfs3: Depend on libtirpc when building on muslKhem Raj1
needs a rpc implementation Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22guile: Fix build with muslKhem Raj2
strol_l is not available on musl delete charset.alias as well its not needed Use internal gc function on musl We get errors on certain functions not being available in boeheme gc when built with musl. Therefore use the internal versions e.g. Undefined gc_set_finalizer_notifier Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22dosfstools: Correct cross-compile CFLAGS and fix build with muslKhem Raj3
enable largefile support if its in DISTRO_FEATURES Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22tcf-agent: Implement canonicalize_file_name() for musl as wellKhem Raj2
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22apt: Add support for building for musl targetsKhem Raj3
Turn bzip2 support into a PACKAGECONFIG zlibs is a must have and therefore add it to DEPENDS will make the build consistent Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22dpkg: Add musleabi to known architecturesKhem Raj2
Remove a glibc specific patch to be applied only for native version, this is a dpkg-native specific patch needed for Centos 5.8, this patch should be redone to be glibc independent for it to be applied to all types of dpkg recipes Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22mtools: Fix build with uclibcKhem Raj1
unlike glibc, uclibc does not have internal APIs implemented for libiconv, so it needs to depend upon libiconv Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22guile: Fix build with uclibcKhem Raj2
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2016-01-22python-setuptools: Unify and upgrade python-setuptools and ↵Alejandro Hernandez4
python3-setuptools to 19.4 Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-22valgrind: remove unused valgrind-remove-rpath.patchAndre McCurdy1
Replaced by 0002-remove-rpath.patch during the 3.10 -> 3.11 update. Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
2016-01-22e2fsprogs: set PV to 1.42.99+1.43+git${SRCPV}Robert Yang1
As Martin and Ross suggested. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-22valgrind: avoid neon for targets which don't support itAndre McCurdy2
The sh-mem-random.c test app tries to use neon loads and stores to test 64-bit float copies when building for ARM. Allow it to do so if possible, but fallback to C when building for ARM targets which don't support neon. Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-22valgrind: re-enable ARM intdiv and vcvt_fixed_float_VFP testsAndre McCurdy3
The intdiv test has been partially fixed upstream and the vcvt_fixed_float_VFP test can be fixed with a similar approach, ie ensuring that it is always compiled with appropriate -march/-mcpu/-mfpu flags to support the instructions being tested. For tests requiring armv7ve instructions, ensure that we set both -march=armv7ve and -mcpu=cortex-a15 (since some TUNE_CCARGS may set -march=armv7-a and adding -mcpu=cortex-a15 alone is not enough to over-ride that). See similar cases in none/tests/arm/Makefile.am Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-22valgrind: let valgrind determine its own optimisation flagsAndre McCurdy1
Valgrind likes to control its own optimisation flags. It generally defaults to -O2 but uses -O0 for some specific test apps etc. Passing our own flags (via CFLAGS) means we interfere with that. Giving valgrind control of optimisation is hopefully an even better solution than the previous one of forcing -O0 for all tests. http://git.openembedded.org/openembedded-core/commit/?h=master-next&id=98c4a3ffb8dca10739be600e8d6df7fb6aa4958f Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-22python-nose: upgrade to 1.3.7Alejandro Hernandez1
Updates runtime dependencies, python-nose now depends on unittest. Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>