summaryrefslogtreecommitdiff
path: root/meta/files
AgeCommit message (Collapse)AuthorFiles
2016-02-10toolchain-shar-extract.sh: Add proxy variable to new env.Aníbal Limón1
Extensible SDK needs to do network operations so add proxies to environment. Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-22toolchain-shar-extract.sh: improve behaviour when xz is not installedPaul Eggleton1
Currently if xz isn't installed when installing the SDK you get an error from tar and then the SDK installation continues, cascading into a load of other failures since files are missing. Add a check to see if xz can be run and error out if it can't, and also exit if tar fails. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-22meta/files/toolchain-shar-relocate.sh: Detect different python binaries and ↵Liam R. Howlett1
select one that exists. Although the relocate_sdk.sh supports python3, fc23 does not symlink /usr/bin/python3 to /usr/bin/python. Using exec instead of a call to the correct interpreter causes a failure on fc23 when python2 is not present. This uses 'which' to locate python, python2, then python3 and uses the first one that's found. Signed-off-by: Liam R. Howlett <Liam.Howlett@WindRiver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-01-13classes/populate_sdk_ext: check that extensible SDK prepared correctlyPaul Eggleton2
After the change to use --setscene-only when running bitbake to prepare the SDK at the end of installation, add a check that the SDK got prepared correctly by doing a dry-run and looking at the output for any real tasks that we don't expect. In order to make this easier, the preparation shell script was rewritten in python. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-11populate_sdk: Switch from bzip2 to xzRichard Purdie1
xz gives *much* faster decompression times for the SDK which in itself is a good reason to use it. It also gives better compression. One downside is its slower but we care about the end user case first, build performance secondary. It also assumes the SDK user has a tar capable of understanding a xz compressed file but that should be common enough now. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-01-11populate_sdk_ext: Use new --setscene-only option to bitbake instead of ↵Richard Purdie1
workarounds Rather than horrible workarounds, use the new --setscene-only option of bitbake to pre-populate the SDK structures. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-12-11toolchain-shar-extract.sh: fix ~ not working in pathPaul Eggleton1
Fix a second regression in the extensible SDK installation caused by OE-Core revision 6d2074d477596971dc52027dd87b02af7f39138d - the HOME environment variable was being cleared, thus using ~/ in the install path (which is in the default path for the extensible SDK) resulted in a directory named '~' being created in the current directory. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-12-08toolchain-shar-extract.sh: ensure cleaned environment will work for ext SDKPaul Eggleton1
In OE-Core revision 6d2074d477596971dc52027dd87b02af7f39138d we added a line which re-executes the script with a cleaned environment using env -i; unfortunately that caused a regression in the extensible SDK on Ubuntu 14.04 - strangely, there it seems that the value you get for PATH under env -i contains '.' which triggers a sanity check failure when preparing the build system. Do a belt-and-braces fix - source /etc/environment if it exists (so you get a more complete PATH value) and then filter any nastiness out of PATH for good measure. (Ubuntu 15.04 doesn't seem to suffer from the same problem.) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-12-08toolchain-shar-extract.sh: proper fix for additional env setup scriptsPaul Eggleton2
buildtools-tarball uses a custom env setup script, which isn't named the same as the default; thus unfortunately OE-Core revision a36469c97c9cb335de1e95dea5141038f337df95 broke installation of buildtools-tarball. Revert that and implement a more robust mechanism. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-12-01toolchain-shar-extract.sh: Ensure it's ran in clean environmentGeorge Nita1
Fixes [YOCTO #8698] -- https://bugzilla.yoctoproject.org/show_bug.cgi?id=8698 If prior to running the toolchain installation script a toolchain environment script is sourced then the toolchain installation will fail. This because the environment is now set for the sourced toolchain and doesn't suit the installation. In particular PATH points to the toolchain executables. The fix makes the script recursively call itself a second time with a clean environment. Tested by sourcing a previous successfully installed environment, erasing the previous installation directory and then reinstalling in the same directory. Signed-off-by: George Nita <george.nita@enea.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-12-01toolchain-shar-extract.sh: do not allow $ in paths for ext SDKPaul Eggleton1
If you put an $ character in the path, SDK installation fails during the preparation stage, so add this to the disallowed characters. Fixes [YOCTO #8625]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-12-01toolchain-shar-relocate: don't assume last state of env_setup_script is goodJean-Francois Dagenais1
In the case where many environment-setup-* files exist, the incorrect filename might be lastly set in env_setup_script, which leads to incorrect behaviour for the initialization of native_sysroot. The scenario I had was that our custom meta-toolchain-*.bb, which inherits populate_sdk, defined another environment-setup-* file to dump variable information for qt-creator. The file is named like so in order for the sdk shell script to pick it up and fix the SDK paths in the file. Since it (coincidentally) alphabetically comes after ...-core2, it was last set in env_setup_script and the grep OECORE_NATIVE_SYSROOT would simply be blank. The apparent symptom was "...relocate_sdk.py: Argument list too long" since the find command would not be searching in the right path. Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-10-20toolchain-shar-extract.sh: print full-length title underlinePaul Eggleton1
Print a line that's the full length of the title that it's underneath. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-10-20classes/populate_sdk_ext: prevent image construction from executing on installPaul Eggleton1
In order to prepare the build system within the extensible SDK, we actually go ahead and build the targets specified by SDK_TARGETS (by default the image the SDK was built for). Assuming that's an image, we don't actually need to build the image itself - we just need to have everything done up to the point before building the image, so that we have everything needed in the sysroot. In order to do this, create temporary bbappends for each of the targets in the workspace layer that stub out do_rootfs and related tasks if they exist. This is a little bit of a hack but is the least intrusive fix at this point. To make things a bit tidier, I have split out the preparation commands into a separate script so we can run that in the appropriate environment rather than all the commands separately. Fixes [YOCTO #7590]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-10-19toolchain-shar-extract.sh: provide proper path for env_setup_scriptMaxin B. John1
The toolchain install script suggest the user to source env_setup_script from wrong path now. eg: " Each time you wish to use the SDK in a new shell session, you need to source the environment setup script e.g. $ . /opt/poky/2.0//opt/poky/2.0/environment-setup-armv5e-poky-linux-gnueabi " fix it. Signed-off-by: Maxin B. John <maxin.john@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-10-19common-licenses: use correct GFDL-1.1 license textPaul Eggleton1
It seems that the GFDL 1.1 license file that was originally committed was actually the 1.2 version. Replace it with the 1.1 version fetched from http://www.gnu.org/licenses/old-licenses/fdl-1.1.txt. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-09-29toolchain-shar-extract: Correct environment-setup script names for multilibRichard Purdie1
Currently a lib32-core-image-* SDK prints an incorrect environment-setup-* file name when installing the SDK. Instead of printing the wrong thing, list the environment setup files present in the SDK. As it happens this fixes the message printed with buildtools-tarball too which someone reported to me about the same time as I finished this patch! Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-09-29toolchain-shar-relocate.sh: make it fasterRobert Yang1
Make the extrating faster by: * Merge the two heavy "for .. find" loops into one * Move the commands out of for loop rather than inside, this can reduce the forking amount. As a result, when install: * buildtools-nativesdk-standalone: 14s -> 7s (50% saved) * core-image-minimal-core2-64-toolchain: 56s -> 47s (17% saved) [YOCTO #8404] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-09-24toolchain-shar-extract.sh: remove checkbashismRobert Yang1
Fixed when sh is bash: $ sh ./tmp/deploy/sdk/poky-glibc-x86_64-core-image-minimal-core2-64-toolchain-1.8+snapshot.sh Poky (Yocto Project Reference Distro) SDK installer version 1.8+snapshot =========================================================== ./tmp/deploy/sdk/poky-glibc-x86_64-core-image-minimal-core2-64-toolchain-1.8+snapshot.sh: 77: read: Illegal option -e You are about to install the SDK to "/opt/poky/1.8+snapshot". Proceed[Y/n]? ../SDK2 Installation aborted! There is ony one bashism "read -e" in toolchain-shar-extract.sh, but '-e' is useless here, so remove it and use /bin/sh. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-09-22toolchain-shar-extract.sh: show progress when extracting SDKPaul Eggleton1
Tar has supported a --checkpoint option since version 1.15.91, so it should be safe to use here to print dots showing that it's still doing something (technically it's not really progress unless you know how many dots it's going to print, which even it doesn't know at the start, but it's better than nothing). Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-09-07Extensible SDK: allow for installation without preparing build systemQi.Chen@windriver.com1
When publishing SDK, what we want is basically its metadata and sstate cache objects. We don't want the SDK to be prepared with running bitbake as it takes time which reproduces meaningless output for the published SDK. So this patch adds an option to allow for SDK to be extracted without preparing the build system. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-09-07toolchain-shar-extract.sh: explain why we cannot use sudo in extensible SDKBrendan Le Foll1
Signed-off-by: Brendan Le Foll <brendan.le.foll@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-09-07toolchain-shar-extract.sh: better default install path for extensible SDKBrendan Le Foll1
Extensible SDK cannot be installed as root so by default offer to install it in user's home directory under distro/distro_version replacing the normal SDK version '+' char with a '_' as that's a restricted character for bitbake Signed-off-by: Brendan Le Foll <brendan.le.foll@intel.com> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-09-07toolchain-shar-extract.sh: ensure extensible SDK install path obeys restrictionsBrendan Le Foll1
There are some characters that cannot appear in the installation path, so we need to check for these Signed-off-by: Brendan Le Foll <brendan.le.foll@intel.com> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-19toolchain-shar-extract.sh: add a space in the endRobert Yang1
For a clear look when input. [YOCTO #8089] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-07-20extensible sdk: Error when trying to install as root.Randy Witt1
Since the extensible sdk uses bitbake, which can't run as root, the sdk shouldn't be installed as root. Previously it would error out late into setup when bitbake errored saying not to run bitbake as root. Now the script errors with a message saying the extensible sdk can't be installed as root. [Yocto #7545] Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-06-11Add license file XFree86-1.0Kai Kang1
Add license file XFree86-1.0 which is needed by packages such as hwdata. It is from: http://www.x.org/archive/X11R7.5/doc/LICENSE.html#AEN28 And add 'XFree86-1.0' to SRC_DISTRIBUTE_LICENSES. Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-04-30Revert "common-licenses: Add common license files for linux-firmware"Jackie Huang36
This reverts commit 9021ee03e0f9bd36b0ce63fa29dd010e07241fdb
2015-04-24toolchain-shar-extract.sh: mention how to set up the SDK environmentPaul Eggleton1
Tell the user how to set up the SDK environment each time they want to use it. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-24classes/populate_sdk_base: Show title in SDK installerPaul Eggleton1
Show a friendly title when running the SDK installer, so the user knows what SDK they are installing. The title is controlled by the SDK_INSTALLER_TITLE variable and includes the distro name and SDK version by default. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-15common-licenses: Add common license files for linux-firmwareJackie Huang36
[YOCTO #7539] Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-04-09common-licenses: Add BSD-0-ClauseKhem Raj1
Some packages like toybox use it Change-Id: I2ae4fd024e310bce644581e4c63ed2980ee1998f Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-02-23toolchain-shar-template.sh: Make relocation optional.Randy Witt2
If the buildsystem is copied into the sdk and its toolchain is to be used, then the relocation provided in toolchain-shar-template.sh isn't needed and will actually fail. So break the relocation aspect out and essentially make it another SDK_POST_INSTALL_COMMAND script. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-02-17populate_sdk: Handle OLDEST_KERNELRichard Purdie1
Add a check to the SDK so that it only runs on systems with kernel versions it supports. [YOCTO #6856] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-02-07files/toolchain-shar-template.sh: fix replace target_sdk_dir twice in ↵Aníbal Limón1
environment setup file When specify a target sdk dir that contains default install dir as subdir, target_sdk_dir=/opt/poky/$version/ custom_target_sdk_dir=/opt/poky/$version/some The target_sdk_dir variable in environment-setup file is replaced twice causes to point to wrong PATH. In order to fix filter environment-setup file in second replacement. [YOCTO #7032] Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2014-12-19common-licenses: add SMAIL_GPLRoss Burton1
This is used by debianutils. Signed-off-by: Ross Burton <ross.burton@intel.com>
2014-11-20toolchain-shar-template.sh: fix the text files in the top dirRobert Yang1
It only fixed the text files in native_sysroot, but there might be some files in the top installed dir (whose var name is target_sdk_dir in the code) which are also needed to be fixed. It used "find $native_sysroot", now also "find $target_sdk_dir -maxdepth 1", and split the long line into small ones. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2014-11-09populate_sdk_base: improve POSIXLY_CORRECT compatRichard Tollerton1
The install script is sometimes called under POSIXLY_CORRECT. This requires two fixes be made: 1. `find -perm /0000` is a gnuism; replace with an equivalent boolean expression using `-perm -0000`. 2. POSIX grep requires that all options be passed on the command line before all files; otherwise, the options must be parsed as filenames. Signed-off-by: Richard Tollerton <rich.tollerton@ni.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2014-09-11classes/populate_sdk_base: enable adding custom commands to SDK install scriptPaul Eggleton1
Add an SDK_POST_INSTALL_COMMAND variable which allows additional commands to be added towards the end of the SDK install script, for e.g. additional processing that needs to be done as part of installing the SDK. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-08-15toolchain-shar-template.sh: Limit xargs command lineGary Thomas1
It's possible to generate a command line in the relocate_sdk.sh script which is too long (long paths, many files). This change limits the xargs command line by breaking it up into smaller pieces. One necessary side effect is that the -0 option is no longer used as it doesn't seem to work properly with -n, so the file name arguments are now quoted explicitly rather than \0 terminated. Signed-off-by: Gary Thomas <gary@mlbassoc.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-08-15populate_sdk_base: Move toolchain installation script to a separate fileRichard Purdie1
It makes sense to move the script to a separate file, making the bbclass clearer and allowing the end user to more easily customise or replace it. There are no functionality changes, just the addition of some substitution variables. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-07-29base-files: fix up misleading dir grouping names for lsb dirsPaul Gortmaker1
In commit b0df35f47fb79dc149504bd66d1186b3276f9510 ("base-files: Add to make some directories needed by LSB.") there were new groupings of dirs made. But rather than keep the grouping names permissions based as they clearly were, it seems that it was unfortunately misinterpreted as a counter, simply incrementing as a new group was added. This leads to dir3755 getting chmod'd to 0755 and dir4775 being chmod'd to 2775 which to any new reader of the code is terribly confusing. Choose names that clearly reflect the permissions, and add a lsb suffix to indicate the role. Also note that the settings for /var/mail seem incorrect, and so they have been aligned with what is seen in most common distros. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-07-29base-files: remove strange 2775 perms from dirs like /homePaul Gortmaker1
Mark Hatle did the historical research into why this was so, and found that it originally was via debian import, and then it morphed over time: <fray> +# chown -R root:root ${D} <fray> +# cd ${D} && chown root:src usr/src <fray> +# cd ${D} && chown root:staff var/local <fray> +# cd ${D} && chown root:staff home <fray> + cd ${D} && chmod 755 `find . -type d` <fray> + cd ${D} && chmod 1777 `cat ${S}/debian/1777-dirs` <fray> + cd ${D} && chmod 2775 `cat ${S}/debian/2775-dirs` <fray> that was the original code <fray> so THAT is why they're 2775.. <fray> they were original 'src' and 'staff'.. which has gotten lost sometime in the last 10 years <fray> AND the origin: <fray> commit b45c9ed40bb4f893f99127a21776aef3ae888ad7 <fray> Author: Chris Larson <clarson@kergoth.com> <fray> Date: Tue Sep 30 16:30:41 2003 +0000 <fray> Add base-files 3.0.10 (from debian). <fray> thats where the brain damage started ... Debian in 2003.. Here we simply convert them to being normal 755 dirs. [YOCTO #6579] Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-07-16docbook-xml: add docbook-xsl-stylesheets 1.78.1Hongxu Jia1
About the config files (docbook-xsl.xml), we refered what Ubuntu 13.04 did, so the xmlto could correctly search the xsl stylesheets. [YOCTO #2416] Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-05-08tcl: cleanupMatthieu Crapet1
Changes: - add missing licence file: tcl - use binconfig to patch tclConfig.sh paths - avoid subshell in do_configure() - use ${PV} Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com> Signed-off-by: Saul Wold <sgw@linux.intel.com>
2014-04-25files/device_table-minimal.txt: cleanupMatthieu Crapet1
This device list is only used if USE_DEVFS is set to '0' (which is NOT the default since 2013-12-14, see commit f54fdd6673a136ee1cee1f3263a8a7820de43ca3) and if IMAGE_DEVICE_TABLE and IMAGE_DEVICE_TABLES are not set. This is, of course a very subjective list but minimal with 62 (special) files. However, you should be able to boot correctly a lot of embedded linux around. Changes: - add sda, sdb, sda[1234], sdb[1234] - add mmcblk0, mmcblk0p[1234] - add rtc0, rtc1 - restrict maximum hdaX from 19 to 4 (pata is old) - add ttyS1 - remove initctl, apm_bios, tty8, ttySA - sorted entries Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2014-01-28unfs3: Add a NFSv3 user mode server for use with runqemuJason Wessel1
The user mode nfs server allows the use of runqemu without any root privileges and may even be accelerated with kvm. Example: runqemu-extract-sdk tmp-eglibc/deploy/images/qemux86-64/core-image-minimal-qemux86-64.tar.bz2 rootfs runqemu qemux86-64 `pwd`/rootfs nographic slirp kvm [YOCTO #5639] Signed-off-by: Jason Wessel <jason.wessel@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com>
2013-10-14device_table-minimal.txt: change group of /dev/hda back to diskChen Qi1
The group for /dev/hda should be disk instead of root. The group ID for /dev/hda was 6, but it was modified to be root by accident in the following commit. commit c5ef0294a9b8d178896a47c9f5d6e3dd6797e343 device_table-minimal.txt: use user/group names instead of uid/gid This patch changes it back. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-08-16device_table-minimal.txt: use user/group names instead of uid/gidChen Qi1
Instead of hard coding the uid/gid, we prefer the way of using user/group names. Note the way of using uid/gid is still supported. [YOCTO #1159] Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com>
2013-06-17licences: Add SGI licenseDiego Rondini1
Add SGI license used, for example, in glmark2 Signed-off-by: Diego Rondini <diego.ml@zoho.com> Signed-off-by: Saul Wold <sgw@linux.intel.com>