summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFiles
2015-08-30bitbake.conf: Define fallback DISTRO_NAMEKhem Raj1
When using OE-Core only we miss this define and its now used in recipes like os-release, which goes undefined and when booting we see messages like Welcome to ${DISTRO_NAME} nodistro.0! This would change to Welcome to OpenEmbedded nodistro.0! Remove all trailing whitespaces while touching this file (From OE-Core rev: cf2383a63975ac7a51729a313fe0a52b559d2c61) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30mdadm: Upgrade mdadm_3.3.2.bb -> mdadm_3.3.4.bbKhem Raj3
Drop upstreamed patch for gcc5 compatibility Forward port x32 patch (From OE-Core rev: 2782ae4dfb417ba377f861283792d7d9929f2ae3) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30psplash: Turn psplash_fb_plot_pixel() into static inlineKhem Raj2
This function is not used anywhere except psplash-fb.c so make it static inline function which is portable across compilers Fixes issues like psplash-fb.o: In function `psplash_fb_draw_rect': | /mnt/home/kraj/work/angstrom/sources/openembedded-core/build/tmp-glibc/work/i586-oe-linux/psplash/0.1+gitAUTOINC+14c8f7b705-r15/git/psplash-fb.c:363: undefined reference to `psplash_fb_plot_pixel' (From OE-Core rev: 2429932c2dc1f81bf04f4377911094e2c8a04a19) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30libvorbis: Update libvorbis_1.3.4.bb -> libvorbis_1.3.5.bbKhem Raj1
Licence years have changes causing checksum changes -Copyright (c) 2002-2008 Xiph.org Foundation +Copyright (c) 2002-2015 Xiph.org Foundation (From OE-Core rev: cb034175054ae31f7065677ba36b6a45dc067be0) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30json-c: Include math_compat.c for NAN/INF valuesKhem Raj2
The backport patch also fixes the warning which was being work arounded by disabling unused-but-set-variable (From OE-Core rev: ebce241d0badff0a12b4c03a428720e0b4a59f32) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30sysvinit: Fix makefile bug found with clangKhem Raj2
This is due to specifying .h files on linker cmdline clang driver is picky about it, and its not entirely correct either (From OE-Core rev: de45b5e68faeefe3d68818d456f280b98f397634) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30cross-canadian.bbclass: support for TCLIBC="baremetal"Juro Bystricky1
Allow "baremetal" builds. (From OE-Core rev: 0cd3121058ea620c74622f1200c8040696b4d1d8) Signed-off-by: Juro Bystricky <juro.bystricky@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30libgcc-common.inc: overrides for libc-baremetalJuro Bystricky1
Added TCLIBC="baremetal" specific overrides. (From OE-Core rev: 044f989b34e46f919e6b28860d7a1b396b2c3808) Signed-off-by: Juro Bystricky <juro.bystricky@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30gcc-cross.inc: overrides for libc-baremetalJuro Bystricky1
Modifications to to support build for TCLIBC="baremetal" (From OE-Core rev: 9e7da158e0e7628c22013fbee34270f7d2db621f) Signed-off-by: Juro Bystricky <juro.bystricky@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30gcc-cross-canadian.inc: overrides for libc-baremetalJuro Bystricky1
Modify configure arguments (EXTRA_OECONF) to support build for TCLIBC="baremetal" (From OE-Core rev: 87e81e469fd941fa1b41ded3e02644695cafd2dc) Signed-off-by: Juro Bystricky <juro.bystricky@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30tclibc-baremetal.inc: baremetal specific distro policy fileJuro Bystricky1
Support for TCLIBC="baremetal". Allows building "baremetal" toolchains. (From OE-Core rev: f1972eea0145ca54f0c087c0f29fd2e54d6b95e8) Signed-off-by: Juro Bystricky <juro.bystricky@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30alsa-lib: Lift the limitation to use gcc only cross compilerKhem Raj2
alsa-lib configure tries to see that if CC variabled doesnt contain 'gcc' then it tries to guess and redefine CC to be something gcc, which doesnt work with OE since we define CC to have sysroot and options attached to it. So all tests fail when configure constructs the CC for cross compiler like this. This portion is not needed at all (From OE-Core rev: 33a7eb64cded61601c6ad6883e4d64ebe9ff547c) Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30devtool: implement build-image pluginEd Bartosh1
Implemented new plugin to build image from workspace packages. Plugin creates <image>.bbappend file, adds all workspace packages to the image using IMAGE_INSTALL_append variable in bbappend file. After that it runs 'bitbake <image>'. (From OE-Core rev: 00bc43868da3ea2a4532215d3abef8e150c7b2e5) Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30devtool: make add_md5 a public APIEd Bartosh2
Moved _add_md5 function from standard.py to __init__.py to be able to call it from other modules. (From OE-Core rev: ee38bb20dc7ba21dac782d8d13383f81dfedef55) Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30harfbuzz: upgrade to 1.0.2Cristian Iorga1
Bugfix release. (From OE-Core rev: 71dbd7cc2333fdf830f0f483774faeadbb0e2236) Signed-off-by: Cristian Iorga <cristian.iorga@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30btrfs-tools: 4.1.1 -> 4.1.2Robert Yang1
* Rename btrfs-tools_git.bb to btrfs-tools_4.1.2.bb * Remove PV in the recipe. (From OE-Core rev: 4b55d7e02cecc4f9cd5028185f9452f0c90cbf89) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30tune-octeon.inc: add BASE_LIB settingsDmitry Eremin-Solenikov1
Provide BASE_LIB settings for octeon* tunes that follow the practice of mips64/mips64-n32 tunes (lib64 for N64 ABI, lib32 for N32 ABI). (From OE-Core rev: 2b52312174e52886b0a978ece41f66b4fb455604) Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30tune-octeon.inc: correct packaging suffixDmitry Eremin-Solenikov1
Octeon II/III binaries can contain instructions that are not compatible with MIPS64 processors. Thus Octeon II/III packages should go to separate directories. Set MIPSPKGSFX_VARIANT_tune-* to Octeon-specific values and update PACKAGE_EXTRA_ARCHS_tune-* accordingly. (From OE-Core rev: 69798449a8c1049728674dd352cf828063974cd0) Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30oprofile: 1.0.0 -> 1.1.0Robert Yang4
* Remove backport patch filemode-fix.patch. * Update --with-kernel=${STAGING_DIR_HOST}/${prefix} to find kernel headers (linux/*.h) to fix the error: | checking kernel supports perf_events... unknown -- perf_event.h not found | ERROR: You requested to build oprofile with '--with-kernel=/buildarea/lyang1/test_f2/tmp/work-shared/qemux86/kernel-source', | but headers were not accessible at the given location. | Be sure you have run the following command from within your kernel source tree: | make headers_install INSTALL_HDR_PATH=<kernel-hdrs-install-dir> | Then pass <kernel-hdrs-install-dir> to oprofile's '--with-kernel' configure option. | configure: error: Unable to build oprofile. Exiting. (From OE-Core rev: b2200152deef0aec3cd8fe55bb73d6e8fccfe159) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30gnu-efi: 3.0.2 -> 3.0.3Robert Yang1
(From OE-Core rev: c731ecab0a6cb31198ec8270dc9381b14964dd3c) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-30gnupg: 2.1.6 -> 2.1.7Robert Yang1
(From OE-Core rev: 78b159bf753c43c78bb0f283add7d447b96e08f1) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29qemu-native: Enable temporary debug info as default.Aníbal Limón1
We recently enable backtrace print rev[1] for address qemu_cpu_kick_thread() issue but without debug information isn't useful. [YOCTO #8143] [1] 73a876e4ff04ebbbcd3bde62efe02146ab601e25 Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29systemd: Increase devices timeout in QEMU machines to avoid failures on ↵Aníbal Limón2
serial-getty Systemd serial-getty is failing because dev-tty ends with timeout, systemd uses a default timeout of 90 secs that it's reached on AB's production environment due to high I/O loads (nfs). When use QEMU is used without KVM support, the machine code is executed by TCG (software code execution) that is dependent on devices layer and causes locks between TCG/Devices increasing the machine code execution time [1]. QEMU don't support configuration of device timeout always uses a default one that is 90 secs, so the next patch increases the device timeout to 240 secs [2] in order give enough time to get devices ready. It ONLY applies on QEMU machines. [YOCTO #8141] [1] http://blog.vmsplice.net/2011/03/qemu-internals-overall-architecture-and.html [2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8141#c10 Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29gcc-source: exlude from worldRandy MacLeod3
Exclude all versions of gcc-source from world builds so that: bitbake -c <stage> world will work. gcc-source deletes most bitbake build stages since it is a source-only package. Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29Empty image: filesystem allocationAlex Franco1
Increase sparse image block size when ROOTFS_SIZE is smaller than the minimum needed for ext4 to fit into it. [YOCTO #7664] Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29Empty image: package list splitting and iterationAlex Franco3
A few short fixes to splitting/iteration done over package lists in license.bbclass, package_manager.py and rootfs.py. [YOCTO #7664] Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29oeqa/runtime/multilib: fix and improve multilib testRoss Burton1
Replace the previous shell magic with a Python function to parse the readelf output, and fix the package names to include the lib32- prefix. [ YOCTO #8219 ] Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29qemuarm64.conf: Make the second serial console /dev/hvc0Randy Witt1
Since the qemu for aarch64 must use a virtual console for the second serial port rather than emulating actual hardware, make sure the correct device is specified so that a tty is actually started. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29sysvinit-inittab: Run ttys on ttys that don't have tty in the nameRandy Witt1
On qemuarm64 the second serial port in SERIAL_CONSOLES will be hvc0. Since that doesn't have tty in the name, a correct label didn't get added to inittab. This change makes both names with tty and without work. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29bind: remove dependency on bind in bind-devRoss Burton1
bind doesn't ship shared libraries only static libraries, so the default dependency on PN from PN-dev is pointless and means that an image with bind-dev installed (via dhcp-dev's automatic dependency) ends up with named installed and started on boot which is rarely intended. If and when we ship bind's shared libraries we should ensure that the libraries go into a separate package. Also remove an old comment about --enable-exportlib which isn't supported by configure anymore. [ YOCTO #8216 ] Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29qemurunner: Don't loop on EWOULDBLOCK in logging thread.Randy Witt1
EAGAIN/EWOULDBLOCK can be followed by no data. So don't tight loop waiting for data. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29runqemu-internal: Make sure tcpserial is always lastRandy Witt1
If this is not the case, sometimes the additional tcpserial will be enumerated as ttyS0, which is not what we want. Because then it would be the console, and qemurunner would not log things properly. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-29runtime/syslog.py: fix syslog test crashCostin Constantin1
This patch fixes the ability to correctly identify syslog's package name for the built image. It is derived from modifying oeqa/oetest.py for [YOCTO #8170] Signed-off-by: Costin Constantin <costin.c.constantin@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-26oeqa/oetest.py: add better package search for hasPackage()Costin Constantin1
Modified hasPackage() to split the content of pacakage manifest file in containing lines and search at the begining of each line the existance of the needed pkg. [YOCTO #8170] Signed-off-by: Costin Constantin <costin.c.constantin@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-26qemurunner: In the logging thread retry on EAGAIN, EWOULDBLOCKRandy Witt1
On a nonblocking socket an exception can be generated for the EAGAIN and EWOULDBLOCK errnos. Since these aren't actually errors make sure to retry rather than bailing out. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-26libnotify: update to version 0.7.6Alexander Kanavin2
New webkit requires at least version 0.7 Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-25qemurunner: Shut down logging thread successfully when test failsRandy Witt1
Before this change on a test failure an exception would be generated due to runqemu being killed before the logging thread which was on the other end of the socket. The exception was actually correct saying there was no data on a socket marked readable, but this was because the qemu process was killed before the listener thread. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-25layer.conf: Increase layer version to 6Richard Purdie1
This means we can use this as a test to enable certain autobuilder tests such as testsdk. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-24runqemu: Add a tcpserial optionRandy Witt3
The option was added so that the qemurunner could start a second tcp serial port without adding machine conditional logic to qemurunner. The issue that made this necessary was that when "virt" is passed to qemu-system-aarch64, the normal mechanism for specifying a tcp serial port does not work. This is because the hardware for the "virt" machine is hardcoded in the device tree blob and the addition devices must be virtio devices. So runqemu can specify virtio for qemuarm64 whereas it seems all other qemu machines work with the "-serial tcp*" option. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2015-08-24qemurunner: Use two serial ports and log console with a threadRandy Witt8
qemu can freeze and stop responding if the socket buffer connected to a tcp serial connection fills up. This happens of course when the reader of the serial data doesn't actually read it. This happened in the qemurunner code, because after checking for the "login:" sentinel, data was never again read from the serial connection. This patch solves the potential freeze by adding a thread to continuously read the data from the console and log it. So it also will give a full log of the console, rather than just up to the login prompt. To simplify this patch, another serial port was also added to use for the sole purpose of watching for the sentinel as well as being the interactive serial port. This will also prevent the possibility of lots of debug data on the console preventing the sentinel value from being seen due to interleaved text. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24qemurunner: Make create_socket() return data and use exceptionsRandy Witt1
So that create_socket() can be called more than once to create sockets, it now returns the socket and port rather than setting class variables directly. create_socket() now only uses exceptions for errors, not the return value from the function. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24qemurunner.py: Move some class variables that should only be localRandy Witt1
The bootlog and qemusock variables were set in the class as part of the create_socket() routine. However those variables are never used outside of the same function and thus serve no purpose as class variables. This initializes those variables near where they are used. Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24libcap-ng: add package 0.7.7Wenzong Fan2
Pull package from meta-oe to oe-core: meta-oe commit: bce4dba5546480c8e43c6442959ac7d0a4ef32f6 The libcap-ng library is intended to make programming with posix capabilities much easier than the traditional libcap library. It's not a replacement to libcap, it provides different library (libcap-ng.so) while packages explicitly look for libcap.so. It could be used by qemu, util-linux, libvirt, audit ... With adding it to oe-core, the copies from following layers could be removed: * meta-oe, meta-selinux, meta-security-framework ... Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24swig: add package 3.0.6Wenzong Fan4
Ackage from meta-oe to oe-core: meta-oe commit: 9cc54e10efa5ca70d9980f833a8e5a310e5ad21d It's required for libcap-ng to build python bindings. With adding it to oe-core, the copies from following layers could be removed: * meta-oe, meta-selinux, meta-intel-iot-middleware ... Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24xf86-video-intel: enable xvmc feature by default and fix dependencyReinette Chatre1
XvMC extends the X Video extension (Xv) and enables hardware rendered motion compensation support. In a test build enabling this feature increased the size of the xf86-video-intel package from 1386841 to 1847154 bytes. When we enable the xvmc feature in xf86-video-intel we see the following QA issue reported: QA Issue: xf86-video-intel rdepends on xcb-util, but it isn't a build dependency? We fix this by ensuring the build dependencies are set correctly when the xvmc feature is enabled. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24package_rpm.bbclass : escape "%" in files and directories nameSébastien Mennetrier1
The rpm process replace all the "%name" in the spec file by the name of the package. So, if the package is composed of some files or directories named "%name...", the rpm package process failed. Replace all "%" present in files or directories names by "%%%%%%%%" to correctly escape "%" due to the number of times that % is treated as an escape character. Jeff Johnson says this is the Right Thing To Do. [ YOCTO #5397 ] Signed-off-by: Sébastien Mennetrier <smennetrier@voxtok.com> Signed-off-by: Michaël Burtin <mburtin@voxtok.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24packagegroup-qt*-toolchain-target: fix hard dependency on phonon libraryPaul Eggleton1
Having disabled phonon by default in Qt4 we need to ensure this packagegroup is still buildable when it's not available. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24service: tweak example recipePaul Eggleton1
* Drop PR = "r0" * Reorder lines so that packaging definitions are at the end Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24hello-mod: drop PV and PRPaul Eggleton1
* PR = "r0" is the default, no need to set it (and most people won't need to set it anyway with the PR service) * PV = "0.1" is already set by virtue of 0.1 being in the filename Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2015-08-24oe-selftest: replace assertTrue(False, ...) with fail(...)Paul Eggleton2
I'd somehow missed the existence of fail() when I wrote these. It's preferable here so you don't get the somewhat useless "false is not true" message in the case of failure. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>