diff options
author | Robert Yang <liezhi.yang@windriver.com> | 2012-05-29 22:53:07 +0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-05-30 10:56:28 +0100 |
commit | 57f843146ed62c04c23bc380dc8cb38aba264f1c (patch) | |
tree | c2c678fdf02cd54bb4f81f8f06018b3d37542344 /scripts | |
parent | a07d03cc6f67c88feb9813ae7deb6e4a93552dfe (diff) | |
download | openembedded-core-57f843146ed62c04c23bc380dc8cb38aba264f1c.tar.gz openembedded-core-57f843146ed62c04c23bc380dc8cb38aba264f1c.tar.bz2 openembedded-core-57f843146ed62c04c23bc380dc8cb38aba264f1c.zip |
scripts: replace os.system with subprocess.call
Replace os.system with subprocess.call since the older function would
fail (more or less) silently if the executed program cannot be found
More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements
[YOCTO #2454]
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/rpm-createsolvedb.py | 5 | ||||
-rwxr-xr-x | scripts/swabber-strace-attach | 3 |
2 files changed, 5 insertions, 3 deletions
diff --git a/scripts/rpm-createsolvedb.py b/scripts/rpm-createsolvedb.py index 0d5f2198a9..a5b61bade7 100755 --- a/scripts/rpm-createsolvedb.py +++ b/scripts/rpm-createsolvedb.py @@ -14,6 +14,7 @@ import sys, os import hashlib import stat +import subprocess if len(sys.argv) < 1: print("Error, rpm command not specified") @@ -44,7 +45,7 @@ for path in paths: continue if os.path.exists(path + "/solvedb"): - os.system("rm -rf %s" % (path + "/solvedb")) + subprocess.call("rm -rf %s" % (path + "/solvedb"), shell=True) os.mkdir(path + "/solvedb") m = open(path + "/solvedb/manifest", "w") m.write("# Dynamically generated solve manifest\n") @@ -56,7 +57,7 @@ for path in paths: --noaid --nodeps --noorder --noscripts --notriggers --noparentdirs --nolinktos --stats \ --ignoresize --nosignature --nodigest -D "__dbi_txn create nofsync" \ ' + path + '/solvedb/manifest' - os.system(cmd) + subprocess.call(cmd, shell=True) open(path + "/solvedb.checksum", "w").write(checksum) open(path + "/solvedb.done", "w") diff --git a/scripts/swabber-strace-attach b/scripts/swabber-strace-attach index d4f80e4e91..bb0391a7ca 100755 --- a/scripts/swabber-strace-attach +++ b/scripts/swabber-strace-attach @@ -1,6 +1,7 @@ #!/usr/bin/env python import os import sys +import subprocess # Detach from the controlling terminal and parent process by forking twice to daemonize ourselves, # then run the command passed as argv[1]. Send log data to argv[2]. @@ -24,7 +25,7 @@ os.dup2(si.fileno(), sys.stdin.fileno()) os.dup2(so.fileno(), sys.stdout.fileno()) os.dup2(se.fileno(), sys.stderr.fileno()) -ret = os.system(sys.argv[1]) +ret = subprocess.call(sys.argv[1], shell=True) os._exit(ret) |