diff options
| author | Ulf Magnusson <ulfalizer@gmail.com> | 2016-10-01 04:47:01 +0200 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-10-03 15:46:21 +0100 |
| commit | 8e956d66087b9c41591b8e4e817ed6c9e42f5981 (patch) | |
| tree | b430324c54c928a2b525587963a92b3ff4fdb671 /meta | |
| parent | 8e9255763674703ea16651da64fe794e5359f16e (diff) | |
| download | openembedded-core-8e956d66087b9c41591b8e4e817ed6c9e42f5981.tar.gz openembedded-core-8e956d66087b9c41591b8e4e817ed6c9e42f5981.tar.bz2 openembedded-core-8e956d66087b9c41591b8e4e817ed6c9e42f5981.zip | |
systemd.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.
Motivating quote below:
< kergoth> the *original* intent was for the function/task to error via
whatever appropriate means, bb.fatal, whatever, and
funcfailed was what you'd catch if you were calling
exec_func/exec_task. that is, it's what those functions
raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself
FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
| -rw-r--r-- | meta/classes/systemd.bbclass | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass index db7873fbe2..d56c760a17 100644 --- a/meta/classes/systemd.bbclass +++ b/meta/classes/systemd.bbclass @@ -165,8 +165,7 @@ python systemd_populate_packages() { if path_found != '': systemd_add_files_and_parse(pkg_systemd, path_found, service, keys) else: - raise bb.build.FuncFailed("SYSTEMD_SERVICE_%s value %s does not exist" % \ - (pkg_systemd, service)) + bb.fatal("SYSTEMD_SERVICE_%s value %s does not exist" % (pkg_systemd, service)) # Run all modifications once when creating package if os.path.exists(d.getVar("D", True)): |