diff options
| author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-02-20 17:41:41 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-02-21 22:04:25 +0000 |
| commit | d0244702752f54fb74be427af1663e46bfff9a5d (patch) | |
| tree | 145b2460159e1e412812947948c50aa7a4e65023 /meta | |
| parent | 468fa9a7fac86bb0fcd3cbd18dc1492b57ca25f3 (diff) | |
| download | openembedded-core-d0244702752f54fb74be427af1663e46bfff9a5d.tar.gz openembedded-core-d0244702752f54fb74be427af1663e46bfff9a5d.tar.bz2 openembedded-core-d0244702752f54fb74be427af1663e46bfff9a5d.zip | |
lib/oe/package_manager: Performance tweak in regex usage
Profiling a core-image-sato-sdk rootfs, we're spending over 40s
compiling the same regex over and over again, roughly around 5 million
times.
This is suboptimal, fix for a 40s improvement on a 18.5minute task execution
time.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
| -rw-r--r-- | meta/lib/oe/package_manager.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py index f801333e54..69bef1dfbc 100644 --- a/meta/lib/oe/package_manager.py +++ b/meta/lib/oe/package_manager.py @@ -679,10 +679,10 @@ class RpmPM(PackageManager): def _search_pkg_name_in_feeds(self, pkg, feed_archs): for arch in feed_archs: arch = arch.replace('-', '_') + regex_match = re.compile(r"^%s-[^-]*-[^-]*@%s$" % \ + (re.escape(pkg), re.escape(arch))) for p in self.fullpkglist: - regex_match = r"^%s-[^-]*-[^-]*@%s$" % \ - (re.escape(pkg), re.escape(arch)) - if re.match(regex_match, p) is not None: + if regex_match.match(p) is not None: # First found is best match # bb.note('%s -> %s' % (pkg, pkg + '@' + arch)) return pkg + '@' + arch |