summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Larson <chris_larson@mentor.com>2010-12-06 14:58:55 -0700
committerRichard Purdie <rpurdie@linux.intel.com>2011-01-04 14:46:49 +0000
commitfcba92f3548b5fd3f4073a5d100660e9e79a67ac (patch)
tree2deab36a2e216bea350eb99e522e02f793e5ca67
parent23735bb765216b7a6086bc700d32d338f7649cc6 (diff)
downloadopenembedded-core-fcba92f3548b5fd3f4073a5d100660e9e79a67ac.tar.gz
openembedded-core-fcba92f3548b5fd3f4073a5d100660e9e79a67ac.tar.bz2
openembedded-core-fcba92f3548b5fd3f4073a5d100660e9e79a67ac.zip
Move the runq task start/failed messages to the UI
(Bitbake rev: ab831e867f09b47001cb8da2f8f060e04febf237) Signed-off-by: Chris Larson <chris_larson@mentor.com> Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
-rw-r--r--bitbake/lib/bb/runqueue.py15
-rw-r--r--bitbake/lib/bb/ui/knotty.py11
2 files changed, 15 insertions, 11 deletions
diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 6282e5cf9b..7f292290b2 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -1259,13 +1259,10 @@ class RunQueueExecuteTasks(RunQueueExecute):
Called when a task has failed
Updates the state engine with the failure
"""
- logger.error("Task %s (%s) failed with exit code '%s'", task,
- self.rqdata.get_user_idstring(task), exitcode)
-
self.stats.taskFailed()
fnid = self.rqdata.runq_fnid[task]
self.failed_fnids.append(fnid)
- bb.event.fire(runQueueTaskFailed(task, self.stats, self.rq), self.cfgData)
+ bb.event.fire(runQueueTaskFailed(task, self.stats, exitcode, self.rq), self.cfgData)
if self.rqdata.taskData.abort:
self.rq.state = runQueueCleanUp
@@ -1308,11 +1305,6 @@ class RunQueueExecuteTasks(RunQueueExecute):
self.task_complete(task)
return True
- logger.info("Running task %d of %d (ID: %s, %s)" % (self.stats.completed + self.stats.active + self.stats.failed + 1,
- self.stats.total,
- task,
- self.rqdata.get_user_idstring(task)))
-
pid, pipein, pipeout = self.fork_off_task(fn, task, taskname)
self.build_pids[pid] = task
@@ -1497,7 +1489,7 @@ class RunQueueExecuteScenequeue(RunQueueExecute):
def task_fail(self, task, result):
self.stats.taskFailed()
index = self.rqdata.runq_setscene[task]
- bb.event.fire(runQueueTaskFailed(task, self.stats, self), self.cfgData)
+ bb.event.fire(runQueueTaskFailed(task, self.stats, result, self), self.cfgData)
self.scenequeue_notcovered.add(task)
self.scenequeue_updatecounters(task)
@@ -1626,8 +1618,9 @@ class runQueueTaskFailed(runQueueEvent):
"""
Event notifing a task failed
"""
- def __init__(self, task, stats, rq):
+ def __init__(self, task, stats, exitcode, rq):
runQueueEvent.__init__(self, task, stats, rq)
+ self.exitcode = exitcode
self.message = "Task %s failed (%s)" % (task, self.taskstring)
class runQueueTaskCompleted(runQueueEvent):
diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index d3534a0f5b..b97c5a1b5e 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -192,6 +192,17 @@ def main(server, eventHandler):
logger.error("Nothing %sPROVIDES '%s'", r, event._item)
continue
+ if isinstance(event, bb.runqueue.runQueueTaskStarted):
+ logger.info("Running task %s of %s (ID: %s, %s)",
+ event.stats.completed + event.stats.active + event.stats.failed + 1,
+ event.stats.total, event.taskid, event.taskstring)
+ continue
+
+ if isinstance(event, bb.runqueue.runQueueTaskFailed):
+ logger.error("Task %s (%s) failed with exit code '%s'",
+ event.taskid, event.taskstring, event.exitcode)
+ continue
+
# ignore
if isinstance(event, (bb.event.BuildBase,
bb.event.StampUpdate,