summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2013-05-30 12:28:05 +0000
committerPaul Eggleton <paul.eggleton@linux.intel.com>2013-07-08 16:28:29 +0100
commite887858d495d772a4b2cd6ca4edc0c53942518d8 (patch)
tree1adc2f202dfb4d0f5f986fb439572e5353b8f828
parent20b50e8d99fa58818a23d3e82411ac1691e6552d (diff)
downloadopenembedded-core-e887858d495d772a4b2cd6ca4edc0c53942518d8.tar.gz
openembedded-core-e887858d495d772a4b2cd6ca4edc0c53942518d8.tar.bz2
openembedded-core-e887858d495d772a4b2cd6ca4edc0c53942518d8.zip
package: Ensure we iterate all the pool objects
There is the possibility that if we don't iterate through the multiprocessing pool objects we might not catch return codes and this could lead to hung/zombie processes either temproarily or on a wider scale. Adding this certainly doesn't hurt anything and is better practise so we might as well do it. Its not 100% clear if this fixes some issues or not. (From OE-Core master rev: 89c8493d4d85044cd72af2756569d15e87cd5947) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/package.bbclass4
1 files changed, 2 insertions, 2 deletions
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index affa34e808..551cafc51a 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -897,7 +897,7 @@ python split_and_strip_files () {
import multiprocessing
nproc = multiprocessing.cpu_count()
pool = bb.utils.multiprocessingpool(nproc)
- processed = pool.imap(oe.package.runstrip, sfiles)
+ processed = list(pool.imap(oe.package.runstrip, sfiles))
pool.close()
pool.join()
@@ -1249,7 +1249,7 @@ python package_do_filedeps() {
import multiprocessing
nproc = multiprocessing.cpu_count()
pool = bb.utils.multiprocessingpool(nproc)
- processed = pool.imap(oe.package.filedeprunner, pkglist)
+ processed = list(pool.imap(oe.package.filedeprunner, pkglist))
pool.close()
pool.join()