diff options
| author | Mark Hatle <mark.hatle@windriver.com> | 2013-03-19 15:20:59 -0500 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-04-03 16:53:52 +0100 |
| commit | 1416613e94af46c6e74532bca0f026d1540becbb (patch) | |
| tree | abad07612fc1a66718c5bca5c1d73f7464c09dd1 | |
| parent | 45e22312c48b23480bd6dff98702b0691a48f7d1 (diff) | |
| download | openembedded-core-1416613e94af46c6e74532bca0f026d1540becbb.tar.gz openembedded-core-1416613e94af46c6e74532bca0f026d1540becbb.tar.bz2 openembedded-core-1416613e94af46c6e74532bca0f026d1540becbb.zip | |
base.bbclass: Update the preferred_ml_updates
When processing the blacklists, we should avoid cross-canadian packages, as they
will not have any multilib prefixes to expand.
Similarly look for "virtual/nativesdk-" in addition to the existing "nativesdk-".
These items should also be ignored.
Finally, in order to avoid undeterministic variable key expansion, such as:
MYVAR = "foo"
PREFERRED_PROVIDER_${MYVAR} = "bar"
PREFERRED_PROVIDER_foo = "foobar"
during the multilib processing of PREFERRED_VERSION and PREFERRED_PROVIDER,
the code was changed to rename the variable key, to the final key. This along
with the existing code avoids the problems.
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
| -rw-r--r-- | meta/classes/base.bbclass | 24 |
1 files changed, 18 insertions, 6 deletions
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass index 68720a4a91..abd6a526c3 100644 --- a/meta/classes/base.bbclass +++ b/meta/classes/base.bbclass @@ -162,7 +162,7 @@ def preferred_ml_updates(d): providers.append(v) for pkg, reason in blacklists.items(): - if pkg.endswith(("-native", "-crosssdk")) or pkg.startswith("nativesdk-") or 'cross-canadian' in pkg: + if pkg.endswith(("-native", "-crosssdk")) or pkg.startswith(("nativesdk-", "virtual/nativesdk-")) or 'cross-canadian' in pkg: continue for p in prefixes: newpkg = p + "-" + pkg @@ -172,7 +172,7 @@ def preferred_ml_updates(d): for v in versions: val = d.getVar(v, False) pkg = v.replace("PREFERRED_VERSION_", "") - if pkg.endswith(("-native", "-crosssdk")) or pkg.startswith("nativesdk-"): + if pkg.endswith(("-native", "-crosssdk")) or pkg.startswith(("nativesdk-", "virtual/nativesdk-")): continue if 'cross-canadian' in pkg: for p in prefixes: @@ -182,8 +182,12 @@ def preferred_ml_updates(d): bb.data.update_data(localdata) newname = localdata.expand(v) if newname != v: - newval = localdata.getVar(v, True) + newval = localdata.expand(val) d.setVar(newname, newval) + # Avoid future variable key expansion + vexp = d.expand(v) + if v != vexp and d.getVar(v, False): + d.renameVar(v, vexp) continue for p in prefixes: newname = "PREFERRED_VERSION_" + p + "-" + pkg @@ -193,7 +197,7 @@ def preferred_ml_updates(d): for prov in providers: val = d.getVar(prov, False) pkg = prov.replace("PREFERRED_PROVIDER_", "") - if pkg.endswith(("-native", "-crosssdk")) or pkg.startswith("nativesdk-"): + if pkg.endswith(("-native", "-crosssdk")) or pkg.startswith(("nativesdk-", "virtual/nativesdk-")): continue if 'cross-canadian' in pkg: for p in prefixes: @@ -205,6 +209,10 @@ def preferred_ml_updates(d): if newname != prov: newval = localdata.expand(val) d.setVar(newname, newval) + # Avoid future variable key expansion + provexp = d.expand(prov) + if prov != provexp and d.getVar(prov, False): + d.renameVar(prov, provexp) continue virt = "" if pkg.startswith("virtual/"): @@ -220,19 +228,23 @@ def preferred_ml_updates(d): localdata.setVar("OVERRIDES", localdata.getVar("OVERRIDES", False) + override) bb.data.update_data(localdata) newname = localdata.expand(prov) - if newname != prov: + if newname != prov and not d.getVar(newname, False): d.setVar(newname, localdata.expand(val)) # implement alternative multilib name newname = localdata.expand("PREFERRED_PROVIDER_" + virt + p + "-" + pkg) if not d.getVar(newname, False): d.setVar(newname, val) + # Avoid future variable key expansion + provexp = d.expand(prov) + if prov != provexp and d.getVar(prov, False): + d.renameVar(prov, provexp) mp = (d.getVar("MULTI_PROVIDER_WHITELIST", True) or "").split() extramp = [] for p in mp: - if p.endswith(("-native", "-crosssdk")) or p.startswith("nativesdk-") or 'cross-canadian' in p: + if p.endswith(("-native", "-crosssdk")) or p.startswith(("nativesdk-", "virtual/nativesdk-")) or 'cross-canadian' in p: continue virt = "" if p.startswith("virtual/"): |