diff options
| author | Phil Blundell <philb@gnu.org> | 2012-09-29 13:20:05 +0100 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-10-02 11:16:30 +0100 |
| commit | f48a68177510e8f2d4fcc3725a6dfc41a9a8e96b (patch) | |
| tree | 7a88b5ecdbcf302d5c1d75da1f0b0572aaf48b74 | |
| parent | 7ebce895a215b31cf01aea2ac43e554f96ef814f (diff) | |
| download | openembedded-core-f48a68177510e8f2d4fcc3725a6dfc41a9a8e96b.tar.gz openembedded-core-f48a68177510e8f2d4fcc3725a6dfc41a9a8e96b.tar.bz2 openembedded-core-f48a68177510e8f2d4fcc3725a6dfc41a9a8e96b.zip | |
opkg: Don't call sync() when installing into an offline root
Even when installing onto a live target system, calling sync() during
package installation is of somewhat questionable benefit. But calling
it on the build host during rootfs construction is certainly useless and
can cause I/O to stall for several seconds on even a moderately sized
host which is clearly not desirable.
(From a patch originally by Mike Crowe.)
Signed-off-by: Phil Blundell <philb@gnu.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/recipes-devtools/opkg/opkg/opkg-no-sync-offline.patch | 18 | ||||
| -rw-r--r-- | meta/recipes-devtools/opkg/opkg_svn.bb | 3 |
2 files changed, 20 insertions, 1 deletions
diff --git a/meta/recipes-devtools/opkg/opkg/opkg-no-sync-offline.patch b/meta/recipes-devtools/opkg/opkg/opkg-no-sync-offline.patch new file mode 100644 index 0000000000..b1b3453484 --- /dev/null +++ b/meta/recipes-devtools/opkg/opkg/opkg-no-sync-offline.patch @@ -0,0 +1,18 @@ +When installing into an offline root, calling sync() is pointless and just +hurts performance. Don't let's do that. + +Signed-off-by: Phil Blundell <philb@gnu.org> +Upstream-Status: Pending + +--- a/libopkg/opkg_cmd.c 2011-09-08 10:53:07.000000000 +0100 ++++ b/libopkg/opkg_cmd.c 2011-10-04 10:45:22.278615584 +0100 +@@ -64,7 +64,8 @@ write_status_files_if_changed(void) + opkg_msg(INFO, "Writing status file.\n"); + opkg_conf_write_status_files(); + pkg_write_changed_filelists(); +- sync(); ++ if (!conf->offline_root) ++ sync(); + } else { + opkg_msg(DEBUG, "Nothing to be done.\n"); + } diff --git a/meta/recipes-devtools/opkg/opkg_svn.bb b/meta/recipes-devtools/opkg/opkg_svn.bb index d89a3f6c66..59bb2d94e2 100644 --- a/meta/recipes-devtools/opkg/opkg_svn.bb +++ b/meta/recipes-devtools/opkg/opkg_svn.bb @@ -11,6 +11,7 @@ SRC_URI = "svn://opkg.googlecode.com/svn;module=trunk;protocol=http \ file://0008-select_higher_version.patch \ file://0009-pkg_depends-fix-version-constraints.patch \ file://0010-pkg_depends-fix-version_constraints_satisfied.patch \ + file://opkg-no-sync-offline.patch \ " S = "${WORKDIR}/trunk" @@ -18,4 +19,4 @@ S = "${WORKDIR}/trunk" SRCREV = "633" PV = "0.1.8+svnr${SRCPV}" -PR = "${INC_PR}.5" +PR = "${INC_PR}.6" |