summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoshua Lock <josh@linux.intel.com>2012-05-23 13:50:38 -0700
committerRichard Purdie <richard.purdie@linuxfoundation.org>2012-05-24 08:34:50 +0100
commiteaeb1ffac653d0eb291480c3a72ab6d885f4ae1a (patch)
tree3d4a81c2afc2bd96ff3b631b6ce12a24e82b2257
parent61487342764684cacef765e221609fe16ffc2740 (diff)
downloadopenembedded-core-eaeb1ffac653d0eb291480c3a72ab6d885f4ae1a.tar.gz
openembedded-core-eaeb1ffac653d0eb291480c3a72ab6d885f4ae1a.tar.bz2
openembedded-core-eaeb1ffac653d0eb291480c3a72ab6d885f4ae1a.zip
Revert "sanity.bbclass: check user can read and write to SSTATE_DIR"
This has caused problems for several users, including the Yocto Project autobuilder. Since the message was added in order to be more user friendly revert the change. This reverts commit 0c0c4efbf92bcf0f8942f17c18525a4b4ed1798c.
-rw-r--r--meta/classes/sanity.bbclass17
1 files changed, 3 insertions, 14 deletions
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index ff3c413017..05545f45f7 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -96,16 +96,10 @@ def check_conf_exists(fn, data):
def check_sanity_sstate_dir_change(sstate_dir, data):
# Sanity checks to be done when the value of SSTATE_DIR changes
+ # Check that SSTATE_DIR isn't on a filesystem with limited filename length (eg. eCryptFS)
testmsg = ""
if sstate_dir != "":
- # Check that the user can read and write to SSTATE_DIR
- sstatemsg = check_can_read_write_directory(sstate_dir) or None
- if sstatemsg:
- sstatemsg = sstatemsg + ". You could try using it as an SSTATE_MIRRORS instead of SSTATE_CACHE.\n"
- testmsg = testmsg + sstatemsg
- # Check that SSTATE_DIR isn't on a filesystem with limited filename length (eg. eCryptFS)
- testmsg = testmsg + check_create_long_filename(sstate_dir, "SSTATE_DIR")
-
+ testmsg = check_create_long_filename(sstate_dir, "SSTATE_DIR")
return testmsg
def check_sanity_tmpdir_change(tmpdir, data):
@@ -156,12 +150,7 @@ def check_create_long_filename(filepath, pathname):
if errno == 36: # ENAMETOOLONG
return "Failed to create a file with a long name in %s. Please use a filesystem that does not unreasonably limit filename length.\n" % pathname
else:
- return "Failed to create a file in %s: %s\n" % (pathname, strerror)
- return ""
-
-def check_can_read_write_directory(directory):
- if not os.access(directory, os.R_OK|os.W_OK):
- return "Insufficient permissions for %s" % directory
+ return "Failed to create a file in %s: %s" % (pathname, strerror)
return ""
def check_connectivity(d):