openembedded-core.git/scripts/lib/wic/imager, branch jethro Mirror of openembedded-core wic: fix partition size calculation 2015-09-21T14:20:08+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-09-10T12:38:03+00:00 3703ecb4aa5267e6d7330e7978cc7c3bb2250ead It was wrongly assumed that part.size is meagured in Mb. In fact it's in Kb, so there is no need to convert bitbake variable ROOTFS_SIZE as it's also in Kb. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> 
It was wrongly assumed that part.size is meagured in Mb. In fact it's
in Kb, so there is no need to convert bitbake variable ROOTFS_SIZE as
it's also in Kb.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
wic: round variable before converting to int 2015-09-09T13:24:57+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-09-07T10:01:13+00:00 3479e299b5f11dfcd3f5f97c4ad3e0449f6c6d6a Wic uses bitbake variable ROOTFS_SIZE to set correspondent partition size. This variable is a literal representing float value. Wic crashes trying to convert it to int with the error: invalid literal for int() with base 10: '10166.0' Fixed this by converting variable to float and rounding result. This should work for int and float literals. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
Wic uses bitbake variable ROOTFS_SIZE to set correspondent
partition size. This variable is a literal representing
float value. Wic crashes trying to convert it to int with
the error: invalid literal for int() with base 10: '10166.0'

Fixed this by converting variable to float and rounding result.
This should work for int and float literals.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
wic: fix short variable names 2015-09-02T22:46:52+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-09-02T10:58:16+00:00 872cb0d5d79b26f34e6b35d7be8870d245021be4 Made short variable names longer and more readable. Fixed pylint warnings "Invalid variable name" and "Invalid argument name". Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
Made short variable names longer and more readable.

Fixed pylint warnings "Invalid variable name" and
"Invalid argument name".

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
wic: fix pylint warning redefined-builtin 2015-09-02T22:46:51+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-09-02T10:58:14+00:00 bed98142e3e47ac2862ccf8fe3e4bdeabfc91172 Renamed variables named as Python builtin functions. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
Renamed variables named as Python builtin functions.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
wic: fix pylint warning unused-variable 2015-09-02T22:46:51+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-09-02T10:58:13+00:00 3644b9f5ca25dfc61d4f5eda0f073c8a879b492b Removed or reworked code with unused variables. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
Removed or reworked code with unused variables.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
wic: use bitbake variable ROOTFS_SIZE 2015-08-30T22:26:14+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-08-30T21:14:27+00:00 173d440c14ee3140ae08c6a87decc9b2f4c9e391 If bitbake image is referenced in .ks file and --size is not used there wic uses ROOTFS_SIZE variable to set minimum partition size. ROOTFS_SIZE is calculated in meta/lib/oe/image.py when rootfs is created. The calculation is done using other image parameters: IMAGE_ROOTFS_SIZE, IMAGE_ROOTFS_ALIGNMENT, IMAGE_OVERHEAD_FACTOR and IMAGE_ROOTFS_EXTRA_SPACE. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
If bitbake image is referenced in .ks file and --size is not used
there wic uses ROOTFS_SIZE variable to set minimum partition size.

ROOTFS_SIZE is calculated in meta/lib/oe/image.py when rootfs is
created. The calculation is done using other image parameters:
IMAGE_ROOTFS_SIZE, IMAGE_ROOTFS_ALIGNMENT, IMAGE_OVERHEAD_FACTOR
and IMAGE_ROOTFS_EXTRA_SPACE.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
wic: Code cleanup: unused imports 2015-07-02T22:02:03+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-06-29T18:26:03+00:00 e77fda5fb6cb0a35308e4620ca4602715a471fbe Fixed pylint warning unused-import Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> 
Fixed pylint warning unused-import

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
wic: Code cleanup: long lines, identation and whitespaces 2015-07-02T22:01:49+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-06-29T15:01:42+00:00 db43e59f41b6bc19152cd4743585a3217015e272 Fixed pylint warnings bad-continuation, bad-continuation and line-too-long. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> 
Fixed pylint warnings bad-continuation, bad-continuation and
line-too-long.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
wic: Refactor fstab update code 2015-07-02T22:01:43+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-06-27T15:24:50+00:00 e663b1857fd2975585003bfa4739f8f84c652708 Made the code to backup and restore fstab only if it's modified. Cleaned up the code. Made it more pythonic. Improved code readability by moving code from several tiny methods into one place. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> 
Made the code to backup and restore fstab only if it's modified.

Cleaned up the code. Made it more pythonic.

Improved code readability by moving code from several tiny
methods into one place.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
wic: Include mount point into image report 2015-07-02T22:01:20+00:00 Ed Bartosh ed.bartosh@linux.intel.com 2015-06-27T07:54:46+00:00 36be9c1f7a6fded146a6f1c268455d826d78f97b Wic doesn't show any information for the partition if label is not set. Fixed this by adding mount point to the report. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> 
Wic doesn't show any information for the partition if label is not set.
Fixed this by adding mount point to the report.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>