openembedded-core.git/meta/recipes-support/attr/acl, branch pyro Mirror of openembedded-core acl: fix race issue when do_compile 2017-04-19T09:16:22+00:00 Robert Yang liezhi.yang@windriver.com 2017-04-18T08:33:20+00:00 73d3d81fcdb92dd85c6ad1609e3a6eb20f1ea539 Fixed race issue: In file included from acl_copy_entry.c:22:0: libacl.h:19:21: fatal error: sys/acl.h: No such file or directory #include <sys/acl.h> [snip] compilation terminated. acl_get_file.c:27:24: fatal error: acl/libacl.h: No such file or directory #include <acl/libacl.h> ^ The acl.h is in "include" directory, and include/Makefile creates symlink "sys" and "acl" poinst to current dirctory: $ ls include/ -l acl -> . sys -> . So if "libacl" target runs before "include", the error would happen since no "acl" or "sys" directory. Let libacl depend on include can fix the problem. [YOCTO #11349] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> 
Fixed race issue:
 In file included from acl_copy_entry.c:22:0:
 libacl.h:19:21: fatal error: sys/acl.h: No such file or directory
  #include <sys/acl.h>

[snip]

 compilation terminated.
 acl_get_file.c:27:24: fatal error: acl/libacl.h: No such file or directory
  #include <acl/libacl.h>
                         ^

The acl.h is in "include" directory, and include/Makefile creates
symlink "sys" and "acl" poinst to current dirctory:
$ ls include/ -l
acl -> .
sys -> .

So if "libacl" target runs before "include", the error would happen
since no "acl" or "sys" directory.

Let libacl depend on include can fix the problem.

[YOCTO #11349]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
acl: drop in instead of patching configure.ac 2017-01-31T14:40:17+00:00 Ross Burton ross.burton@intel.com 2016-11-14T13:19:28+00:00 14833280276c083a60d3d6fdbcc5e25eb2456c48 Signed-off-by: Ross Burton <ross.burton@intel.com> 
Signed-off-by: Ross Burton <ross.burton@intel.com>
acl.inc, run-ptest: improve ptest functionality on limited rootfs 2016-05-20T09:20:22+00:00 Peter Seebach peter.seebach@windriver.com 2016-05-18T21:30:47+00:00 0f1054e7db74bb4a196e00773915d7997b55bdf2 ACL's ptest has a handful of failure modes which can be triggered by a restrictive or small system. First, the ptest requires that daemon be in the bin group, which run-ptest attempts to do using gpasswd, but gpasswd is part of shadow, and oe-core removes shadow when it doesn't think shadow will be needed. Even if, say, a package has RDEPENDS on it. Whoops. So we manually sed the group file. This will probably work. Second, the filesystem used for the test has to support ACLs, so we create a dummy ext3 filesystem and use that. Third, the root/permissions test relies on the assumption that "mkdir d" produces a directory which non-root users can access, but in a secure product which defaults to umask 077, this doesn't work. (That fix has been separately reported to upstream acl through their bug report form.) (This may prevent the test from running without mkfs.ext3, but it allows the test to run on targets where root doesn't have ACL support. Tradeoffs, tradeoffs everywhere.) Signed-off-by: Peter Seebach <peter.seebach@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> 
ACL's ptest has a handful of failure modes which can be triggered by
a restrictive or small system. First, the ptest requires that daemon
be in the bin group, which run-ptest attempts to do using gpasswd,
but gpasswd is part of shadow, and oe-core removes shadow when it
doesn't think shadow will be needed. Even if, say, a package has
RDEPENDS on it. Whoops. So we manually sed the group file. This
will probably work.

Second, the filesystem used for the test has to support ACLs,
so we create a dummy ext3 filesystem and use that.

Third, the root/permissions test relies on the assumption that
"mkdir d" produces a directory which non-root users can access,
but in a secure product which defaults to umask 077, this doesn't
work. (That fix has been separately reported to upstream acl
through their bug report form.)

(This may prevent the test from running without mkfs.ext3, but it
allows the test to run on targets where root doesn't have ACL
support. Tradeoffs, tradeoffs everywhere.)

Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
acl: Fix re pattern in test cases 2016-03-06T23:52:56+00:00 He Zhe zhe.he@windriver.com 2016-03-03T07:16:43+00:00 2981d026460658fd2db7df3618d718fe6e8bfca0 ls adds a '.' at the end of the permission field list on SELinux machines, filter this out so root tests work on SELinux machines. And backport one patch for other tests. Signed-off-by: He Zhe <zhe.he@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
ls adds a '.' at the end of the permission field list on SELinux
machines, filter this out so root tests work on SELinux machines.
And backport one patch for other tests.

Signed-off-by: He Zhe <zhe.he@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
acl: fix the order of expected output of getfacl 2014-03-24T10:17:41+00:00 Chong Lu Chong.Lu@windriver.com 2014-03-24T08:12:47+00:00 a5180e942c9315d280580773e72fe67f27629a3c The result of getfacl is sorted by user id. In Centos or RHEL, bin user id is 1 and daemon user id is 2. But in our image, bin user id is 2 and daemon user id is 1. The patch fixes this issue to make ptest pass. Signed-off-by: Chong Lu <Chong.Lu@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
The result of getfacl is sorted by user id.
In Centos or RHEL, bin user id is 1 and daemon user id is 2.
But in our image, bin user id is 2 and daemon user id is 1.
The patch fixes this issue to make ptest pass.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
acl: enable ptest support 2014-02-17T15:27:55+00:00 Chong Lu Chong.Lu@windriver.com 2014-01-26T07:50:14+00:00 9b42aacca362ea5c404e2fd3ac25a51790ba41a5 Install acl test suite and run it as ptest. nfs test cases need depend on nfs service. So exclude them order to make ptest all pass. Signed-off-by: Chong Lu <Chong.Lu@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> 
Install acl test suite and run it as ptest.
nfs test cases need depend on nfs service. So exclude them order to
make ptest all pass.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
acl: Update to 2.2.52 2013-12-09T18:01:37+00:00 Saul Wold sgw@linux.intel.com 2013-12-02T21:38:35+00:00 3cedb6f45f596f755c471a320df3b184492b9d6c Need to add configure.ac since it was not delivered in the tarball Signed-off-by: Saul Wold <sgw@linux.intel.com> 
Need to add configure.ac since it was not delivered in the tarball

Signed-off-by: Saul Wold <sgw@linux.intel.com>