openembedded-core.git/meta/lib/oe/patch.py, branch 2016-10

lib/oe/patch: improve accuracy of patch header extraction

2016-09-23T17:06:10+00:00

When PATCHTOOL = "git", if we need to manually apply a patch and then
commit it (i.e. when git am doesn't work) we try to extract the author /
date / shortlog from the patch header. Make the following improvements
to that extraction process:

* If there's no explicit Subject: but the first line is followed by a
  blank line, isn't an Upstream-Status: or Index: marker and isn't too
  long, then assume it's good enough to be the shortlog. This avoids
  having too many patches with "Upgrade to version x.y" as the shortlog
  (since that is often when patches get added).
* Add --follow to the command we use to find the commit that added the
  patch, so we mostly get the commit that added the patch rather than
  getting stuck on upgrade commits that last moved/renamed the patch
* Populate the date from the commit that added the patch if we were able
  to get the author but not the date from the patch (otherwise you get
  today's date which is less useful).

Signed-off-by: Paul Eggleton 
Signed-off-by: Richard Purdie

lib/oe/patch: exclude "From " from commit message when PATCHTOOL is "git"

2016-09-23T17:06:10+00:00

If you leave "From " lines in the commit message it can actually
break git rebase because it tries to interpret the line in the context
of the current repository, and if the hash is invalid then a rebase
will blow up with:

  fatal: git cat-file: could not get object info

or in newer git versions:

  error: unable to find 
  fatal: git cat-file : bad file

(I hit this when I tried to do a devtool upgrade on openssl to 1.0.2i
the first time I did "git rebase --skip")

Signed-off-by: Paul Eggleton 
Signed-off-by: Richard Purdie

lib/oe/patch: handle non-UTF8 encoding when reading patches

2016-09-07T23:36:43+00:00

When extracting patches from a git repository with PATCHTOOL = "git" we
cannot assume that all patches will be UTF-8 formatted, so as with other
places in this module, try latin-1 if utf-8 fails.

This fixes UnicodeDecodeError running devtool update-recipe or devtool
finish on the openssl recipe.

Signed-off-by: Paul Eggleton

lib/oe/patch: commit with a dummy user/email when PATCHTOOL=git

2016-09-03T08:58:45+00:00

When using PATCHTOOL = "git", the user of the system is not really the
committer - it's the build system itself. Thus, specify "dummy" values
for username and email instead of using the user's configured values.
Various parts of the devtool code that need to make commits have also
been updated to use the same logic.

This allows PATCHTOOL = "git" and devtool to be used on systems where
git user.name / user.email has not been set (on versions of git where
it doesn't default a value under this circumstance).

If you want to return to the old behaviour where the externally
configured user name / email are used, set the following in your
local.conf:

PATCH_GIT_USER_NAME = ""
PATCH_GIT_USER_EMAIL = ""

Fixes [YOCTO #8703].

Signed-off-by: Paul Eggleton 
Signed-off-by: Richard Purdie

lib/oe/patch: handle encoding differences in patch files

2016-07-12T22:10:05+00:00

With Python 3, the encoding of a file is significant; several recipes in
OE-Core have patches which are not fully utf-8 decodable e.g. man,
lrzsz, and gstreamer1.0-libav, leading to errors when using devtool's
modify, upgrade or extract subcommands on these recipes. To work around
this, try reading the patch file as utf-8 first and if that fails try
latin-1 before giving up.

Signed-off-by: Paul Eggleton 
Signed-off-by: Ross Burton

scripts: Fix encoding errors for python3

2016-06-02T07:10:03+00:00

Moved call of decode('utf-8') as close as possible to
call of subprocess API to avoid calling it in a lot of
other places.

Decoded binary data to utf-8 where appropriate to fix devtool
and recipetool tests in python 3 environment.

Signed-off-by: Ed Bartosh

classes/lib: Convert to use python3 octal syntax

2016-06-02T07:10:02+00:00

The syntax for octal values changed in python3, adapt to it.

Signed-off-by: Richard Purdie

oe/patch: print cleaner error message when patch fails to apply

2016-04-03T14:51:08+00:00

[YOCTO #9344]

Signed-off-by: Markus Lehtonen 
Signed-off-by: Richard Purdie

oe/patch: more detailed error reporting

2016-04-03T14:51:08+00:00

Show the actual command that failed when raising a CmdError. Makes
figuring out what actually failed much easier.

[YOCTO #9344]

Signed-off-by: Markus Lehtonen 
Signed-off-by: Richard Purdie

devtool: commit for extra tasks that modify source when extracting

2016-02-11T12:32:55+00:00

When extracting source for a recipe, if there are additional custom
tasks run that make changes to the source, create a commit in the
generated git branch so they are contained. This is particularly
useful for tasks that come before do_patch since otherwise the changes
might get incorporated in the first applied patch, but otherwise it
helps avoid the tree being dirty at any point.

Fixes [YOCTO #7626].

Signed-off-by: Paul Eggleton 
Signed-off-by: Richard Purdie