openembedded-core.git/meta/classes/package_deb.bbclass, branch morty Mirror of openembedded-core package_deb.bbclass: Use bb.fatal() instead of raising FuncFailed 2016-10-03T14:46:21+00:00 Ulf Magnusson ulfalizer@gmail.com 2016-10-01T02:46:52+00:00 5a074e8a26d27ea9c4f31e2b75b2b14f6e0641d3 This sets a good example and avoids unnecessarily contributing to perceived complexity and cargo culting. Motivating quote below: < kergoth> the *original* intent was for the function/task to error via whatever appropriate means, bb.fatal, whatever, and funcfailed was what you'd catch if you were calling exec_func/exec_task. that is, it's what those functions raise, not what metadata functions should be raising < kergoth> it didn't end up being used that way < kergoth> but there's really never a reason to raise it yourself FuncFailed.__init__ takes a 'name' argument rather than a 'msg' argument, which also shows that the original purpose got lost. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.

Motivating quote below:

< kergoth> the *original* intent was for the function/task to error via
           whatever appropriate means, bb.fatal, whatever, and
           funcfailed was what you'd catch if you were calling
           exec_func/exec_task. that is, it's what those functions
           raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself

FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
package_deb.bbclass/package_ipk.bbclass: sort RPROVIDES 2016-07-25T22:46:59+00:00 Robert Yang liezhi.yang@windriver.com 2016-07-18T03:32:46+00:00 3506172d7d9f8d92362b6ebb75582b7c3e662dae The dict.fromkeys() creates a dict without order, there might be a problem when build the same recipe again, for example: - First build of make: Provides: es-translation, make-locale - Second build of acl: Provides: make-locale, es-translation They are exactly the same Provides, but tools like "diff" doesn't think so. Sort RPROVIDES will fix the problem. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> 
The dict.fromkeys() creates a dict without order, there might be a
problem when build the same recipe again, for example:

- First build of make:
  Provides: es-translation, make-locale
- Second build of acl:
  Provides: make-locale, es-translation

They are exactly the same Provides, but tools like "diff" doesn't think
so. Sort RPROVIDES will fix the problem.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
package_deb.bbclass: fix Python 3 error 2016-07-25T22:46:58+00:00 Matt Madison matt@madison.systems 2016-07-20T12:16:36+00:00 eb7f08c4c01313afc8350200eeb63daefde8a6f6 Don't modify an OrderedDict while walking its keys. Signed-off-by: Matt Madison <matt@madison.systems> Signed-off-by: Ross Burton <ross.burton@intel.com> 
Don't modify an OrderedDict while walking its keys.

Signed-off-by: Matt Madison <matt@madison.systems>
Signed-off-by: Ross Burton <ross.burton@intel.com>
package_deb: Avoid chdir warnings and restore cwd after packaging 2016-06-16T21:43:53+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2016-06-16T15:36:27+00:00 c294f4ed5a02b055916cfc26a2fca672edee1208 dpkg-build needs to be executed in the root of the package, so save and restore the current directory so this task doesn't modify the state. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
dpkg-build needs to be executed in the root of the package, so save and restore
the current directory so this task doesn't modify the state.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
classes/lib: Update to use python3 command pipeline decoding 2016-06-02T07:10:02+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2016-05-20T10:17:05+00:00 bb4685af1bffe17b3aa92a6d21398f38a44ea874 In python3, strings are unicode by default. We need to encode/decode from command pipelines and other places where we interface with the real world using the correct locales. This patch updates various call sites to use the correct encoding/decodings. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
In python3, strings are unicode by default. We need to encode/decode
from command pipelines and other places where we interface with the
real world using the correct locales. This patch updates various
call sites to use the correct encoding/decodings.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
classes/lib: Convert to use python3 octal syntax 2016-06-02T07:10:02+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2013-05-07T10:23:40+00:00 737a095fcde773a36e0fee1f27b74aaa88062386 The syntax for octal values changed in python3, adapt to it. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
The syntax for octal values changed in python3, adapt to it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
package-deb: Ignore circular dependencies 2016-03-12T22:11:21+00:00 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com 2016-03-10T13:47:09+00:00 d8bf148c3b740254ed23d52cf244f0f6e9c7a4ab If a package depends on itself apt-get fails to install it with the error attached to this patch. This patch checks for this conditions and notifies the user so the recipe maintainer can fix his RDEPENDS variable. root@qt5022:~# apt-get install perl-module-cpan Reading package lists... Done Building dependency tree Reading state information... Done The following NEW packages will be installed: perl-module-cpan 0 upgraded, 640 newly installed, 0 to remove and 0 not upgraded. Need to get 0 B/5964 kB of archives. After this operation, 0 B of additional disk space will be used. Do you want to continue? [Y/n] E: Internal error: MaxLoopCount reached in SmartUnPack (2) for perl-module-cpan:amd64, aborting E: Internal error, packages left unconfigured. perl-module-cpan:amd64 root@qt5022:~# apt-get install perl-modules Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> 
If a package depends on itself apt-get fails to install it with the
error attached to this patch.

This patch checks for this conditions and notifies the user so the
recipe maintainer can fix his RDEPENDS variable.

root@qt5022:~# apt-get install perl-module-cpan
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
  perl-module-cpan
0 upgraded, 640 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/5964 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n]
E: Internal error: MaxLoopCount reached in SmartUnPack (2) for
perl-module-cpan:amd64, aborting
E: Internal error, packages left unconfigured. perl-module-cpan:amd64
root@qt5022:~# apt-get install perl-modules

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
package_deb: Fix python runtime error 2016-03-12T22:11:21+00:00 Ricardo Ribalda Delgado ricardo.ribalda@gmail.com 2016-03-10T13:47:08+00:00 04aa40be126e00e2eb97311510e4d3ea90bfe7eb The dictionary cannot be used for iteration if its size may change during the loop. ERROR: Error executing a python function in /home/ricardo/curro/qt5022/build-qt5022/repo/yocto/meta/recipes-devtools/perl/perl_5.22.0.bb: Exception: RuntimeError: dictionary changed size during iteration Acked-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> 
The dictionary cannot be used for iteration if its size may change
during the loop.

ERROR: Error executing a python function in
/home/ricardo/curro/qt5022/build-qt5022/repo/yocto/meta/recipes-devtools/perl/perl_5.22.0.bb:
Exception: RuntimeError: dictionary changed size during iteration

Acked-by: Aníbal Limón <anibal.limon@linux.intel.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
package_deb: Ensure allarch deb packages aren't target specific 2016-02-10T15:51:04+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2016-02-07T17:09:08+00:00 65955cf1c7d5c59f29d769a8244ae7c156a43f38 The use of TUNE_FEATURES was making do_package_write_deb of allarch packages target specific. To avoid this, only use the end value of DPKG_ARCH for its checksum, not intermediate values or variables. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
The use of TUNE_FEATURES was making do_package_write_deb of allarch
packages target specific.

To avoid this, only use the end value of DPKG_ARCH for its checksum,
not intermediate values or variables.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
package_deb.bbclass: add 'Multi-Arch: foreign' tag to allarch packages 2016-01-11T23:23:17+00:00 Matt Madison matt@madison.systems 2016-01-06T12:21:35+00:00 7158c79a70e3d820c9701dacfa7206d13f95845a This tells APT that it can use such packages to resolve dependencies from packages of any architecture in a multilib build. Signed-off-by: Matt Madison <matt@madison.systems> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> 
This tells APT that it can use such packages to resolve dependencies
from packages of any architecture in a multilib build.

Signed-off-by: Matt Madison <matt@madison.systems>
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>