openembedded-core.git/meta/classes/package.bbclass, branch morty

package.bbclass: Use bb.fatal() instead of raising FuncFailed

2016-10-03T14:46:21+00:00

This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.

Motivating quote below:

< kergoth> the *original* intent was for the function/task to error via
           whatever appropriate means, bb.fatal, whatever, and
           funcfailed was what you'd catch if you were calling
           exec_func/exec_task. that is, it's what those functions
           raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself

FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.

Signed-off-by: Ulf Magnusson 
Signed-off-by: Richard Purdie

meta: cleanup d.getVar(var, 0)

2016-09-14T21:20:03+00:00

Signed-off-by: Robert Yang 
Signed-off-by: Ross Burton

package: correct subprocess.Popen.communicate() return values

2016-08-10T09:45:32+00:00

This is a non-functional change, which intends to correct element
names of a tuple returned by Popen.communicate().

Both in python2 and python3 subprocess.Popen.communicate() method
returns a tuple (stdoutdata, stderrdata), thus old assignments and
collateral comments are incorrect from human's point of view, however
formally there is no error in the code.

The change is desired to have to avoid copy-paste errors in future.

Signed-off-by: Vladimir Zapolskiy 
Signed-off-by: Ross Burton

package.bbclass: warn about files under symlinked directories

2016-08-10T09:45:13+00:00

[YOCTO #9827]

Signed-off-by: Markus Lehtonen 
Signed-off-by: Ross Burton

package.bbclass: better handling of middle-path dir symlinks

2016-08-10T09:45:13+00:00

For example in a directory structure like this
    .
    ├── symlink -> foo/bar
    └── foo
        └── bar
            └── file
'file' could be referenced by specifying e.g. 'foo/bar/file' or
'symlink/file'.  In cases like this populate_packages() might crash if
the file was referenced (in FILES) via the symlinked directory. The
outcome depends on how the user defined FILES_pn.  This patch should
make the function behave more consistently. It looks for files which are
referenced via symlinked directories and handles them separately,
failing if their parent directory is a non-existent path. For example,
defining FILES_{PN} = "symlink/file" causes a build failure because
symlinks target 'foo/bar' is not included at all.

[YOCTO #9827]

Signed-off-by: Markus Lehtonen 
Signed-off-by: Ross Burton

package.bbclass: remove unneeded chmod() and chown()

2016-08-10T08:36:22+00:00

* The mode and owner info are saved in inode, hardlink won't change them,
so remove unneeded chmod() and chown().

* This can avoid the problem that when do_package re-run, the file's mode
maybe different if it is 0444 (changed to 0644 when re-run), this is
caused by pseudo adds 'w' on real file, and doesn't track linked source
when hard link, Peter and Mark may fix pseudo, but the removed code is not
needed, which can avoid the problem.

* To reproduce the problem, for example, version.c from gzip's ${B}:
1) bitbake gzip
2) Edit rpm-native or package.bbclass to make do_package re-run.
3) bitbake gzip
After the first build, build/version.c in gzip-dbg is 0444, but after
the second build, it will be 0644, this because do_package does:
$ ln ${B}/version.c gzip-dbg/version.c,
$ chmod 0444 gzip-dbg/version.c (it runs chmod 0644 on the real filesystem)
And in the second build, the gzip-dbg/version.c will be removed and
created again, so that stat() can't get 0444 but 0644 since
${B}/version.c is not tracked by pseudo.

Signed-off-by: Robert Yang 
Signed-off-by: Ross Burton

classes/package: save/restore cwd in split_and_strip_files

2016-06-15T17:10:36+00:00

This function uses chdir() heavily, so save and restore the cwd so that it
doesn't affect the system state.

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie

classes/lib: Update to explictly create lists where needed

2016-06-02T07:10:02+00:00

Iterators now return views, not lists in python3. Where we need
lists, handle this explicitly.

Signed-off-by: Richard Purdie

classes/lib: Update to use python3 command pipeline decoding

2016-06-02T07:10:02+00:00

In python3, strings are unicode by default. We need to encode/decode
from command pipelines and other places where we interface with the
real world using the correct locales. This patch updates various
call sites to use the correct encoding/decodings.

Signed-off-by: Richard Purdie

package.bbclass: fix strip and split logic

2016-06-01T07:04:12+00:00

In order for strip and split to work together, we need to populate the
data structors if either split OR strip are not inhibited.

Original behaviour:

INHIBIT_PACKAGE_STRIP: no strip, no debug split
INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split

Behaviour after this patch:

INHIBIT_PACKAGE_STRIP: no strip, debug split
INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
BOTH: no strip, no split, DNP data structures

Signed-off-by: Stephano Cetola 
Signed-off-by: Richard Purdie