openembedded-core.git/meta/classes/metadata_scm.bbclass, branch fido

metadata_scm: Fix crash due to uncaught python exception

2014-12-03T12:22:41+00:00

Function base_get_metadata_svn_revision was crashing due to an uncaught
IndexError exception.

The except notation without parentheses is legacy syntax. It is the equivalent
to 'except IOError as IndexError' which is not what we want here.

The change catches both exceptions.

Signed-off-by: Merten Sach 
Signed-off-by: Ross Burton

metadata_scm: Avoid crashing on new svn version layouts

2013-11-22T15:12:33+00:00

This avoids crashing on newer svn layouts where the entries files
don't contain three lines. If someone wants to fix this to
get the right version on newer subversion checkouts, patches
welcome but this at least stops things crashing.

[YOCTO #5363]

Signed-off-by: Richard Purdie

class/lib: Fix up various file access methods

2013-05-09T21:25:31+00:00

There are various bits of cruft that have built up around our file accesses. This patch
cleans some of them up, specifically:

 * Remove pointless "from __builtin__ import file"
 * Use open(), not file()
 * Wrap file usage in a with container to ensure files are closed
 * Add missing .close() calls in some cases

Signed-off-by: Richard Purdie

metadata_scm: Replace deprecated operator

2013-05-09T13:04:18+00:00

The <> operator is deprecated, use != instead which is equivalent.

Signed-off-by: Richard Purdie

Convert tab indentation in python functions into four-space

2012-07-19T09:17:30+00:00

Signed-off-by: Richard Purdie

Revert "meta: replace os.popen with subprocess.Popen"

2012-05-30T13:20:04+00:00

This reverts commit e83d8e58a6b107eea87df0ec233a1bc932b2c6e as the conversion
is not correct. Its replacing readlines() calls which generate an array with
what are effectively strings. There are split("\n") calls missing in many
cases so this needs to be reverted until it gets fixed.

meta: replace os.popen with subprocess.Popen

2012-05-30T09:58:10+00:00

Replace os.popen with subprocess.Popen since the older function would
fail (more or less) silently if the executed program cannot be found

There are both bb.process.run() and bb.process.Popen() which wraps the
subprocess module, use it for simplifying the code.

Note: We don't need the "2>/dev/null" or "2>&1" since bb.process.run()
can handle it, it will raise exception when error occurs, we should
handle the exception ourselves if we want to ignore the error.

More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements

[YOCTO #2454]

Signed-off-by: Robert Yang 
Signed-off-by: Richard Purdie

meta: Convert getVar/getVarFlag(xxx, 1) -> (xxx, True)

2012-03-05T18:33:18+00:00

Using "1" with getVar is bad coding style and "True" is preferred.
This patch is a sed over the meta directory of the form:

sed \
 -e 's:\(\.getVar([^,()]*, \)1 *):\1True):g' \
 -e 's:\(\.getVarFlag([^,()]*, [^,()]*, \)1 *):\1True):g' \
 -i `grep -ril getVar *`

Signed-off-by: Richard Purdie

Convert to use direct access to the data store (instead of bb.data.Var())

2011-11-10T11:35:32+00:00

This is the result of running the following over the metadata:

sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`

Signed-off-by: Richard Purdie

metadata_scm.bbclass: Use COREBASE to grok for SCM operations

2011-05-11T09:21:10+00:00

Signed-off-by: Khem Raj