openembedded-core.git/meta/classes/metadata_scm.bbclass, branch dora Mirror of openembedded-core class/lib: Fix up various file access methods 2013-05-09T21:25:31+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2013-05-09T16:05:58+00:00 a43e0a8ecd0441131e929daf998c3cd454d9c8f3 There are various bits of cruft that have built up around our file accesses. This patch cleans some of them up, specifically: * Remove pointless "from __builtin__ import file" * Use open(), not file() * Wrap file usage in a with container to ensure files are closed * Add missing .close() calls in some cases Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
There are various bits of cruft that have built up around our file accesses. This patch
cleans some of them up, specifically:

 * Remove pointless "from __builtin__ import file"
 * Use open(), not file()
 * Wrap file usage in a with container to ensure files are closed
 * Add missing .close() calls in some cases

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
metadata_scm: Replace deprecated operator 2013-05-09T13:04:18+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2013-05-07T12:56:02+00:00 dde7af5f6c769eae721b1ee18462b841c8ea3277 The <> operator is deprecated, use != instead which is equivalent. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
The <> operator is deprecated, use != instead which is equivalent.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Convert tab indentation in python functions into four-space 2012-07-19T09:17:30+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2012-07-11T17:33:43+00:00 604d46c686d06d62d5a07b9c7f4fa170f99307d8 Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Revert "meta: replace os.popen with subprocess.Popen" 2012-05-30T13:20:04+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2012-05-30T13:20:04+00:00 f5356062443320c29a19cfd7113128caa185b221 This reverts commit e83d8e58a6b107eea87df0ec233a1bc932b2c6e as the conversion is not correct. Its replacing readlines() calls which generate an array with what are effectively strings. There are split("\n") calls missing in many cases so this needs to be reverted until it gets fixed. 
This reverts commit e83d8e58a6b107eea87df0ec233a1bc932b2c6e as the conversion
is not correct. Its replacing readlines() calls which generate an array with
what are effectively strings. There are split("\n") calls missing in many
cases so this needs to be reverted until it gets fixed.
meta: replace os.popen with subprocess.Popen 2012-05-30T09:58:10+00:00 Robert Yang liezhi.yang@windriver.com 2012-05-29T14:53:08+00:00 e83d8e58a6b107eea87df0ec233a1bc932b2c6ea Replace os.popen with subprocess.Popen since the older function would fail (more or less) silently if the executed program cannot be found There are both bb.process.run() and bb.process.Popen() which wraps the subprocess module, use it for simplifying the code. Note: We don't need the "2>/dev/null" or "2>&1" since bb.process.run() can handle it, it will raise exception when error occurs, we should handle the exception ourselves if we want to ignore the error. More info: http://docs.python.org/library/subprocess.html#subprocess-replacements [YOCTO #2454] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
Replace os.popen with subprocess.Popen since the older function would
fail (more or less) silently if the executed program cannot be found

There are both bb.process.run() and bb.process.Popen() which wraps the
subprocess module, use it for simplifying the code.

Note: We don't need the "2>/dev/null" or "2>&1" since bb.process.run()
can handle it, it will raise exception when error occurs, we should
handle the exception ourselves if we want to ignore the error.

More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements

[YOCTO #2454]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta: Convert getVar/getVarFlag(xxx, 1) -> (xxx, True) 2012-03-05T18:33:18+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2012-03-03T10:59:25+00:00 41bc192c0b5795561b239872008c91a867732219 Using "1" with getVar is bad coding style and "True" is preferred. This patch is a sed over the meta directory of the form: sed \ -e 's:\(\.getVar([^,()]*, \)1 *):\1True):g' \ -e 's:\(\.getVarFlag([^,()]*, [^,()]*, \)1 *):\1True):g' \ -i `grep -ril getVar *` Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
Using "1" with getVar is bad coding style and "True" is preferred.
This patch is a sed over the meta directory of the form:

sed \
 -e 's:\(\.getVar([^,()]*, \)1 *):\1True):g' \
 -e 's:\(\.getVarFlag([^,()]*, [^,()]*, \)1 *):\1True):g' \
 -i `grep -ril getVar *`

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Convert to use direct access to the data store (instead of bb.data.*Var*()) 2011-11-10T11:35:32+00:00 Richard Purdie richard.purdie@linuxfoundation.org 2011-11-09T15:00:01+00:00 b22831fd63164c4db9c0b72934d7d734a6585251 This is the result of running the following over the metadata: sed \ -e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \ -e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \ -e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \ -e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \ -e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \ -e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \ -i `grep -ril bb.data *` Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 
This is the result of running the following over the metadata:

sed \
-e 's:bb.data.\(setVar([^,()]*,[^,()]*\), *\([^ )]*\) *):\2.\1):g' \
-e 's:bb.data.\(setVarFlag([^,()]*,[^,()]*,[^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^(), ]*\) *,\([^)]*\)):\2.\1,\3):g' \
-e 's:bb.data.\(getVarFlag([^,()]*,[^,()]*\), *\([^() ]*\) *):\2.\1):g' \
-e 's:bb.data.\(getVar([^,()]*\), *\([^) ]*\) *):\2.\1):g' \
-i `grep -ril bb.data *`

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
metadata_scm.bbclass: Use COREBASE to grok for SCM operations 2011-05-11T09:21:10+00:00 Khem Raj raj.khem@gmail.com 2011-05-10T23:48:51+00:00 17c8c41b837d66bd3cc02c4c60e62dcfc13b80a8 Signed-off-by: Khem Raj <raj.khem@gmail.com> 
Signed-off-by: Khem Raj <raj.khem@gmail.com>
metadata_scm: Ensure that if an SCM isn't present, we dont print a revision of 'fatal:' as it looks bad 2010-10-21T22:26:40+00:00 Richard Purdie rpurdie@linux.intel.com 2010-10-21T22:26:40+00:00 d5504a4275d94868e28b00c272411e82f4999d95 Signed-off-by: Richard Purdie <rpurdie@linux.intel.com> 
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
metadata_scm.bbclass: Make errors quiet if we're not in a git based scm 2010-06-08T19:54:26+00:00 Joe Sauer jsauer@vernier.com 2010-06-08T19:54:26+00:00 47e5d86aad1ae96ba9c1af3ce5d7323e21b3f7fe Signed-off-by: Richard Purdie <rpurdie@linux.intel.com> 
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>