openembedded-core.git/meta/classes/image.bbclass, branch uninative-1.3

image: add do_image_qa task to run QA checks on the constructed image

2016-07-20T09:24:56+00:00

This task runs all functions in IMAGE_QA_COMMANDS after the image
construction has completed in order to validate the resulting image.

Image sanity checks should either be Python functions which raise
bb.build.FuncFailed on failure or shell functions with return a
non-zero exit code.

Python functions may instead raise an oe.utils.ImageQAFailed
Exception which takes an extra argument, a description of the
failure.

   python image_check_python_ok () {
       if True:
           raise bb.build.FuncFailed('This check always fails')
       else:
           bb.note("Nothing to see here")
   }

   image_check_shell_ok () {
       if true
           exit 1
       else
           exit 0
       fi
   }

[YOCTO #9448]

Signed-off-by: Joshua Lock 
Signed-off-by: Ross Burton

classes/image: implement progress support for do_rootfs

2016-07-07T12:29:01+00:00

Use the new task progress functionality to report progress during
do_rootfs. This is a little coarse and ideally we would have some
progress within the installation section, but it's better than
nothing.

Signed-off-by: Paul Eggleton 
Signed-off-by: Richard Purdie

classes/image: don't chdir when creating symlinks

2016-06-15T17:09:47+00:00

There's no need to chdir() when creating image symlinks, and using chdir()
changes the state for future tasks.

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie

image.bbclass: do exact match for rootfs type

2016-06-14T11:56:33+00:00

Do exact match for rootfs type, instead of pattern match, to avoid
unexpected build error due to redundant rootfs type build.

E.g. when building ext2.gz.u-boot, both .gz.u-boot and .u-boot are matched,
the following build error will appear, actually .u-boot is not needed.
| mkimage: Can't open .../core-image-minimal--.rootfs.ext2.gz: No such file or directory

Signed-off-by: Zhenhua Luo 
Signed-off-by: Richard Purdie

image/image_types.bbclass: fix fatal error during cpio debugfs creation

2016-06-12T22:46:45+00:00

If /init is just a symlink to /sbin/init, debugfs creation
fails with the following error:

ERROR: Error: The image creation script '<...>/debugfs.create_image.cpio' returned 1:
touch: cannot touch '<...>/cpio_append/init': Permission denied
WARNING: exit code 1 from a shell command.

ERROR: Function failed: do_rootfs

The reason is that IMAGE_CMD_cpio() is run twice on the same
WORKDIR. The first run creates a symlink in WORKDIR/cpio_append/init
to point to /sbin/init, while the 2nd run then tries to 'touch'
that link, which will fail, of course since /sbin/init is not
usually writable by non-root users.

Fix this by providing knowledge to the IMAGE_CMD_xxx() scripts
with regards to the fact that they are being executed in the
context of debugfs creation. The IMAGE_CMD_cpio() can now be
intelligent in the sense that it can avoid all additional symlink
handling during the debugfs run. The symlinks do not need to
be part of the debugfs, so we can skip that part altogether
in that case.

Signed-off-by: André Draszik 
Signed-off-by: Ross Burton

image.bbclass: additional output in create_symlinks

2016-05-22T15:09:22+00:00

When a symlink does not get created, it is useful for debugging to log
what would have been created and why it was skipped.

Signed-off-by: Patrick Ohly 
Signed-off-by: Ed Bartosh 
Signed-off-by: Ed Bartosh 
Signed-off-by: Ross Burton

image.bbclass: support duplicate compression types

2016-05-22T15:09:22+00:00

When a derived distro adds a certain type, say zip, to
COMPRESSIONTYPES and later OE-core does the same, we end up with the
type being listed twice, and that would have undesired effects
(commands generated twice).

So to support such loosely coupled extension, we de-duplicated the
list of types first.

Alternatively, such a situation could also be treated as error. But that
seems unnecessary because typically commands for the same type will also
do the same thing.

Signed-off-by: Patrick Ohly 
Signed-off-by: Ed Bartosh 
Signed-off-by: Ed Bartosh 
Signed-off-by: Ross Burton

image: Fix IMAGE_FEATURES determinism issue

2016-05-11T09:08:30+00:00

remain_features uses a dict which means the order is not deterministic. This
can lead to the task hash changing depending on the state of the memory at
parse time. This is particularly noticeable under python v3.

Since the dict is helpful in constructing the data, pass the data through
sort() so the order is always deterministic.

Signed-off-by: Richard Purdie

image.bbclass: don't execute compression commands multiple times

2016-04-29T06:53:57+00:00

In case of chained conversion methods are used via COMPRESS_CMD_*
there is chance that some of steps would be executed multiple times.

[YOCTO #9482]

Signed-off-by: Alexander D. Kanevskiy 
Signed-off-by: Ross Burton

image.bbclass: don't emit redundant IMAGE_CMD_xxx functions

2016-04-29T06:53:57+00:00

IMAGE_CMD_xxx commands are always inlined within do_image_xxx.

When IMAGE_CMD_xxx is defined as a function (e.g. IMAGE_CMD_btrfs,
IMAGE_CMD_cpio, etc), a redundant copy of the function will be emitted
by default. Remove IMAGE_CMD_xxx 'func' flags to prevent that.

Signed-off-by: Andre McCurdy 
Signed-off-by: Ross Burton