From b448a4e11127012a96bae8689e019879fbb8470f Mon Sep 17 00:00:00 2001 From: Martin Jansa Date: Mon, 28 Dec 2009 16:45:33 +0100 Subject: [PATCH] pxafb: fix regression from d2a34c13e7ccec5d06eafd60e6f80ea531b34668 fbi->dev->platform_data is void * and gcc does not allow to access !fbi->dev->platform_data->smart_update without cast platform_data to (struct pxafb_mach_info) or assignment as used in this patch. Signed-off-by: Martin Jansa --- drivers/video/pxafb.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c index 415858b..241468c 100644 --- a/drivers/video/pxafb.c +++ b/drivers/video/pxafb.c @@ -1223,12 +1223,17 @@ static int pxafb_smart_thread(void *arg) struct pxafb_info *fbi = arg; struct pxafb_mach_info *inf; - if (!fbi || !fbi->dev->platform_data->smart_update) { + if (!fbi) { pr_err("%s: not properly initialized, thread terminated\n", __func__); return -EINVAL; } inf = fbi->dev->platform_data; + if (!inf || !inf->smart_update) { + pr_err("%s: not properly initialized, thread terminated\n", + __func__); + return -EINVAL; + } pr_debug("%s(): task starting\n", __func__); -- 1.6.6