From d4276bed389b7db06db58c7acebb83f92bff86a5 Mon Sep 17 00:00:00 2001 From: Martin Jansa Date: Wed, 2 Jun 2010 15:04:25 +0200 Subject: recipes: conform to OE packaging guidelines with RDEPENDS/RRECOMMENDS * there is probably very few cases when it's needed without _${PN}, if you find one in attached patch, please enlighten me * usually we want those only for ${PN} not for all ${PACKAGES} ie ${PN}-dev, ${PN)-doc etc * there is a check for this in recipe-sanity.bclass * there is maybe few possible fixes also in bbclasses cpan-base.bbclass:RDEPENDS += "${@["perl", ""][(bb.data.inherits_class('native', d))]}" distutils-base.bbclass:RDEPENDS += "python-core" gtk-icon-cache.bbclass:RDEPENDS += "hicolor-icon-theme" image.bbclass:RDEPENDS += "${IMAGE_INSTALL} ${IMAGE_BOOT}" module.bbclass:RDEPENDS += "kernel (${KERNEL_VERSION}) update-modules" ?opie_i18n.bbclass: rdepends = bb.data.getVar("RDEPENDS", d, 1) ?opie_i18n.bbclass: bb.data.setVar('RDEPENDS_%s' % x[0].lower(), pn, d) ?opie_i18n.bbclass: bb.data.setVar('RDEPENDS', rdepends, d) rubyextension.bbclass:RDEPENDS += "ruby" Signed-off-by: Martin Jansa Acked-by: Koen Kooi --- recipes/iscsi-target/iscsi-target_0.4.17.bb | 2 +- recipes/iscsi-target/iscsi-target_1.4.19.bb | 2 +- recipes/iscsi-target/iscsi-target_svn.bb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'recipes/iscsi-target') diff --git a/recipes/iscsi-target/iscsi-target_0.4.17.bb b/recipes/iscsi-target/iscsi-target_0.4.17.bb index 1e12338e24..d237b5124b 100644 --- a/recipes/iscsi-target/iscsi-target_0.4.17.bb +++ b/recipes/iscsi-target/iscsi-target_0.4.17.bb @@ -11,7 +11,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/iscsitarget/iscsitarget-${PV}.tar.gz \ S = "${WORKDIR}/iscsitarget-${PV}" DEPENDS = "openssl" -RRECOMMENDS = "kernel-module-crc32c kernel-module-libcrc32c" +RRECOMMENDS_${PN} = "kernel-module-crc32c kernel-module-libcrc32c" inherit module diff --git a/recipes/iscsi-target/iscsi-target_1.4.19.bb b/recipes/iscsi-target/iscsi-target_1.4.19.bb index ff38f156cb..cf6e6a988a 100644 --- a/recipes/iscsi-target/iscsi-target_1.4.19.bb +++ b/recipes/iscsi-target/iscsi-target_1.4.19.bb @@ -16,7 +16,7 @@ S = "${WORKDIR}/iscsitarget-${PV}" DEPENDS = "openssl" -RRECOMMENDS = "kernel-module-crc32c kernel-module-libcrc32c" +RRECOMMENDS_${PN} = "kernel-module-crc32c kernel-module-libcrc32c" inherit module diff --git a/recipes/iscsi-target/iscsi-target_svn.bb b/recipes/iscsi-target/iscsi-target_svn.bb index 289d025207..c5e51a6c61 100644 --- a/recipes/iscsi-target/iscsi-target_svn.bb +++ b/recipes/iscsi-target/iscsi-target_svn.bb @@ -12,7 +12,7 @@ SRC_URI = "svn://svn.berlios.de/iscsitarget/;module=trunk;rev=HEAD \ " DEPENDS = " openssl" -RRECOMMENDS = "kernel-module-crc32c kernel-module-libcrc32c" +RRECOMMENDS_${PN} = "kernel-module-crc32c kernel-module-libcrc32c" S = "${WORKDIR}/trunk" -- cgit v1.2.3