From 548aea3b52f68af8da7f8fbd8067fc4600c8526b Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Thu, 23 Oct 2008 21:08:42 +0100 Subject: base.bbclass/bitbake.conf: Fix some string quoting to handle more unusual URLs (from Poky) --- classes/base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'classes') diff --git a/classes/base.bbclass b/classes/base.bbclass index b191940038..a54e6992b6 100644 --- a/classes/base.bbclass +++ b/classes/base.bbclass @@ -813,7 +813,7 @@ def oe_unpack_file(file, data, url = None): (type, host, path, user, pswd, parm) = bb.decodeurl(url) if 'dos' in parm: cmd = '%s -a' % cmd - cmd = '%s %s' % (cmd, file) + cmd = "%s '%s'" % (cmd, file) elif os.path.isdir(file): destdir = "." filespath = bb.data.getVar("FILESPATH", data, 1).split(":") -- cgit v1.2.3 From f362c9bb1ec5a010917a155b1649de890720d9c8 Mon Sep 17 00:00:00 2001 From: Marcin Juszkiewicz Date: Mon, 15 Mar 2010 07:55:49 +0100 Subject: base.bbclass: fix quoting for md5/sha256 checksums checking Signed-off-by: Marcin Juszkiewicz --- classes/base.bbclass | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'classes') diff --git a/classes/base.bbclass b/classes/base.bbclass index a54e6992b6..2f363127c6 100644 --- a/classes/base.bbclass +++ b/classes/base.bbclass @@ -81,7 +81,7 @@ def base_chk_file_vars(parser, localpath, params, data): if want_md5sum: try: - md5pipe = os.popen('PATH=%s md5sum %s' % (bb.data.getVar('PATH', data, True), localpath)) + md5pipe = os.popen('PATH=%s md5sum "%s"' % (bb.data.getVar('PATH', data, True), localpath)) md5data = (md5pipe.readline().split() or [ "" ])[0] md5pipe.close() except OSError, e: @@ -92,7 +92,7 @@ def base_chk_file_vars(parser, localpath, params, data): if want_sha256sum: try: - shapipe = os.popen('PATH=%s oe_sha256sum %s' % (bb.data.getVar('PATH', data, True), localpath)) + shapipe = os.popen('PATH=%s oe_sha256sum "%s"' % (bb.data.getVar('PATH', data, True), localpath)) sha256data = (shapipe.readline().split() or [ "" ])[0] shapipe.close() except OSError, e: @@ -131,14 +131,14 @@ def base_chk_file(parser, pn, pv, src_uri, localpath, data): # call md5(sum) and shasum try: - md5pipe = os.popen('PATH=%s md5sum %s' % (bb.data.getVar('PATH', data, True), localpath)) + md5pipe = os.popen('PATH=%s md5sum "%s"' % (bb.data.getVar('PATH', data, True), localpath)) md5data = (md5pipe.readline().split() or [ "" ])[0] md5pipe.close() except OSError: raise Exception("Executing md5sum failed") try: - shapipe = os.popen('PATH=%s oe_sha256sum %s' % (bb.data.getVar('PATH', data, True), localpath)) + shapipe = os.popen('PATH=%s oe_sha256sum "%s"' % (bb.data.getVar('PATH', data, True), localpath)) shadata = (shapipe.readline().split() or [ "" ])[0] shapipe.close() except OSError: -- cgit v1.2.3 From a9ecfad820594837aa3a0610b7d718c5dd8904dd Mon Sep 17 00:00:00 2001 From: Marcin Juszkiewicz Date: Mon, 15 Mar 2010 08:05:41 +0100 Subject: src_distribute_local: fix quoting Signed-off-by: Marcin Juszkiewicz --- classes/src_distribute_local.bbclass | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'classes') diff --git a/classes/src_distribute_local.bbclass b/classes/src_distribute_local.bbclass index 5cec2880aa..8cf0b426c0 100644 --- a/classes/src_distribute_local.bbclass +++ b/classes/src_distribute_local.bbclass @@ -6,24 +6,24 @@ SRC_DISTRIBUTECOMMAND[dirs] = "${SRC_DISTRIBUTEDIR}/${LIC}/${PN}" # symlinks the files to the SRC_DISTRIBUTEDIR SRC_DISTRIBUTECOMMAND-symlink () { - test -e ${SRC}.md5 && ln -sf ${SRC}.md5 . - ln -sf ${SRC} . + test -e "${SRC}.md5" && ln -sf "${SRC}.md5" . + ln -sf "${SRC}" . } # copies the files to the SRC_DISTRIBUTEDIR SRC_DISTRIBUTECOMMAND-copy () { - test -e ${SRC}.md5 && cp -f ${SRC}.md5 . - cp -fr ${SRC} . + test -e "${SRC}.md5" && cp -f "${SRC}.md5" . + cp -fr "${SRC}" . } # moves the files to the SRC_DISTRIBUTEDIR and symlinks them back SRC_DISTRIBUTECOMMAND-move+symlink () { if ! [ -L ${SRC} ]; then mv ${SRC} . - ln -sf $PWD/`basename ${SRC}` ${SRC} + ln -sf $PWD/`basename "${SRC}"` "${SRC}" if [ -e ${SRC}.md5 ]; then mv ${SRC}.md5 . - ln -sf $PWD/`basename ${SRC}.md5` ${SRC}.md5 + ln -sf $PWD/`basename "${SRC}.md5"` "${SRC}.md5" fi fi } -- cgit v1.2.3 From 9b67465cea384186375d9a31ad498176f7d59de6 Mon Sep 17 00:00:00 2001 From: Koen Kooi Date: Mon, 15 Mar 2010 16:07:07 +0100 Subject: sourcepkg.bbclass: put files in ${PN} subdir to avoid cluttering up the dir and generate diff *after* configure to pick up e.g. sed magic as well --- classes/sourcepkg.bbclass | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'classes') diff --git a/classes/sourcepkg.bbclass b/classes/sourcepkg.bbclass index 5aacf92d10..e11f72b6dd 100644 --- a/classes/sourcepkg.bbclass +++ b/classes/sourcepkg.bbclass @@ -30,7 +30,7 @@ def get_src_tree(d): sourcepkg_do_create_orig_tgz(){ - mkdir -p ${DEPLOY_DIR_SRC} + mkdir -p ${DEPLOY_DIR_SRC}/${PN} cd ${WORKDIR} for i in ${EXCLUDE_FROM}; do echo $i >> temp/exclude-from-file @@ -39,8 +39,8 @@ sourcepkg_do_create_orig_tgz(){ src_tree=${@get_src_tree(d)} echo $src_tree - oenote "Creating .orig.tar.gz in ${DEPLOY_DIR_SRC}/${P}.orig.tar.gz" - tar cvzf ${DEPLOY_DIR_SRC}/${P}.orig.tar.gz --exclude-from temp/exclude-from-file $src_tree + oenote "Creating .orig.tar.gz in ${DEPLOY_DIR_SRC}/${PN}/${P}.orig.tar.gz" + tar cvzf ${DEPLOY_DIR_SRC}/${PN}/${P}.orig.tar.gz --exclude-from temp/exclude-from-file $src_tree cp -pPR $src_tree $src_tree.orig } @@ -93,20 +93,20 @@ sourcepkg_do_create_diff_gz(){ cp $i $src_tree/${DISTRO}/files done - oenote "Creating .diff.gz in ${DEPLOY_DIR_SRC}/${P}-${PR}.diff.gz" - LC_ALL=C TZ=UTC0 diff --exclude-from=temp/exclude-from-file -Naur $src_tree.orig $src_tree | gzip -c > ${DEPLOY_DIR_SRC}/${P}-${PR}.diff.gz + oenote "Creating .diff.gz in ${DEPLOY_DIR_SRC}/${PN}/${P}-${PR}.diff.gz" + LC_ALL=C TZ=UTC0 diff --exclude-from=temp/exclude-from-file -Naur $src_tree.orig $src_tree | gzip -c > ${DEPLOY_DIR_SRC}/${PN}/${P}-${PR}.diff.gz rm -rf $src_tree.orig } EXPORT_FUNCTIONS do_create_orig_tgz do_archive_bb do_dumpdata do_create_diff_gz do_create_orig_tgz[deptask] = "do_unpack" -do_create_diff_gz[deptask] = "do_patch" +do_create_diff_gz[deptask] = "do_configure" do_archive_bb[deptask] = "do_patch" do_dumpdata[deptask] = "do_unpack" addtask create_orig_tgz after do_unpack before do_patch addtask archive_bb after do_patch before do_dumpdata addtask dumpdata after do_archive_bb before do_create_diff_gz -addtask create_diff_gz after do_dumpdata before do_configure +addtask create_diff_gz after do_configure before do_compile -- cgit v1.2.3 From 0b31947db8cc73fb23eecd3a1abaa3b4d465df9a Mon Sep 17 00:00:00 2001 From: Koen Kooi Date: Mon, 15 Mar 2010 16:13:31 +0100 Subject: sourcepkg.bbclass: OE's quilt now puts patches in patches/ instead of .pc/, so add that to the blacklist as well --- classes/sourcepkg.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'classes') diff --git a/classes/sourcepkg.bbclass b/classes/sourcepkg.bbclass index e11f72b6dd..65b1de5659 100644 --- a/classes/sourcepkg.bbclass +++ b/classes/sourcepkg.bbclass @@ -1,5 +1,5 @@ DEPLOY_DIR_SRC ?= "${DEPLOY_DIR}/sources" -EXCLUDE_FROM ?= ".pc autom4te.cache" +EXCLUDE_FROM ?= ".pc patches autom4te.cache" # used as part of a path. make sure it's set DISTRO ?= "openembedded" -- cgit v1.2.3 From 9bcb1b1bb571de4fa3cdfcfa2e3ba667b1ddfd04 Mon Sep 17 00:00:00 2001 From: Koen Kooi Date: Mon, 15 Mar 2010 16:24:33 +0100 Subject: sourcepkg: replace python with shell to avoid problems with packaged-staging --- classes/sourcepkg.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'classes') diff --git a/classes/sourcepkg.bbclass b/classes/sourcepkg.bbclass index 65b1de5659..7c202af4c9 100644 --- a/classes/sourcepkg.bbclass +++ b/classes/sourcepkg.bbclass @@ -36,7 +36,7 @@ sourcepkg_do_create_orig_tgz(){ echo $i >> temp/exclude-from-file done - src_tree=${@get_src_tree(d)} + src_tree=$(basename ${S}) echo $src_tree oenote "Creating .orig.tar.gz in ${DEPLOY_DIR_SRC}/${PN}/${P}.orig.tar.gz" @@ -46,7 +46,7 @@ sourcepkg_do_create_orig_tgz(){ sourcepkg_do_archive_bb() { - src_tree=${@get_src_tree(d)} + src_tree=$(basename ${S}) dest=${WORKDIR}/$src_tree/${DISTRO} mkdir -p $dest @@ -86,7 +86,7 @@ sourcepkg_do_create_diff_gz(){ done - src_tree=${@get_src_tree(d)} + src_tree=$(basename ${S}) for i in `find . -maxdepth 1 -type f`; do mkdir -p $src_tree/${DISTRO}/files -- cgit v1.2.3