From f6ac2d399aae6c6aad9b24a96abc860229c4a603 Mon Sep 17 00:00:00 2001 From: Chris Larson Date: Tue, 8 Jun 2010 07:46:58 -0700 Subject: utils.bbclass: set close_fds=True by default for the popen helper Signed-off-by: Chris Larson --- classes/utils.bbclass | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'classes/utils.bbclass') diff --git a/classes/utils.bbclass b/classes/utils.bbclass index 4e352e3b9c..64d6c231ec 100644 --- a/classes/utils.bbclass +++ b/classes/utils.bbclass @@ -61,13 +61,16 @@ def oe_popen(d, cmd, **kwargs): d.setVar("__oe_popen_env", env) kwargs["env"] = env + kwargs["close_fds"] = True kwargs["preexec_fn"] = subprocess_setup return Popen(cmd, **kwargs) -def oe_system(d, cmd): +def oe_system(d, cmd, **kwargs): """ Popen based version of os.system. """ - return oe_popen(d, cmd, shell=True).wait() + if not "shell" in kwargs: + kwargs["shell"] = True + return oe_popen(d, cmd, **kwargs).wait() # for MD5/SHA handling def base_chk_load_parser(config_paths): -- cgit v1.2.3