From 1268ed3f3ae0a76383e03b5c373b82c551c213a6 Mon Sep 17 00:00:00 2001 From: Holger Freyther Date: Wed, 25 Oct 2006 19:25:07 +0000 Subject: classes/insane.bbclass: Check if packages RDEPENDS on -dbg packages Untested check inspired by Richard to check if non debug packages depends on -dbg packages. --- classes/insane.bbclass | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) (limited to 'classes/insane.bbclass') diff --git a/classes/insane.bbclass b/classes/insane.bbclass index 55f7721153..062b1505b1 100644 --- a/classes/insane.bbclass +++ b/classes/insane.bbclass @@ -90,6 +90,37 @@ def package_qa_walk(path, funcs, package,d): func(path, package,d) +def package_qa_check_rdepends(pkg, d): + if not "-dbg" in pkg and not "task-" in pkg and not "-image" in pkg: + # Copied from package_ipk.bbclass + # boiler plate to update the data + localdata = bb.data.createCopy(d) + root = "%s/install/%s" % (workdir, pkg) + + bb.data.setVar('ROOT', '', localdata) + bb.data.setVar('ROOT_%s' % pkg, root, localdata) + pkgname = bb.data.getVar('PKG_%s' % pkg, localdata, 1) + if not pkgname: + pkgname = pkg + bb.data.setVar('PKG', pkgname, localdata) + + overrides = bb.data.getVar('OVERRIDES', localdata) + if not overrides: + raise bb.build.FuncFailed('OVERRIDES not defined') + overrides = bb.data.expand(overrides, localdata) + bb.data.setVar('OVERRIDES', overrides + ':' + pkg, localdata) + + bb.data.update_data(localdata) + + # Now check the RDEPENDS + rdepends = explode_deps(bb.data.getVar('RDEPENDS', localdata, True) or "") + + + # Now do the sanity check!!! + for rdepend in rdepends: + if "-dbg" in rdepend: + bb.error("QA issue, koen give us a better msg!!!") + # The PACKAGE FUNC to scan each package python do_package_qa () { bb.note("DO PACKAGE QA") @@ -104,6 +135,8 @@ python do_package_qa () { bb.note("Package: %s" % package) path = "%s/install/%s" % (workdir, package) package_qa_walk(path, [package_qa_check_rpath, package_qa_check_devdbg, package_qa_check_perm, package_qa_check_arch], package, d) + package_qa_check_rdepends(package, d) + } -- cgit v1.2.3 From 8050b45254a8f36b7873b2d9027d2fe902e79a87 Mon Sep 17 00:00:00 2001 From: Koen Kooi Date: Thu, 26 Oct 2006 08:58:25 +0000 Subject: insane.bbclass: import bb --- classes/insane.bbclass | 2 ++ 1 file changed, 2 insertions(+) (limited to 'classes/insane.bbclass') diff --git a/classes/insane.bbclass b/classes/insane.bbclass index 062b1505b1..f6000f1393 100644 --- a/classes/insane.bbclass +++ b/classes/insane.bbclass @@ -17,6 +17,7 @@ # possible and this is contained within the pax-utils-native # + # We play a special package function inherit package PACKAGE_DEPENDS += "pax-utils-native" @@ -91,6 +92,7 @@ def package_qa_walk(path, funcs, package,d): def package_qa_check_rdepends(pkg, d): + import bb if not "-dbg" in pkg and not "task-" in pkg and not "-image" in pkg: # Copied from package_ipk.bbclass # boiler plate to update the data -- cgit v1.2.3 From 4ae9f396b8b9630cb36f2e7fa793fa224ecdea45 Mon Sep 17 00:00:00 2001 From: Holger Freyther Date: Thu, 26 Oct 2006 12:35:01 +0000 Subject: classes/insane.class: Make workdir known, remove whitespace --- classes/insane.bbclass | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'classes/insane.bbclass') diff --git a/classes/insane.bbclass b/classes/insane.bbclass index f6000f1393..75602d0f44 100644 --- a/classes/insane.bbclass +++ b/classes/insane.bbclass @@ -91,27 +91,27 @@ def package_qa_walk(path, funcs, package,d): func(path, package,d) -def package_qa_check_rdepends(pkg, d): +def package_qa_check_rdepends(pkg, workdir, d): import bb if not "-dbg" in pkg and not "task-" in pkg and not "-image" in pkg: # Copied from package_ipk.bbclass # boiler plate to update the data localdata = bb.data.createCopy(d) root = "%s/install/%s" % (workdir, pkg) - + bb.data.setVar('ROOT', '', localdata) bb.data.setVar('ROOT_%s' % pkg, root, localdata) pkgname = bb.data.getVar('PKG_%s' % pkg, localdata, 1) if not pkgname: pkgname = pkg bb.data.setVar('PKG', pkgname, localdata) - + overrides = bb.data.getVar('OVERRIDES', localdata) if not overrides: raise bb.build.FuncFailed('OVERRIDES not defined') overrides = bb.data.expand(overrides, localdata) bb.data.setVar('OVERRIDES', overrides + ':' + pkg, localdata) - + bb.data.update_data(localdata) # Now check the RDEPENDS @@ -137,7 +137,7 @@ python do_package_qa () { bb.note("Package: %s" % package) path = "%s/install/%s" % (workdir, package) package_qa_walk(path, [package_qa_check_rpath, package_qa_check_devdbg, package_qa_check_perm, package_qa_check_arch], package, d) - package_qa_check_rdepends(package, d) + package_qa_check_rdepends(package, workdir, d) } -- cgit v1.2.3