From c89f99d26d4c54205988d91ca2417075ba737bc8 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Mon, 9 Apr 2007 21:50:12 +0000 Subject: patch.bbclass/devshell.bbclass: Switch to new form of interactive task handling as per RFC which is more compatible with bitbake 1.8+ --- classes/devshell.bbclass | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'classes/devshell.bbclass') diff --git a/classes/devshell.bbclass b/classes/devshell.bbclass index 14f957e12b..06152ef8bc 100644 --- a/classes/devshell.bbclass +++ b/classes/devshell.bbclass @@ -2,9 +2,10 @@ EXTRA_OEMAKE[export] = "1" do_devshell[dirs] = "${S}" do_devshell[nostamp] = "1" -do_devshell[interactive] = "1" + devshell_do_devshell() { - bash -i + export TERMWINDOWTITLE="Bitbake Developer Shell" + ${TERMCMD} } addtask devshell after do_patch -- cgit v1.2.3 From 2e2348dbf283fe186a7e45a4823b56fed70d47f0 Mon Sep 17 00:00:00 2001 From: Paul Sokolovsky Date: Fri, 11 May 2007 11:43:28 +0000 Subject: devshell.bbclass, patch.bbclass: Check exit code of TERMCMD* commands to see if they were found at all. * Fixes #2274. --- classes/devshell.bbclass | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'classes/devshell.bbclass') diff --git a/classes/devshell.bbclass b/classes/devshell.bbclass index 06152ef8bc..09ce100fc4 100644 --- a/classes/devshell.bbclass +++ b/classes/devshell.bbclass @@ -6,6 +6,10 @@ do_devshell[nostamp] = "1" devshell_do_devshell() { export TERMWINDOWTITLE="Bitbake Developer Shell" ${TERMCMD} + if [ $? -eq 127 ]; then + echo "Fatal: '${TERMCMD}' not found. Check TERMCMD variable." + exit 1 + fi } addtask devshell after do_patch -- cgit v1.2.3 From 500967160d58626953ec52c4f927445aed6150b2 Mon Sep 17 00:00:00 2001 From: Paul Sokolovsky Date: Fri, 11 May 2007 11:45:42 +0000 Subject: devshell.bbclass, patch.bbclass: Error on any non-zero rc from TERMCMD*. * Suggested by Richard Purdie. * Closes #2274. --- classes/devshell.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'classes/devshell.bbclass') diff --git a/classes/devshell.bbclass b/classes/devshell.bbclass index 09ce100fc4..35456b517b 100644 --- a/classes/devshell.bbclass +++ b/classes/devshell.bbclass @@ -6,7 +6,7 @@ do_devshell[nostamp] = "1" devshell_do_devshell() { export TERMWINDOWTITLE="Bitbake Developer Shell" ${TERMCMD} - if [ $? -eq 127 ]; then + if [ $? -ne 0 ]; then echo "Fatal: '${TERMCMD}' not found. Check TERMCMD variable." exit 1 fi -- cgit v1.2.3