From fe970f5bb77354b7507e230b1465e9178c80ee7a Mon Sep 17 00:00:00 2001
From: Serhii Kostiuk <serhii.o.kostiuk@globallogic.com>
Date: Thu, 18 Jul 2019 11:59:02 +0300
Subject: [MTS-MTQ] QuectelRadio implementation
Refactored the CellularRadio class to include base stub implementation
for the "CellularRadio::getCarrierFromFirmware" and
"CellularRadio::getHardwareVersionFromFirmware" methods.
From now assuming that those two possibilities are not supported
by the modem until otherwise specified (i.e. until the method
implementation was overridden in derived class).
This change was implemented after a code review.
---
src/MTS_IO_CellularRadio.cpp | 12 ++++++++++++
src/MTS_IO_QuectelRadio.cpp | 17 -----------------
2 files changed, 12 insertions(+), 17 deletions(-)
(limited to 'src')
diff --git a/src/MTS_IO_CellularRadio.cpp b/src/MTS_IO_CellularRadio.cpp
index 4dcea7d..feccd3c 100644
--- a/src/MTS_IO_CellularRadio.cpp
+++ b/src/MTS_IO_CellularRadio.cpp
@@ -976,6 +976,18 @@ bool CellularRadio::splitAndAssign(const std::string& sLine, const std::string&
return true;
}
+bool CellularRadio::getCarrierFromFirmware(const std::string& sFirmware, std::string& sCarrier) {
+ // Assuming that this function is not supported by the modem until overriden.
+
+ return false;
+}
+
+bool CellularRadio::getHardwareVersionFromFirmware(const std::string& sFirmware, std::string& sHardware) {
+ // Assuming that this function is not supported by the modem until overriden.
+
+ return false;
+}
+
const char *CellularRadio::RadioBandMap::getLTEBand(const int32_t channel)
{
for (unsigned int ii = 0; ii < NUM_LTE_BANDS; ii++)
diff --git a/src/MTS_IO_QuectelRadio.cpp b/src/MTS_IO_QuectelRadio.cpp
index 4d13e7b..0712788 100644
--- a/src/MTS_IO_QuectelRadio.cpp
+++ b/src/MTS_IO_QuectelRadio.cpp
@@ -470,23 +470,6 @@ CellularRadio::CODE QuectelRadio::getServiceDomain(ICellularRadio::SERVICEDOMAIN
return SUCCESS;
}
-bool QuectelRadio::getCarrierFromFirmware(const std::string& sFirmware, std::string& sCarrier) {
- // TODO: Implement properly if needed
- // This function is used only in CdmaRadio implementation but was defined in
- // the CellularRadio class before refactoring.
-
- // Find out if and how we can determine the operator by firmware version.
-
- return false;
-}
-
-bool QuectelRadio::getHardwareVersionFromFirmware(const std::string& sFirmware, std::string& sHardware) {
- // TODO: Implement properly
- // Find out if and how we can extract the hardware version from firmware version on Quectel devices
-
- return false;
-}
-
CellularRadio::CODE QuectelRadio::getIsSimInserted(bool& bData) {
printTrace("%s| Get SIM insertion status", getName().c_str());
--
cgit v1.2.3