From c9b6389ac4e53315e7d543091c821ea4b9771ed3 Mon Sep 17 00:00:00 2001 From: Serhii Kostiuk Date: Fri, 5 Jun 2020 13:55:04 +0300 Subject: [GP-651] LNA7: Allow to start the OMA DM procedure when it is required Fixed totally invalid string formatting for the stepCb argument. The previous implementation caused Json::Value to select the following constructor: ```Value(const char* begin, const char* end); ///< Copy all, incl zeroes.``` Which, of course, resulted in OOM violations. Oops. --- src/MTS_IO_QuectelRadio.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/MTS_IO_QuectelRadio.cpp b/src/MTS_IO_QuectelRadio.cpp index 360d988..4498919 100644 --- a/src/MTS_IO_QuectelRadio.cpp +++ b/src/MTS_IO_QuectelRadio.cpp @@ -498,7 +498,7 @@ ICellularRadio::CODE QuectelRadio::startOmaDm(ICellularRadio::UpdateCb& stepCb) if (sResponse.find(sOdmAbnormal) != std::string::npos) { printError("%s| OMA DM procedure failed due to internal error: [%s]", getName().c_str(), sResponse.c_str()); if (stepCb) { - stepCb(Json::Value("OMA DM Error: OMA DM failed due to internal error: [%s]", sOdmAbnormal.c_str())); + stepCb(Json::Value("OMA DM Error: OMA DM failed due to internal error")); } eCode = FAILURE; break; -- cgit v1.2.3