Age | Commit message (Collapse) | Author | Files |
|
Small improvements in code comments.
|
|
During testing I discrovered that EG25-G radio may lose some data during transmission
over Serial AT interface or just freezes and stops responding over Serial AT interface.
When ACK mode is not used, the radio may either return an error:
```
Expected: [+QFUPL: 24312545,fa6b], Actual: [+QFUPL: 17124608,b907
+CME ERROR: 409 // Fail to write the file
]
```
Or it may just freeze on modem_at1 interface and stop responding to AT commands:
```
8:0:34:32|TRACE|RADIO| Sending command [AT]
8:0:34:133|DEBUG|RESULT:
8:0:34:133|DEBUG|Shutting Down
```
This commit implements an alternative, ACK mode for data transmission to prevent data losses.
Data is sent in chunks and the device waits for ACK string from the radio for each chunk.
|
|
Added waitResponse overloads to the public interface of ICellularRadio.
|
|
Refactored MTS::IO::ICellularRadio::sendCommand. Moved response waiting code to the
MTS::IO::ICellularRadio::waitResponse function.
**Motivation**
In many places in the modern libmts-io implementation there are cases when we need to
wait for some response from the radio without executing or sending any commands.
Such places may wait for some URC messages, acknowledge strings during
data transmission and so on.
One way to handle such cases is to use `sendCommand` with `cmd` argument set to an empty
string. It generally works but according to POSIX:
"If count is zero and fd refers to a file other than a regular file, the results are
not specified."
The other way to handle such cases is to use `isNeedMoreData` callback of `sendCommand`
function to analyze all the data on the fly. But this approach may not work for data
transfers when `sendCommand` and its std::string argument may not be used to store binary
data with null characters within.
This commit moves the "wait for the radio to answer" part to the separate function
which allows reusablity of such a code.
|
|
During testing with L4G1 device I discovered some inconsistencies in behaviour between
EG25-G device and EG95 devices (EG95-NA and EG95-E).
EG25-G device that I have on hands does not allow to perform downgrades using delta images.
When there is an attempt to apply a downgrade delta image it behaves as the following:
- radio prints `OK`
- radio prints `+QIND: "FOTA",502`
- radio is not rebooted
While EG95 radios always reboot at least once to apply the firmware image. Even if it is not valid.
Also I noticed that detach from the serial bus may take more than 10 seconds in some rare cases.
Thus we need to wait not a fixed amount of time but until the radio actually detaches from the bus.
This commit attempts to address the findings described above.
|
|
|
|
Added more strict handling for comma-separated data in URC messages to prevent out-of-bounds reads.
|
|
Changes after code review:
1. Handle cases when the number of bytes written is different from the number of bytes requested to transfer.
2. Use fstat instead of lseek to determine the firmware size.
3. Renamed TelitRadio::startWrite and TelitRadio::abortWrite functions to better represent their applicability scope.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Implemented firmware version check detection.
|
|
Simplified usage of step callbacks in the QuectelRadio class.
Refactored existing function to use a wrapper and preven repetitive checks.
|
|
Started code cleanup before finishing the procedure.
Renamed functions related to the delta radio firmware upgrade to follow
established patterns:
- uploadDeltaFirmwareFile -> fumoLocalInject
- applyDeltaFirmwareFile -> fumoLocalApply
- removeDeltaFirmwareFile -> fumoLocalCleanup
- new function: updateFumoLocal - encapsulates all the magic for radios
that may not support separate stages for the delta upload and delta apply
|
|
Initial implementation of the "Apply delta firmware" step. Requires cleanup.
|
|
|
|
|
|
Merged all the changes from the intermediate release to master.
|
|
Changes after a code review:
- renamed "MTS Carrier Code" to the "Carrier Code";
- fixed descriptions for the new field and methods.
|
|
This commit adds implementation of the SIM-based carrier detection.
The goal for this implementation is to replace various places in the firmware
that previously relied on the ICCID-based carrier detection, provide some layer
of abstraction and forward compatibility for such places.
It is particularly useful for fwSwitch radios with AUTO firmware selection capability.
|
|
[MTX-3444] mPower Oct20: L4G1 libmts-io support
See merge request !23
|
|
Restore mtx 3262 single instance guard
See merge request !21
|
|
Vs/mtx 3251/modem does not work
See merge request !20
|
|
This commits adds support for the Quectel-specific OMA DM commands.
This allows to trigger OMA DM procedure om Verizon to fetch the corrent APN
values and other settings from the network.
Expected radio output on success:
```
+QODM: "DME",0,DM Start
+QODM: "DME",0,DM End
```
Other +QODM URC codes are also possible according to information from Quectel forum:
https://forums.quectel.com/t/what-is-the-meaning-of-qodm-fumo-report-failed/2444/5.
But only "DM Start" and "DM End" responses are expected, supported and treated
as correct in the libmts-io.
|
|
Initial implementation of the delta firmware image upload for Quectel radios.
|
|
Declared base interface and added started implementation for the QuectelRadio class.
Implemented file listing (file status check) and file removal logic.
|
|
Declared base interface and added stub implementation for the Delta Radio
Firmware Upgrade support in libmts-io.
|
|
|
|
Previous implementation was not thread/interprocess safe due to pid
management
Fixes: Single instance guard.
|
|
This reverts commit bab7e498b6dc31b6967a59fd728c5e5fe59d485c.
|
|
Previous implementation was not thread/interprocess safe due to pid
management
Fixes: Single instance guard.
|
|
|
|
Added "cellularMode" value to the list dynamic (network stats) params
|
|
Ported "cellularModeStr" function to MTS::IO::CellularRadio class. This function
converts integer bitmap to comma-separated list of cellular modes.
|
|
MTX-3211 Remove the code that is used to support ME910C1-NV and ME910C1-NA
See merge request !10
|
|
Defined "KEY_SUPPORTED_CELL_MODES" for a new field in radio-query --static output.
This new field will return a comma-separated list of cellular modes (2g,3g,4g)
that are supported by the modem.
|
|
|
|
|
|
|
|
Added LVW3 radio support to the libmts-io.
|
|
but radio-query returns 4g as well
|
|
L4 n1 mna1
See merge request !3
|
|
methods for get-cellular-mode
|
|
|
|
Use get/setCellularMode instead
Revert of commits:
4ef332ec707946a3cf2a55473d05dfc9af3d4b11
[MTS-MTQ] network radio mode switch: refactoring method name
143feb6a4587817d28c77e4df3a1b594b855f5e5
[MTS-MTQ] RAT mode switch: implementation for telit and quectel
|
|
|
|
|